New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 786043 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Chrome Home sometimes gets in state with blank Chrome Home surface

Project Member Reported by k...@chromium.org, Nov 16 2017

Issue description

Chrome Version: 64.0.3264.0
OS: Android

What steps will reproduce the problem?
(1) Randomly browsing with Chrome Home
(2) Swipe open Chrome Home

What is the expected result?
See sheet content

What happens instead?
No content in Chrome Home surface (repeated closes and opens will result in same issue though fixed by opening in a new tab)

- unfortunately don't have better repro instructions as it seems to happen randomly and couldn't get any consistent repro
 
Screenshot_20171114-200736.png
144 KB View Download
Cc: mdjones@chromium.org
Owner: mvanouwe...@chromium.org
Status: Assigned (was: Available)
This is likely a duplicate of issue 783078, which Michael marked as "Fixed" in issue 781163.
Cc: mvanouwe...@chromium.org
Labels: Needs-Feedback
Owner: k...@chromium.org
I don't really think this is the same issue. It's not the new tab UI, so the logo would not be shown. The other issue was a rendering bug with the logo.

What I'm seeing here seems like a failure of the whole sheet contents to show. In half-height on top of a tab we should really be seeing both tiles and an article card.

Kingston, without a repro it will be very hard to do anything about this. Could you maybe own this issue until you find a clearer repro?
Labels: -Pri-2 M-64 Pri-1
Kingston, these are the repro steps for the blank half sheet stemming from the NTP issue:

1. Open new tab
2. Focus omnibox, search for something
3. Pull up Chrome Home

Can you please see if this reproduces the issue for you? I can reproduce 100% of the time using these steps.

Comment 4 by k...@chromium.org, Nov 18 2017

Labels: -Fine-Pri-3.1 ReleaseBlock-Beta Fine-Pri-1.0
Yep that's a 100% repro. That's probably what caused it. Welp - bumping up the priority.
Cc: k...@chromium.org
Owner: mvanouwe...@chromium.org
Owner: k...@chromium.org
Thanks for the steps! However, this still does not reproduce for me in the following configs:

Chrome Canary 64.0.3271.3
Nexus 6
Android 7.0.0

Chrome Canary 64.0.3271.3
Pixel 2 XL
Android 8.1.0

What config do you use to reproduce this issue?
Issue 783078 has been merged into this issue.
Labels: -Type-Bug Type-Bug-Regression
Owner: mvanouwe...@chromium.org
I can reproduce on 64.0.3271.3 on a Pixel running 8.0.0. I'm in the Chrome Home promo group (opted-in to Chrome Home) and it looks like destroying suggestions each time the sheet is closed is disabled (thumbnails don't reload and ChromeHomeSuggestionsMemoryReduction is marked as 
"Disabled"). I suspect suggestions not getting destroyed is necessary to reproduce.

All experiment groups:
AndroidInProductHelpDataSaverPreview-EnabledV2
AndroidInProductHelpDownloadHome-Enabled
AndroidSigninPromos-Control
AppBannerTriggering-CheckOnPageLoad
AsyncDns-Control
BackgroundTracing-AggressiveLowMemorySignalStats
BlockTabUnders-Enabled
CSSExternalScanner-Control
CheckerImaging-Control2
ChromeChannelCanary-Enabled
ChromeHome-Forced_Enabled_Dogfood
ChromeHomeBottomNavLabels-Enabled
ChromeHomeIPHExpand-Default
ChromeHomeIPHMenuHeader-Default
ChromeHomePersonalizedOmniboxSuggestions-Enabled
ChromeHomeSuggestionsMemoryReduction-Disabled
ChromeSmartSelection-Enabled
CompositorImageAnimation-CompositorImageAnimation
ConsumeGestureOnNavigation-Control
ContentSuggestionsDebugLog-Enabled_Dogfood
ContextualSearch-Default
CopylessPaste-Enabled
DataCompressionProxyHoldback-Disabled
DataCompressionProxyPromoVisibility-EnabledWithSnackbarPromo
DataReductionProxySiteBreakdown-Enabled_Dogfood
DecoupleTranslateLanguage-Experiment_Dogfood
ExternalDataUseObserver-Enabled_Dogfood
FixDocumentLeakInAutofillAgent-Default
HTTP2-Control
KeepAliveRendererForKeepaliveRequests-Enabled_10sec
LazyParseCSS-Control
LoadingWithMojo-Enabled_Launch
MidiManagerDynamicInstantiation-Enabled_Dogfood
NTPArticleSuggestions-Enabled62-ChromeReader_Dogfood
NTPBreakingNewsPush-Enabled_Dogfood
NTPCacheFCSRequests-Enabled
NTPFaviconsFromNewServer-Enabled512
NTPPopularSites-EnabledWithShortNames_Dogfood
NetAdaptiveProxyConnectionTimeout-Enabled_Dogfood
NetDelayableH2AndQuicRequests-EnabledHead3
NetworkQualityEstimator-Enabled_all_Dogfood
NoStatePrefetchValidation-SimpleLoad_R2
OmniboxBundledExperimentV1-Dev_Android_SpannableInlineAutocomplete_ForceEnabled_Dogfood
OmniboxPlaceholderExperiment-Default
OomIntervention-DetectionOnly_Control
PasswordGeneration-Enabled
PreviewsClientLoFi-Enabled_2G_Replace_Server_Placeholders_Dogfood
PropagateFaviconCacheHits-Control
QUIC-EnabledVersion41
ResourceLoadScheduler-Enabled_bg_limit_8_2
S13nSafeBrowsingParallelUrlCheck-CanaryDev_Enabled
SafeBrowsingAdSamplerTrigger-Control
SafeBrowsingUseLocalBlacklist-Use3PAPI
ServiceWorkerPaymentApps-Enabled
ServiceWorkerScriptStreaming-Control
SimpleCachePrefetchExperiment-Control
SpeculativePreconnectValidation-Learning2
SpeculativeResourcePrefetchingValidation-Default
SubresourceFilter-Control_Dogfood
SyncUSSAutocomplete-Enabled
SyncUSSTypedURL-Enabled
SyncUserLanguageDetectionEventsStability-DisableSyncUserLanguageDetectionEvents
TLS13Variant-ControlV2
TabManagementExperiment-Elderberry
ThrottleDelayable-Default
UMA-Population-Restrict-dogfood
UMA-Uniformity-Trial-10-Percent-group_02
UMA-Uniformity-Trial-100-Percent-group_01
UMA-Uniformity-Trial-20-Percent-group_04
UMA-Uniformity-Trial-50-Percent-group_01
UseHeuristicLanguageModel-Experiment_Dogfood
UseMojoAudioOutputStreamFactory-Control
Status: Started (was: Assigned)
Excellent, disabling the ChromeHomeDestroySuggestions feature indeed allows me to reproduce this. Thanks!
Labels: -Needs-Feedback
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab682e979171979b4b0f4644769bcd9d8c1c54c2

commit ab682e979171979b4b0f4644769bcd9d8c1c54c2
Author: Michael van Ouwerkerk <mvanouwerkerk@google.com>
Date: Wed Nov 22 20:46:03 2017

Ensure the RecyclerView is visible in the suggestions bottom sheet.

Bug:  786043 
Change-Id: I2a898da8095d001b0b5cd839810dbebc915cc3b3
Reviewed-on: https://chromium-review.googlesource.com/785697
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518737}
[modify] https://crrev.com/ab682e979171979b4b0f4644769bcd9d8c1c54c2/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java

Status: Fixed (was: Started)

Sign in to add a comment