New issue
Advanced search Search tips

Issue 786034 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

webkit_layout_tests results no longer archive for viewing details about failure

Project Member Reported by flackr@chromium.org, Nov 16 2017

Issue description

The bots on the chromium waterfall seem to no longer upload the webkit_layout_tests for easy viewing. There used to be an archive step during which the test results would be uploaded and the build page would link to the results.

Example failing build:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64670

 
Labels: -Restrict-View-Google -Infra-Troopers
Owner: dpranke@chromium.org
Status: Assigned (was: Untriaged)
interesting. I wonder if I messed up something switching them to swarming.
Components: -Infra Infra>Client>Chrome
(infra bug triager here, triaging infra bugs)
Cc: dpranke@chromium.org jbudorick@chromium.org seanmccullough@chromium.org
Owner: martiniss@chromium.org
Hm. It looks like we're trying to upload the results now, and they're timing out for some reason:

https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/66130

@martiniss - does it make sense for you to look at this? If not, feel free to bounce this back to "available".

+seanmccullough b/c this is also an instance where we're not uploading results right.
I don't suppose there's some sort of whitelist that we might need to add chromium.win bots to? I have a vague memory of seanmccullough saying something like that, but I feel like it wasn't test-step-specific.
Labels: -Pri-2 Pri-1
It looks like we're also not archiving the results, which is bad (it makes it basically impossible to view what happened).
Those are 500s, so whitelisting isn't the (immediate) problem. 
Status: WontFix (was: Assigned)
Status: Available (was: WontFix)
Why did you WontFix this?
I thought it was working fine; looks like it actually isn't, so I do need to fix this. My bad.
Actually, this looks ok? https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/68663

The latest builds are failing the step, so it's not even uploading test results. But, the above build passed, and it ran the archive layout test results step successfully. So I think this is fine now?
Well, apart from the test suites hanging when they try to start up apache, yes, this might be fine.

We should be uploading the test results and archiving them regardless of whether they pass or fail, if for no other reason than to indicate that something went horribly wrong.


It does upload if there are results to upload, even if it fails. A few of the recent ones have no upload, because there are no results to upload; all the shards time out. 
Even if all the shards time out, I think we should probably upload *something*, in order to not have gaps in the data for a build. But, fixing this is a lower priority thing for sure.
Status: Assigned (was: Available)
Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment