New issue
Advanced search Search tips

Issue 785997 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Track down old -uni build suffix assumptions and delete them

Project Member Reported by jclinton@chromium.org, Nov 16 2017

Issue description

We are killing the reef-uni build and are not going to have any more builds that have -uni suffix. Any code that assumes this should be deleted.

Example:
http://cs/chromeos_public/src/third_party/chromiumos-overlay/eclass/cros-board.eclass?l=400&rcl=da28aff0a9ba3d7339cb33448cdb68536db395e5



 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/72553c06ec0f427917160e8c94a6c03c7ae5aaa6

commit 72553c06ec0f427917160e8c94a6c03c7ae5aaa6
Author: Jason D. Clinton <jclinton@chromium.org>
Date: Wed Dec 13 08:32:25 2017

cros-board.eclass: Drop assumption about -uni suffixes

BUG= chromium:785997 
TEST=cros_workon dev-install; ./build_packages

Change-Id: Ia78d9ff7a1f709dc41619fe59bfb41f068149712
Reviewed-on: https://chromium-review.googlesource.com/823570
Commit-Ready: Jason Clinton <jclinton@chromium.org>
Tested-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: C Shapiro <shapiroc@google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/72553c06ec0f427917160e8c94a6c03c7ae5aaa6/chromeos-base/dev-install/dev-install-9999.ebuild
[modify] https://crrev.com/72553c06ec0f427917160e8c94a6c03c7ae5aaa6/eclass/cros-board.eclass

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/firmware/+/2ead326ca41ceb550caf7c8132d11917a5c0dfc3

commit 2ead326ca41ceb550caf7c8132d11917a5c0dfc3
Author: Jason D. Clinton <jclinton@chromium.org>
Date: Thu Dec 14 01:26:09 2017

convert_to_model*: Drop special -uni suffix handling

BUG= chromium:785997 
TEST=FEATURES=test emerge-reef chromeos-firmware-reef

Change-Id: I79715054b69418e79151d1a1c87becc8e2353d5f
Reviewed-on: https://chromium-review.googlesource.com/824987
Commit-Ready: Jason Clinton <jclinton@chromium.org>
Tested-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: C Shapiro <shapiroc@google.com>

[modify] https://crrev.com/2ead326ca41ceb550caf7c8132d11917a5c0dfc3/convert_to_model.py
[modify] https://crrev.com/2ead326ca41ceb550caf7c8132d11917a5c0dfc3/convert_to_model_unittest.py

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 14 2017

Status: Fixed (was: Started)
Status: Archived (was: Fixed)

Sign in to add a comment