TwoClientUssSyncTest.ConflictResolution flaky on Linux Tests (dbg) bot |
||||||
Issue descriptionSome failed runs: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/45969 https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/45963 Sample logs: [ RUN ] TwoClientUssSyncTest.ConflictResolution [15483:15483:1116/013854.018106:1424533009:WARNING:loopback_server.cc(633)] Loopback sync persistent state file does not exist. Xlib: extension "RANDR" missing on display ":99". [15483:15521:1116/013858.134395:ERROR:bus.cc(395)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix") [15483:15483:1116/013858.189352:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. [15483:15509:1116/013858.341291:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file v8_context_snapshot.bin [15519:15519:1116/013858.595229:ERROR:gpu_info.cc(103)] No active GPU found, returning primary GPU. [15483:15483:1116/013858.831941:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. [15483:15509:1116/013859.063373:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file v8_context_snapshot.bin [15483:15483:1116/013859.199605:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. [15483:15483:1116/013859.456704:ERROR:child_account_info_fetcher_impl.cc(143)] ChildAccountInfoFetcherImpl::OnGetUserInfoSuccess: GetUserInfo response didn't include allServices field. [15483:15563:1116/013859.487169:WARNING:syncer_proto_util.cc(338)] Error posting from syncer: Response Code (bogus on error): -1 Content-Length (bogus on error): -1 Server Status: SYNC_AUTH_ERROR [15483:15563:1116/013859.491449:WARNING:get_updates_processor.cc(103)] Skipping unexpected progress marker for non-enabled type Bookmarks [15483:15563:1116/013859.492592:WARNING:sync_encryption_handler_impl.cc(970)] Nigori had empty encryption keybag. [15483:15563:1116/013859.495005:WARNING:sync_encryption_handler_impl.cc(970)] Nigori had empty encryption keybag. [15483:15563:1116/013859.525111:WARNING:sync_encryption_handler_impl.cc(346)] Ignoring new implicit passphrase. Keystore migration already performed. [15483:15563:1116/013859.551296:WARNING:get_updates_processor.cc(103)] Skipping unexpected progress marker for non-enabled type Bookmarks [15483:15504:1116/013859.592435:WARNING:simple_synchronous_entry.cc(1179)] Could not open platform files for entry. [15483:15483:1116/013859.610630:ERROR:child_account_info_fetcher_impl.cc(143)] ChildAccountInfoFetcherImpl::OnGetUserInfoSuccess: GetUserInfo response didn't include allServices field. [15483:15564:1116/013859.646138:WARNING:syncer_proto_util.cc(338)] Error posting from syncer: Response Code (bogus on error): -1 Content-Length (bogus on error): -1 Server Status: SYNC_AUTH_ERROR [15483:15564:1116/013859.654188:WARNING:get_updates_processor.cc(103)] Skipping unexpected progress marker for non-enabled type Bookmarks [15483:15564:1116/013859.654291:WARNING:get_updates_processor.cc(103)] Skipping unexpected progress marker for non-enabled type Themes [15483:15564:1116/013859.654393:WARNING:get_updates_processor.cc(103)] Skipping unexpected progress marker for non-enabled type Search Engines [15483:15564:1116/013859.654489:WARNING:get_updates_processor.cc(103)] Skipping unexpected progress marker for non-enabled type Sessions [15483:15564:1116/013859.654587:WARNING:get_updates_processor.cc(103)] Skipping unexpected progress marker for non-enabled type Apps [15483:15564:1116/013859.654737:WARNING:get_updates_processor.cc(103)] Skipping unexpected progress marker for non-enabled type Device Info [15483:15564:1116/013859.703518:WARNING:sync_encryption_handler_impl.cc(346)] Ignoring new implicit passphrase. Keystore migration already performed. [15483:15564:1116/013859.718490:WARNING:get_updates_processor.cc(103)] Skipping unexpected progress marker for non-enabled type Bookmarks [15483:15564:1116/013859.718573:WARNING:get_updates_processor.cc(103)] Skipping unexpected progress marker for non-enabled type Themes [15483:15564:1116/013859.718644:WARNING:get_updates_processor.cc(103)] Skipping unexpected progress marker for non-enabled type Search Engines [15483:15564:1116/013859.718719:WARNING:get_updates_processor.cc(103)] Skipping unexpected progress marker for non-enabled type Sessions [15483:15564:1116/013859.718800:WARNING:get_updates_processor.cc(103)] Skipping unexpected progress marker for non-enabled type Apps [15483:15564:1116/013859.731976:WARNING:get_updates_processor.cc(103)] Skipping unexpected progress marker for non-enabled type Device Info BrowserTestBase received signal: Terminated. Backtrace: #0 0x0000f68c0fc7 base::debug::StackTrace::StackTrace() #1 0x0000f68befcc base::debug::StackTrace::StackTrace() #2 0x00000f6bdd36 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x0000f77a6410 ([vdso]+0xffffe40f) #4 0x0000f77a6440 ([vdso]+0xffffe43f) #5 0x0000dd8ed47b __poll #6 0x0000ddff920b g_poll #7 0x0000ddfea3e8 <unknown> #8 0x0000ddfea528 g_main_context_iteration #9 0x0000f6992488 base::MessagePumpGlib::Run() #10 0x0000f698acfd base::MessageLoop::Run() #11 0x0000f698ad57 base::MessageLoop::Run() #12 0x0000f6a55fa6 base::RunLoop::Run() #13 0x00000a4b6a97 StatusChangeChecker::StartBlockingWait() #14 0x00000a4b690a StatusChangeChecker::Wait() #15 0x000008350ec6 (anonymous namespace)::TwoClientUssSyncTest_ConflictResolution_Test::RunTestOnMainThread() #16 0x00000f6bd71d content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #17 0x00000851302a _ZN4base8internal13FunctorTraitsIMN18OAuth2TokenService7FetcherEFvvEvE6InvokeIPS3_JEEEvS5_OT_DpOT0_ #18 0x000008512f4a _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN18OAuth2TokenService7FetcherEFvvEJPS5_EEEvOT_DpOT0_ #19 0x00000f6c042a _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLj0EEEEvOT_OT0_NSF_16integer_sequenceIjJXspT1_EEEE #20 0x00000f6c0311 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #21 0x00000854e03e _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #22 0x00000b2c5ce0 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #23 0x00000b2c32eb ChromeBrowserMainParts::PreMainMessageLoopRun() #24 0x0000ef201b45 content::BrowserMainLoop::PreMainMessageLoopRun() #25 0x0000edcae99a _ZN4base8internal13FunctorTraitsIMN7content14NetworkContext11DiskCheckerEFvvEvE6InvokeIPS4_JEEEvS6_OT_DpOT0_ #26 0x0000edcae8ba _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content14NetworkContextEFvvEJPS5_EEEvOT_DpOT0_ #27 0x0000ef20c66a _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLj0EEEEiOT_OT0_NSF_16integer_sequenceIjJXspT1_EEEE #28 0x0000ef20c551 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE #29 0x0000edc6389e _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #30 0x0000f0287333 content::StartupTaskRunner::RunAllTasksNow() #31 0x0000ef1fba89 content::BrowserMainLoop::CreateStartupTasks() #32 0x0000ef21285e content::BrowserMainRunnerImpl::Initialize() #33 0x0000ef1f2933 content::BrowserMain() #34 0x0000f166b731 content::RunNamedProcessTypeMain() #35 0x0000f166f0e0 content::ContentMainRunnerImpl::Run() #36 0x0000f166452f content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #37 0x0000ea546366 service_manager::Main() #38 0x0000f166a423 content::ContentMain() #39 0x00000f6bd1a4 content::BrowserTestBase::SetUp() #40 0x00000a4fbba4 InProcessBrowserTest::SetUp() #41 0x00000a4d0711 SyncTest::SetUp() #42 0x0000083d69bf testing::internal::HandleSehExceptionsInMethodIfSupported<>() #43 0x0000083c59d1 testing::internal::HandleExceptionsInMethodIfSupported<>() #44 0x0000083acf98 testing::Test::Run() #45 0x0000083addce testing::TestInfo::Run() #46 0x0000083ae987 testing::TestCase::Run() #47 0x0000083bc7e1 testing::internal::UnitTestImpl::RunAllTests() #48 0x0000083d769f testing::internal::HandleSehExceptionsInMethodIfSupported<>() #49 0x0000083c7671 testing::internal::HandleExceptionsInMethodIfSupported<>() #50 0x0000083bc3e5 testing::UnitTest::Run() #51 0x00000a7268bd RUN_ALL_TESTS() #52 0x00000a722eef base::TestSuite::Run() #53 0x00000a4f44e2 ChromeTestSuiteRunner::RunTestSuite() #54 0x00000a4f4655 ChromeTestLauncherDelegate::RunTestSuite() #55 0x00000f6f0295 content::LaunchTests() #56 0x00000a4f53d6 LaunchChromeTests() #57 0x00000a451278 main #58 0x0000dd827af3 __libc_start_main #59 0x000008189ee7 <unknown>
,
Nov 16 2017
skym@: You have edited this test in the past according to git blame. Can you help triage?
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39401d03fd341131af992a4e2f4cc796ece37f62 commit 39401d03fd341131af992a4e2f4cc796ece37f62 Author: Guido Urdaneta <guidou@chromium.org> Date: Thu Nov 16 16:29:22 2017 Disable flaky TwoClientUssSyncTest.ConflictResolution on Linux TBR=zea@chromium.org Bug: 785967 Change-Id: I7f5088c10e16ba77417d801de216f68c6a65322a Reviewed-on: https://chromium-review.googlesource.com/774884 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#517104} [modify] https://crrev.com/39401d03fd341131af992a4e2f4cc796ece37f62/chrome/browser/sync/test/integration/two_client_uss_sync_test.cc
,
Nov 16 2017
Sending this to pnoland@ who's dealt with this thing failing before, was the most recent one to change it (https://codereview.chromium.org/2497533003), and is this weeks bug fixer! Though, my first guess of culprit is https://chromium-review.googlesource.com/c/chromium/src/+/753983 , +pavely@
,
Nov 16 2017
,
Nov 17 2017
,
Nov 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e6b0d6ef5e6ebbad1134b0bd61f196776e9cc41 commit 1e6b0d6ef5e6ebbad1134b0bd61f196776e9cc41 Author: Pavel Yatsuk <pavely@chromium.org> Date: Mon Nov 27 20:26:14 2017 [Sync] Fix flaky TwoClientUssSyncTest.ConflictResolution test Previously test was relying on worker to cache updated value and therefore triggering conflict resolution when updated value was downloaded from server. After my change (https://crrev.com/c/753983) processor doesn't pass updated entities to worker until it is ready to commit it to server so waiting for the server to see the first commit greatly increases a chance of delivering update to client before local modifications are made. The fix is to change the way how conflict is emulated: - Make changes on client 0 while emulating network failure and wait for it to get into exponential backoff state - Make different change on client 1 and wait for it to appear on the server Now client 0 has local change to commit while server has different, conflicting value. Enabling network for client 0 should get it to download updates from server and trigger conflict resolution logic. BUG= 785967 R=pnoland@chromium.org Change-Id: Iec4d9c0364d8639b023f21a94bfeafb360153b32 Reviewed-on: https://chromium-review.googlesource.com/784114 Reviewed-by: Patrick Noland <pnoland@google.com> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#519384} [modify] https://crrev.com/1e6b0d6ef5e6ebbad1134b0bd61f196776e9cc41/chrome/browser/sync/test/integration/two_client_uss_sync_test.cc
,
Nov 27 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by guidou@chromium.org
, Nov 16 2017