Now changing API is painful.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/4dca30ab83b772e26282fc4ce1a3e9ba2ce1756d commit 4dca30ab83b772e26282fc4ce1a3e9ba2ce1756d Author: Roman Sorokin <rsorokin@chromium.org> Date: Sat Nov 25 11:50:14 2017 authpolicy: Intermediate D-Bus solution for both API First change in the series of changing D-Bus calls from bare strings to protobufs. Handles both API until Chrome change will have be landed. BUG= chromium:785956 TEST=manual CQ-DEPEND=CL:771630 Change-Id: I1962bc878653b03a86a09cf0f49af3c11215d941 Reviewed-on: https://chromium-review.googlesource.com/774741 Commit-Ready: Roman Sorokin <rsorokin@chromium.org> Tested-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> [modify] https://crrev.com/4dca30ab83b772e26282fc4ce1a3e9ba2ce1756d/authpolicy/authpolicy_unittest.cc [modify] https://crrev.com/4dca30ab83b772e26282fc4ce1a3e9ba2ce1756d/authpolicy/authpolicy.h [modify] https://crrev.com/4dca30ab83b772e26282fc4ce1a3e9ba2ce1756d/authpolicy/dbus_bindings/org.chromium.AuthPolicy.xml [modify] https://crrev.com/4dca30ab83b772e26282fc4ce1a3e9ba2ce1756d/authpolicy/samba_interface.cc [modify] https://crrev.com/4dca30ab83b772e26282fc4ce1a3e9ba2ce1756d/authpolicy/samba_interface.h [modify] https://crrev.com/4dca30ab83b772e26282fc4ce1a3e9ba2ce1756d/authpolicy/samba_helper.h [modify] https://crrev.com/4dca30ab83b772e26282fc4ce1a3e9ba2ce1756d/authpolicy/samba_helper.cc [modify] https://crrev.com/4dca30ab83b772e26282fc4ce1a3e9ba2ce1756d/authpolicy/authpolicy.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63c0c2163bdd4b26e7f80489579d4b64dd3c08f0 commit 63c0c2163bdd4b26e7f80489579d4b64dd3c08f0 Author: Roman Sorokin <rsorokin@chromium.org> Date: Tue Nov 28 09:43:04 2017 auth_policy_client: Switch inputs of D-Bus calls to protos. Switches JoinAdDomain and AuthenticateUser to protobuf args. Also switches RefreshUserPolicy to ObjectGUID. Should be landed after Chrome OS part will be landed. BUG= chromium:785956 TEST=manual CQ-DEPEND=CL:771630,CL:774741 Change-Id: I23db60080e684cc1d6cc51fcbafbb10c306bc924 Reviewed-on: https://chromium-review.googlesource.com/774883 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#519629} [modify] https://crrev.com/63c0c2163bdd4b26e7f80489579d4b64dd3c08f0/chrome/browser/chromeos/login/active_directory_login_browsertest.cc [modify] https://crrev.com/63c0c2163bdd4b26e7f80489579d4b64dd3c08f0/chrome/browser/chromeos/policy/active_directory_policy_manager_unittest.cc [modify] https://crrev.com/63c0c2163bdd4b26e7f80489579d4b64dd3c08f0/chromeos/BUILD.gn [modify] https://crrev.com/63c0c2163bdd4b26e7f80489579d4b64dd3c08f0/chromeos/dbus/auth_policy_client.cc [modify] https://crrev.com/63c0c2163bdd4b26e7f80489579d4b64dd3c08f0/chromeos/dbus/auth_policy_client.h [modify] https://crrev.com/63c0c2163bdd4b26e7f80489579d4b64dd3c08f0/chromeos/dbus/fake_auth_policy_client.cc [modify] https://crrev.com/63c0c2163bdd4b26e7f80489579d4b64dd3c08f0/chromeos/dbus/fake_auth_policy_client.h [modify] https://crrev.com/63c0c2163bdd4b26e7f80489579d4b64dd3c08f0/chromeos/dbus/fake_auth_policy_client_unittest.cc [modify] https://crrev.com/63c0c2163bdd4b26e7f80489579d4b64dd3c08f0/chromeos/login/auth/authpolicy_login_helper.cc [modify] https://crrev.com/63c0c2163bdd4b26e7f80489579d4b64dd3c08f0/chromeos/login/auth/authpolicy_login_helper.h
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/fb491e69f0dc8e2c5ca19806e822a1f2d747d3b5 commit fb491e69f0dc8e2c5ca19806e822a1f2d747d3b5 Author: Roman Sorokin <rsorokin@chromium.org> Date: Wed Dec 06 04:22:45 2017 authpolicy: Finish switch to protobuf D-Bus parameters Removes D-Bus interfaces that could handle both protobuf parameters and a legacy way of specifying parameters now that all users of this interface have been switched to protobufs. BUG= chromium:785956 TEST=manual Change-Id: I2de9b34ec301c6bc225774737b42a3eb7c57671f Reviewed-on: https://chromium-review.googlesource.com/796414 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Roman Sorokin <rsorokin@chromium.org> Reviewed-by: Roman Sorokin <rsorokin@chromium.org> [modify] https://crrev.com/fb491e69f0dc8e2c5ca19806e822a1f2d747d3b5/authpolicy/authpolicy.cc [modify] https://crrev.com/fb491e69f0dc8e2c5ca19806e822a1f2d747d3b5/authpolicy/authpolicy.h [modify] https://crrev.com/fb491e69f0dc8e2c5ca19806e822a1f2d747d3b5/authpolicy/dbus_bindings/org.chromium.AuthPolicy.xml [modify] https://crrev.com/fb491e69f0dc8e2c5ca19806e822a1f2d747d3b5/authpolicy/authpolicy_unittest.cc
CLs to fix autotest are in review: CL:*523798, CL:814555.
Also GetUserStatus call is being switched over to protobufs, see CL:789331.
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/autotest-private/+/ec470090a7f97c46ff0b0b420d15698252755b98 commit ec470090a7f97c46ff0b0b420d15698252755b98 Author: Lutz Justen <ljusten@chromium.org> Date: Wed Dec 13 20:33:36 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7d574e00bfab2485103fc30aa0a0f299909d52fd commit 7d574e00bfab2485103fc30aa0a0f299909d52fd Author: Lutz Justen <ljusten@chromium.org> Date: Wed Dec 13 20:33:36 2017 Use protobuf arguments for AuthPolicy D-Bus wrapper Changes the AuthPolicy D-Bus Python wrapper class to use protobuf args that have been introduced to simplify API changes. Additionally, - adds machine_ou and machine_domain parameters to domain join, - raises the timeout since the default timeout can be too short for some Samba calls, - addresses linter warnings and - runs yapf --style=google on the file. CQ-DEPEND=CL:*523798 BUG= chromium:785956 TEST=test_that -b ${BOARD} ${DUT_IP} enterprise_AuthPolicyDaemonServer Change-Id: I0957f87040bbeadb144c017e5b4dc68488d66426 Reviewed-on: https://chromium-review.googlesource.com/814555 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> [modify] https://crrev.com/7d574e00bfab2485103fc30aa0a0f299909d52fd/client/common_lib/cros/authpolicy.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a8503bb2cb05045f4fe1cb4c78667a1baa64e9d commit 8a8503bb2cb05045f4fe1cb4c78667a1baa64e9d Author: Roman Sorokin <rsorokin@chromium.org> Date: Sun Dec 17 22:41:09 2017 Chromad: Use GetUserStatusRequest for GetUserStatus It is an effort to make changing API easier. BUG= chromium:785956 Change-Id: If65bb11804a6ff84ea960bda4178c5a48ddae98c Reviewed-on: https://chromium-review.googlesource.com/829813 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#524630} [modify] https://crrev.com/8a8503bb2cb05045f4fe1cb4c78667a1baa64e9d/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc [modify] https://crrev.com/8a8503bb2cb05045f4fe1cb4c78667a1baa64e9d/chrome/browser/chromeos/policy/active_directory_policy_manager_unittest.cc [modify] https://crrev.com/8a8503bb2cb05045f4fe1cb4c78667a1baa64e9d/chromeos/dbus/auth_policy_client.cc [modify] https://crrev.com/8a8503bb2cb05045f4fe1cb4c78667a1baa64e9d/chromeos/dbus/auth_policy_client.h [modify] https://crrev.com/8a8503bb2cb05045f4fe1cb4c78667a1baa64e9d/chromeos/dbus/fake_auth_policy_client.cc [modify] https://crrev.com/8a8503bb2cb05045f4fe1cb4c78667a1baa64e9d/chromeos/dbus/fake_auth_policy_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/a7d7f5140c2ef4c71b4f4410b5ad5c7e048d0c63 commit a7d7f5140c2ef4c71b4f4410b5ad5c7e048d0c63 Author: Lutz Justen <ljusten@chromium.org> Date: Tue Jan 16 20:02:26 2018 authpolicy: Switch GetUserStatus back to simple Removes D-Bus interfaces that could handle both protobuf parameters and a legacy way of specifying parameters now that all users of this interface have been switched to protobufs. BUG= chromium:785956 TEST=manual Change-Id: I61e3fd92a2e375d8d886bbdf94a01e3562413d46 Reviewed-on: https://chromium-review.googlesource.com/868016 Commit-Ready: Lutz Justen <ljusten@chromium.org> Tested-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> [modify] https://crrev.com/a7d7f5140c2ef4c71b4f4410b5ad5c7e048d0c63/authpolicy/authpolicy.cc [modify] https://crrev.com/a7d7f5140c2ef4c71b4f4410b5ad5c7e048d0c63/authpolicy/authpolicy.h [modify] https://crrev.com/a7d7f5140c2ef4c71b4f4410b5ad5c7e048d0c63/authpolicy/dbus_bindings/org.chromium.AuthPolicy.xml [modify] https://crrev.com/a7d7f5140c2ef4c71b4f4410b5ad5c7e048d0c63/authpolicy/authpolicy_unittest.cc
Comment 1 by rsorokin@chromium.org
, Nov 16 2017