Enforce just one request at a time (allowing us to use member variables as opposed to callback arguments)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40de29e435234862271d41cfa08f356f6b99bc50 commit 40de29e435234862271d41cfa08f356f6b99bc50 Author: Kim Paulhamus <kpaulhamus@chromium.org> Date: Thu Dec 07 04:14:08 2017 Properly handle the enforcement of single requests to authenticator.mojom. Add a test for the timeout in the authenticator impl. Necessitates refactoring //device/u2f test code into a test_support target to set up a service_manager::Connector. Bug: 785950 , 785950 Change-Id: Idfd132a54909ceb8e7104e278434227ecac2c34c Reviewed-on: https://chromium-review.googlesource.com/775912 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#522333} [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/content/browser/webauth/authenticator_impl.cc [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/content/browser/webauth/authenticator_impl.h [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/content/browser/webauth/authenticator_impl_unittest.cc [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/content/test/BUILD.gn [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/device/BUILD.gn [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/device/u2f/BUILD.gn [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-basics.html [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerTypeConverters.cpp [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerTypeConverters.h [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/third_party/WebKit/Source/modules/credentialmanager/WebAuthenticationClient.cpp [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/third_party/WebKit/public/platform/modules/webauth/authenticator.mojom
Comment 1 by engedy@chromium.org
, Nov 16 2017