"Please add a unittest with the usual const struct {} kTestCases[] structure, and verify behavior for various combinations of origins (https, about, data, etc.) and rp_id's (not provided, correct, illegal)."
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40de29e435234862271d41cfa08f356f6b99bc50 commit 40de29e435234862271d41cfa08f356f6b99bc50 Author: Kim Paulhamus <kpaulhamus@chromium.org> Date: Thu Dec 07 04:14:08 2017 Properly handle the enforcement of single requests to authenticator.mojom. Add a test for the timeout in the authenticator impl. Necessitates refactoring //device/u2f test code into a test_support target to set up a service_manager::Connector. Bug: 785950 , 785950 Change-Id: Idfd132a54909ceb8e7104e278434227ecac2c34c Reviewed-on: https://chromium-review.googlesource.com/775912 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#522333} [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/content/browser/webauth/authenticator_impl.cc [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/content/browser/webauth/authenticator_impl.h [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/content/browser/webauth/authenticator_impl_unittest.cc [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/content/test/BUILD.gn [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/device/BUILD.gn [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/device/u2f/BUILD.gn [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-basics.html [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerTypeConverters.cpp [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerTypeConverters.h [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/third_party/WebKit/Source/modules/credentialmanager/WebAuthenticationClient.cpp [modify] https://crrev.com/40de29e435234862271d41cfa08f356f6b99bc50/third_party/WebKit/public/platform/modules/webauth/authenticator.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd76a26ef8c3eee5fbab993913c2056172846682 commit cd76a26ef8c3eee5fbab993913c2056172846682 Author: Kim Paulhamus <kpaulhamus@chromium.org> Date: Thu Jan 18 16:11:16 2018 Properly validate the relying party ID and origin permissions Performs security checks on the origin and relying party ID according to steps 5-7 in https://w3c.github.io/webauthn/#createCredential. Bug: 785950 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I6d138aaa6b8ae09fbe839b87e1cddb7dc88a9505 Reviewed-on: https://chromium-review.googlesource.com/775630 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#530155} [modify] https://crrev.com/cd76a26ef8c3eee5fbab993913c2056172846682/chrome/browser/password_manager/credential_manager_browsertest.cc [modify] https://crrev.com/cd76a26ef8c3eee5fbab993913c2056172846682/components/password_manager/content/common/credential_manager_struct_traits.cc [modify] https://crrev.com/cd76a26ef8c3eee5fbab993913c2056172846682/content/browser/bad_message.h [modify] https://crrev.com/cd76a26ef8c3eee5fbab993913c2056172846682/content/browser/webauth/authenticator_impl.cc [modify] https://crrev.com/cd76a26ef8c3eee5fbab993913c2056172846682/content/browser/webauth/authenticator_impl_unittest.cc [modify] https://crrev.com/cd76a26ef8c3eee5fbab993913c2056172846682/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter [modify] https://crrev.com/cd76a26ef8c3eee5fbab993913c2056172846682/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-basics.html [add] https://crrev.com/cd76a26ef8c3eee5fbab993913c2056172846682/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-from-nested-frame.html [add] https://crrev.com/cd76a26ef8c3eee5fbab993913c2056172846682/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-origins.html [modify] https://crrev.com/cd76a26ef8c3eee5fbab993913c2056172846682/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/credential-helpers.js [add] https://crrev.com/cd76a26ef8c3eee5fbab993913c2056172846682/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/nested-mock-authenticator-client.html [add] https://crrev.com/cd76a26ef8c3eee5fbab993913c2056172846682/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/publickey-create-helper.html [modify] https://crrev.com/cd76a26ef8c3eee5fbab993913c2056172846682/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerTypeConverters.cpp [modify] https://crrev.com/cd76a26ef8c3eee5fbab993913c2056172846682/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp [modify] https://crrev.com/cd76a26ef8c3eee5fbab993913c2056172846682/third_party/WebKit/Source/platform/weborigin/SecurityOriginTest.cpp [modify] https://crrev.com/cd76a26ef8c3eee5fbab993913c2056172846682/third_party/WebKit/public/platform/modules/credentialmanager/credential_manager.mojom [modify] https://crrev.com/cd76a26ef8c3eee5fbab993913c2056172846682/third_party/WebKit/public/platform/modules/webauth/authenticator.mojom [modify] https://crrev.com/cd76a26ef8c3eee5fbab993913c2056172846682/tools/metrics/histograms/enums.xml
Comment 1 by engedy@chromium.org
, Nov 16 2017