HWTests are always disabled on tryjob unless you run tryjob with --hwtest.

+ dgarrett@ to confirm 

Ah thank you, that's good to know. Any reason why that's not the default? Can we at least add a warning? I don't think most people know this.

nxia is correct. We disable them by default because we don't have the lab capacity to handle unplanned load very well.

Even if you enable them, tryjob hwtests should only be consider "best effort" since there may or may not be any DUTs available to run them. Further, it's possible for tryjob hwtests to interfere with normal testing (mostly only a problem when weekly test suites are running).

From a lab management point of view, we'd love to fully disable them. From a developer support point of view, we'd love to enable them by default.

What we have now is the compromise.

Would you accept a CL with a text warning?

Sure. It would be best if it only issues the warning if the build config in question includes hwtests to start with.

Where does that mapping live?

cli/cros/cros_tryjob.


VerifyOptions is the right place for the warning.

It already lookups up config_lib.BuildConfig to see if they are production configs (for master, we can't for branched configs).

One you have a config_lib.BuildConfig object, you can test for hwtests with:

if build_config.hwtests and now options.hwtests:
  # Issue warning.

You can run the unitests with:

chromite/cli/cros/cros_tryjob_unittest

Hi, this bug has not been updated recently and remains untriaged. Please acknowledge the bug and provide status within two weeks (6/8/2018), or the bug will be closed. Thank you.