New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 785934 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Content scale in VR content is wrong

Project Member Reported by vollick@chromium.org, Nov 16 2017

Issue description

As of https://chromium-review.googlesource.com/c/chromium/src/+/720019, the VR browser displays content at the incorrect scale making it both hard to read and use (the click targets no longer line up with the content).

This may just be exposing a bug in the VR browsing code, but nevertheless, content is currently unusable.
 

Comment 1 by tiborg@chromium.org, Nov 16 2017

Owner: tiborg@chromium.org
Status: Started (was: Assigned)
Taking it.
Cc: billorr@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3318b07d0027f2ea0a42ca7c53c91a79b8d4a868

commit 3318b07d0027f2ea0a42ca7c53c91a79b8d4a868
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Mon Nov 20 23:09:43 2017

[vr] Compositor listens to display DPR changes and updates accordingly

VR changes the content DPR based on the content quad's projected size.
Make the compositor apply those changes properly. Also, defer commits
to the compositor until the desired content resolution and DPR is known.

Bug:  785934 
Change-Id: I81b74669567dd74a505d2672055672b78b31b725
Reviewed-on: https://chromium-review.googlesource.com/776619
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517975}
[modify] https://crrev.com/3318b07d0027f2ea0a42ca7c53c91a79b8d4a868/chrome/browser/android/vr_shell/vr_compositor.cc
[modify] https://crrev.com/3318b07d0027f2ea0a42ca7c53c91a79b8d4a868/chrome/browser/android/vr_shell/vr_compositor.h
[modify] https://crrev.com/3318b07d0027f2ea0a42ca7c53c91a79b8d4a868/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/3318b07d0027f2ea0a42ca7c53c91a79b8d4a868/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/3318b07d0027f2ea0a42ca7c53c91a79b8d4a868/content/browser/renderer_host/compositor_impl_android.h
[modify] https://crrev.com/3318b07d0027f2ea0a42ca7c53c91a79b8d4a868/content/public/browser/android/compositor.h

Comment 4 by tiborg@chromium.org, Nov 20 2017

Status: Fixed (was: Started)

Sign in to add a comment