Skia roll caused many failures on Mac bots |
||||||
Issue descriptionSkia roll r517013 made many mac bots to fail on the following tests: * virtual/gpu-rasterization/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html * virtual/gpu/fast/canvas/canvas-composite-video-shadow.html * virtual/gpu/fast/canvas/canvas-composite-video.html Examples: https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/20401 https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/7373 Bots started to go green after I reverted the roll.
,
Nov 16 2017
Not clear to me what skia CL caused the problem, so assigning to Skia sheriff for further triage. Note that I stopped Skia rolls into Chrome. Please resume the rolls once the problem has been fixed.
,
Nov 16 2017
Two most likely CLs have been reverted, and roll has been resumed.
,
Nov 16 2017
,
Nov 16 2017
,
Nov 16 2017
Do we know for sure that only Mac Bots will need rebaselining? Or is it possible that there were other failures that we haven't seen yet?
,
Nov 16 2017
It would be safer to assume everything needs rebaselining. Another way to handle https://chromium-review.googlesource.com/c/chromium/src/+/774690 would be to comment out the existing/clashing suppressions, and add yours without a platform filter. Then, after the roll, undo that change + rebaseline. But since we're going to follow up with a rebaseline immediately after the roll, I don't think it's super important to cover everything - so I'm fine with landing as-is.
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63fb985082428d44bf55f0e006811980f402e906 commit 63fb985082428d44bf55f0e006811980f402e906 Author: Chris Dalton <csmartdalton@chromium.org> Date: Thu Nov 16 18:57:27 2017 Add layout test suppressions for upcoming Skia roll Bug: 785931 Change-Id: Id9a97a37985a9888efe2633d688a0818536b2d66 Reviewed-on: https://chromium-review.googlesource.com/774690 Commit-Queue: Chris Dalton <csmartdalton@chromium.org> Reviewed-by: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#517138} [modify] https://crrev.com/63fb985082428d44bf55f0e006811980f402e906/third_party/WebKit/LayoutTests/TestExpectations
,
Feb 26 2018
There are still NeedsManualRebaseline layout test expectations marked with "Awaiting rebaseline after skia roll." referring to this bug. I guess it's time to fix that?
,
Mar 13 2018
Ping. Still causing noise.
,
Mar 20 2018
Ping. I was just about to file a new bug about this. Can we please rebaseline?
,
Mar 20 2018
Thanks for the reminder.
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/441bf3048675a29621e7f1e13a39dd1244a717f4 commit 441bf3048675a29621e7f1e13a39dd1244a717f4 Author: Florin Malita <fmalita@chromium.org> Date: Wed Mar 21 14:40:37 2018 Rebaseline Skia suppressions virtual/gpu-rasterization/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html virtual/gpu/fast/canvas/canvas-composite-video-shadow.html virtual/gpu/fast/canvas/canvas-composite-video.html BUG= 785931 TBR= Change-Id: I57a89b21d76cf69b1608b7cac79fc785a5e0b0de Reviewed-on: https://chromium-review.googlesource.com/971834 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#544690} [modify] https://crrev.com/441bf3048675a29621e7f1e13a39dd1244a717f4/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/441bf3048675a29621e7f1e13a39dd1244a717f4/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png [modify] https://crrev.com/441bf3048675a29621e7f1e13a39dd1244a717f4/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu-rasterization/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt [rename] https://crrev.com/441bf3048675a29621e7f1e13a39dd1244a717f4/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-composite-video-shadow-expected.png [modify] https://crrev.com/441bf3048675a29621e7f1e13a39dd1244a717f4/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu-rasterization/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png [modify] https://crrev.com/441bf3048675a29621e7f1e13a39dd1244a717f4/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-composite-video-expected.png [modify] https://crrev.com/441bf3048675a29621e7f1e13a39dd1244a717f4/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-composite-video-shadow-expected.png [modify] https://crrev.com/441bf3048675a29621e7f1e13a39dd1244a717f4/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-composite-video-expected.png [add] https://crrev.com/441bf3048675a29621e7f1e13a39dd1244a717f4/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-composite-video-shadow-expected.png
,
Apr 12 2018
Is this fixed now?
,
Apr 13 2018
Looks like it. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by guidou@chromium.org
, Nov 16 2017Components: Internals>Skia