New issue
Advanced search Search tips

Issue 785925 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Remove /ios/clean/

Project Member Reported by marq@chromium.org, Nov 16 2017

Issue description

The iOS "clean skeleton" project is not moving forward, so the code should be deleted.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71fadc89028fa77f71391e64361ea6c37372f53c

commit 71fadc89028fa77f71391e64361ea6c37372f53c
Author: Mark Cogan <marq@google.com>
Date: Thu Nov 16 18:35:41 2017

[iOS showcase] Remove dependencies on clean/ from showcase.

This CL removes clean/ view controllers from Showcase.

Bug:  785925 ,  710662 ,  772186 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iebce9f69b7776aa2755e46ec379d7245075a55a7
Reviewed-on: https://chromium-review.googlesource.com/774465
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517135}
[modify] https://crrev.com/71fadc89028fa77f71391e64361ea6c37372f53c/ios/showcase/BUILD.gn
[modify] https://crrev.com/71fadc89028fa77f71391e64361ea6c37372f53c/ios/showcase/DEPS
[modify] https://crrev.com/71fadc89028fa77f71391e64361ea6c37372f53c/ios/showcase/core/showcase_model.mm
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/ntp/BUILD.gn
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/ntp/sc_ntp_coordinator.h
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/ntp/sc_ntp_coordinator.mm
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/root/BUILD.gn
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/root/sc_root_coordinator.h
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/root/sc_root_coordinator.mm
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/root/sc_root_egtest.mm
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tab/BUILD.gn
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tab/sc_bottom_toolbar_tab_coordinator.h
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tab/sc_bottom_toolbar_tab_coordinator.mm
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tab/sc_tab_egtest.mm
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tab/sc_top_toolbar_tab_coordinator.h
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tab/sc_top_toolbar_tab_coordinator.mm
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tab_grid/BUILD.gn
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tab_grid/sc_tab_grid_coordinator.h
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tab_grid/sc_tab_grid_coordinator.mm
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tab_grid/sc_tab_grid_egtest.mm
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/toolbar/BUILD.gn
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/toolbar/sc_toolbar_coordinator.h
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/toolbar/sc_toolbar_coordinator.mm
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/toolbar/sc_toolbar_egtest.mm
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tools_menu/BUILD.gn
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tools_menu/sc_tools_coordinator.h
[delete] https://crrev.com/4935983c64668fb4a3d0e1eb8a4fcc4d3933113f/ios/showcase/tools_menu/sc_tools_coordinator.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fe47fc4c4c6fdc005843967c9e03c93706e4af7

commit 1fe47fc4c4c6fdc005843967c9e03c93706e4af7
Author: Mark Cogan <marq@google.com>
Date: Fri Nov 17 11:29:55 2017

[iOS clean] Delete /ios/clean/

Deletes /ios/clean/ and references to it.

Bug:  785925 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icbdd3a54657ebb3f54b3fb05b830bb803d46acb8
Reviewed-on: https://chromium-review.googlesource.com/774740
Reviewed-by: Louis Romero <lpromero@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517380}
[modify] https://crrev.com/1fe47fc4c4c6fdc005843967c9e03c93706e4af7/ios/BUILD.gn
[modify] https://crrev.com/1fe47fc4c4c6fdc005843967c9e03c93706e4af7/ios/chrome/browser/browser_state/BUILD.gn
[modify] https://crrev.com/1fe47fc4c4c6fdc005843967c9e03c93706e4af7/ios/chrome/browser/browser_state/browser_state_keyed_service_factories.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/DEPS
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/OWNERS
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/README.md
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/DEPS
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/BUILD.gn
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/DEPS
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/app_delegate.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/app_delegate.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/application_phase.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/application_state.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/application_state.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/main.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/resources/Chrome.entitlements
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/BUILD.gn
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/application_step.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/breakpad_initializer.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/breakpad_initializer.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/browser_state_setter.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/browser_state_setter.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/bundle_and_defaults_configurator.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/bundle_and_defaults_configurator.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/chrome_main.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/chrome_main.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/foregrounder.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/foregrounder.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/phased_step_runner.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/phased_step_runner.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/phased_step_runner_unittest.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/provider_initializer.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/provider_initializer.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/root_coordinator_initializer.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/root_coordinator_initializer.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/scheduled_tasks.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/scheduled_tasks.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/simple_application_step.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/simple_application_step.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/step_collections.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/step_collections.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/step_context.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/step_features.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/step_features.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/ui_initializer.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/app/steps/ui_initializer.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/BUILD.gn
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/DEPS
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/DEPS
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/actions/BUILD.gn
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/actions/README.md
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/actions/tab_grid_actions.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/actions/tab_strip_actions.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/adaptor/BUILD.gn
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/adaptor/application_commands_adaptor.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/adaptor/application_commands_adaptor.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/adaptor/browser_commands_adaptor.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/adaptor/browser_commands_adaptor.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/adaptor/url_loader_adaptor.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/adaptor/url_loader_adaptor.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/bookmarks/BUILD.gn
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/bookmarks/bookmarks_coordinator.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/bookmarks/bookmarks_coordinator.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/bookmarks/bookmarks_coordinator_unittest.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/commands/BUILD.gn
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/commands/context_menu_commands.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/commands/dialog_commands.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/commands/find_in_page_search_commands.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/commands/find_in_page_visibility_commands.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/commands/http_auth_dialog_commands.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/commands/java_script_dialog_blocking_commands.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/commands/java_script_dialog_commands.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/commands/navigation_commands.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/commands/ntp_commands.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/commands/settings_commands.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/commands/tab_commands.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/commands/tab_grid_commands.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/commands/tab_grid_toolbar_commands.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/commands/tab_strip_commands.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/commands/tools_menu_commands.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/commands/unavailable_feature_dialog_commands.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/BUILD.gn
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/OWNERS
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/context_menu/BUILD.gn
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/context_menu/context_menu_dialog_coordinator.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/context_menu/context_menu_dialog_coordinator.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/context_menu/context_menu_dialog_mediator.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/context_menu/context_menu_dialog_mediator.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/context_menu/context_menu_dialog_mediator_unittest.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/context_menu/context_menu_dialog_request.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/context_menu/context_menu_request.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/dialog_button_configuration.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/dialog_button_configuration.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/dialog_button_configuration_unittest.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/dialog_button_style.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/dialog_configuration_identifier.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/dialog_configuration_identifier.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/dialog_configuration_identifier_unittest.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/dialog_consumer.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/dialog_coordinator+subclassing.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/dialog_coordinator.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/dialog_coordinator.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/dialog_coordinator_unittest.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/dialog_mediator+subclassing.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/dialog_mediator.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/dialog_mediator.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/dialog_mediator_unittest.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/dialog_text_field_configuration.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/dialog_text_field_configuration.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/dialog_text_field_configuration_unittest.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/dialog_view_controller.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/dialog_view_controller.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/dialog_view_controller_unittest.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/http_auth_dialogs/BUILD.gn
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/http_auth_dialogs/http_auth_dialog_coordinator.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/http_auth_dialogs/http_auth_dialog_coordinator.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/http_auth_dialogs/http_auth_dialog_coordinator_unittest.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/http_auth_dialogs/http_auth_dialog_mediator.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/http_auth_dialogs/http_auth_dialog_mediator.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/http_auth_dialogs/http_auth_dialog_mediator_unittest.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/http_auth_dialogs/http_auth_dialog_request.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/http_auth_dialogs/http_auth_dialog_request.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/http_auth_dialogs/http_auth_dialog_request_unittest.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/java_script_dialogs/BUILD.gn
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/java_script_dialogs/dialog_blocking/BUILD.gn
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/java_script_dialogs/dialog_blocking/java_script_dialog_blocking_confirmation_coordinator.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/java_script_dialogs/dialog_blocking/java_script_dialog_blocking_confirmation_coordinator.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/java_script_dialogs/dialog_blocking/java_script_dialog_blocking_confirmation_mediator.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/java_script_dialogs/dialog_blocking/java_script_dialog_blocking_confirmation_mediator.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/java_script_dialogs/dialog_blocking/java_script_dialog_blocking_confirmation_mediator_unittest.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/java_script_dialogs/java_script_dialog_coordinator.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/java_script_dialogs/java_script_dialog_coordinator.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/java_script_dialogs/java_script_dialog_mediator.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/java_script_dialogs/java_script_dialog_mediator.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/java_script_dialogs/java_script_dialog_mediator_unittest.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/java_script_dialogs/java_script_dialog_overlay_presenter.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/java_script_dialogs/java_script_dialog_overlay_presenter.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/java_script_dialogs/java_script_dialog_request.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/java_script_dialogs/java_script_dialog_request.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/test_helpers/BUILD.gn
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/test_helpers/dialog_test_util.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/test_helpers/dialog_test_util.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/test_helpers/test_dialog_mediator.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/test_helpers/test_dialog_mediator.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/test_helpers/test_dialog_view_controller.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/test_helpers/test_dialog_view_controller.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/unavailable_feature_dialogs/BUILD.gn
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/unavailable_feature_dialogs/unavailable_feature_dialog_coordinator.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/unavailable_feature_dialogs/unavailable_feature_dialog_coordinator.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/unavailable_feature_dialogs/unavailable_feature_dialog_mediator.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/unavailable_feature_dialogs/unavailable_feature_dialog_mediator.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/dialogs/unavailable_feature_dialogs/unavailable_feature_dialog_mediator_unittest.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/find_in_page/BUILD.gn
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/find_in_page/find_in_page_consumer.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/find_in_page/find_in_page_coordinator.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/find_in_page/find_in_page_coordinator.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/find_in_page/find_in_page_mediator.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/find_in_page/find_in_page_mediator.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/find_in_page/find_in_page_mediator_unittest.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/find_in_page/find_in_page_view_controller.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/find_in_page/find_in_page_view_controller.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/history_popup/BUILD.gn
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/history_popup/OWNERS
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/history_popup/history_popup_coordinator.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/history_popup/history_popup_coordinator.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/history_popup/history_popup_coordinator_unittest.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/ntp/BUILD.gn
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/ntp/ntp_consumer.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/ntp/ntp_coordinator.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/ntp/ntp_coordinator.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/ntp/ntp_coordinator_unittest.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/ntp/ntp_home_coordinator.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/ntp/ntp_home_coordinator.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/ntp/ntp_home_coordinator_unittest.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/ntp/ntp_home_header_coordinator.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/ntp/ntp_home_header_coordinator.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/ntp/ntp_home_header_coordinator_unittest.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.h
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2ebb4ec13fe437a5c75e7c9/ios/clean/chrome/browser/ui/ntp/ntp_home_header_view_controller_unittest.mm
[delete] https://crrev.com/bdfa2db95bf15d76d2e
Components: Internals

Comment 4 by marq@chromium.org, Nov 20 2017

Status: Fixed (was: Assigned)

Sign in to add a comment