Tapping on cancel button in passcode will not display ‘can’t verify your identity’ toast message |
|||
Issue descriptionApp Version: 63.0.3239.54 Beta iOS Version: 10.3.3, 11.1 Device: iPhone and iPad Precondition: 1. Login in to chrome with the accounts having saved passwords data or save a password 2. Turn on device passcode Steps to reproduce: 1. Launch chrome 2. Go to settings--Save passwords 3. Select any password 4. Tap on password Show button 5. Tap cancel button on the passcode screen Observed results: Notice the toast message is not displayed Note: The toast message displays on following above steps with password copy button Expected results: A valid toast message should be displayed Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes/No Bug reproducible after clearing cache and cookies: Yes/No Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): Yes on M62 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M63 beta Link to video/image: https://drive.google.com/a/google.com/file/d/1kZOG5eVAqaV20A2H3P_srBEEtloGQBBG/view?usp=sharing
,
Nov 17 2017
,
Nov 17 2017
This is actually supposed to work this way. For copying the user does not see immediately whether the copy happened, so there is a message to explain that it did not happen. For showing the password, on the other hand, the result is obvious: the password was not shown. The user already knows that the authentication failed from the iOS UI, so there is nothing more to report, and hence no message. I might add a test to ensure that we don't "fix" this later by accident, but will mark this as WAI in the mean time.
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e20f365865fb54d687ebe38d1096dbfb50d8620 commit 2e20f365865fb54d687ebe38d1096dbfb50d8620 Author: Vaclav Brozek <vabr@chromium.org> Date: Fri Nov 17 16:11:56 2017 More tests for Show-password button on iOS The linked bug contains a confusion about the intended messaging in case when the user taps the Show button in Chrome password settings on iOS and fails to authenticate. This CL adds two tests, one for a successful and one for a failed authentication, documenting the expected outcomes to prevent changing behaviour in the feature by accident. Bug: 785923 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If9c84c0ebe076f827b4c1b2611c0b77e8a779a44 Reviewed-on: https://chromium-review.googlesource.com/776784 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#517415} [modify] https://crrev.com/2e20f365865fb54d687ebe38d1096dbfb50d8620/ios/chrome/browser/ui/settings/passwords_settings_egtest.mm |
|||
►
Sign in to add a comment |
|||
Comment 1 by kkhorimoto@chromium.org
, Nov 16 2017Owner: vasi...@chromium.org
Status: Assigned (was: Untriaged)