New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 785804 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

DCHECK failure in !IsSmi() == Internals::HasHeapObjectTag(this) in objects.h

Project Member Reported by ClusterFuzz, Nov 16 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5882233008422912

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  !IsSmi() == Internals::HasHeapObjectTag(this) in objects.h
  IsHeapObject
  v8::internal::Object::VerifyPointer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=48861:48862

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5882233008422912

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 16 2017

Labels: Test-Predator-Auto-Owner
Owner: danno@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/b590679496e829fd2f88ba4494072f0196c979de (Activate CSA implementation of Array.prototype.slice).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 16 2017

Labels: Pri-1

Comment 3 by mmoroz@chromium.org, Nov 16 2017

Labels: Security_Impact-Head M-64

Comment 4 by danno@chromium.org, Nov 17 2017

Status: Started (was: Assigned)
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 17 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by danno@chromium.org, Nov 17 2017

Cc: danno@chromium.org bmeu...@chromium.org
 Issue 782073  has been merged into this issue.

Comment 7 by danno@chromium.org, Nov 17 2017

 Issue 786084  has been merged into this issue.

Comment 9 by danno@chromium.org, Nov 19 2017

 Issue 786517  has been merged into this issue.

Comment 10 by danno@chromium.org, Nov 19 2017

 Issue 786675  has been merged into this issue.

Comment 11 by danno@chromium.org, Nov 19 2017

 Issue 786753  has been merged into this issue.
Project Member

Comment 12 by ClusterFuzz, Nov 19 2017

Components: Blink>JavaScript>GC
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f0ceb9f2774519299712392e76ab3606c294c17d

commit f0ceb9f2774519299712392e76ab3606c294c17d
Author: Daniel Clifford <danno@chromium.org>
Date: Mon Nov 20 11:53:13 2017

Fix bug in length handling of Array.prototype.slice fast-path

Bug:  chromium:785804 
Change-Id: I1a65e2007438ac009d961e0e2c0425212216fcf1
Reviewed-on: https://chromium-review.googlesource.com/776696
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Daniel Clifford <danno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49481}
[modify] https://crrev.com/f0ceb9f2774519299712392e76ab3606c294c17d/src/builtins/builtins-array-gen.cc
[add] https://crrev.com/f0ceb9f2774519299712392e76ab3606c294c17d/test/mjsunit/regress/regress-785804.js

Project Member

Comment 14 by ClusterFuzz, Nov 20 2017

ClusterFuzz has detected this issue as fixed in range 49480:49481.

Detailed report: https://clusterfuzz.com/testcase?key=5882233008422912

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  !IsSmi() == Internals::HasHeapObjectTag(this) in objects.h
  IsHeapObject
  v8::internal::Object::VerifyPointer
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=48861:48862
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=49480:49481

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5882233008422912

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 15 by ClusterFuzz, Nov 20 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5882233008422912 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 16 by sheriffbot@chromium.org, Nov 20 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify

Comment 17 by danno@chromium.org, Nov 20 2017

 Issue 786791  has been merged into this issue.
 Issue 786890  has been merged into this issue.
Project Member

Comment 19 by sheriffbot@chromium.org, Feb 26 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 20 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head -M-64 M-65 Security_Impact-Stable
Labels: -ReleaseBlock-Stable

Sign in to add a comment