Regression: Focus navigation issue is seen on 'Saves password details' overlay.
Reported by
dchau...@etouch.net,
Nov 16 2017
|
|||||
Issue descriptionChrome Version: 64.0.3269.3 (Official Build) (64-bit)1d74d56f7fb838be3c05549bc5e11cdf665f1990-refs/branch-heads/3269@{#3} 32/64-bit. OS: Windows(7,8,10), Mac(10.12.6,10.13.2), Linux(14.1 LTS). What steps will reproduce the problem? 1. Launch Chrome, login to www.gmail.com with valid credentials and save the password. 2. Navigate to chrome://settings/passwords and select 'Details' option from more actions menu list. 3. Press 'Tab' key (focus will appear on close button) and then again press 'Tab' key, observe the focus. Focus doesn't navigate to Eye icon. Focus should seen on Eye icon. Note: Focus seen on eye icon after pressing 4 times 'Tab' key. This is a regression issue, broken in M-59 series, below is manual regression range. Good build: 59.0.3057.0 Bad build: 59.0.3059.0 You are probably looking for a change made after 461251 (known good), but no later than 461252 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/3ab41658a0ddbe293b5cc9b6e76ec97b2a881d63..101df2078bd35882ebd8e52d3b0fb7a0b6bf6ea8 Suspect: https://chromium.googlesource.com/chromium/src/+/101df2078bd35882ebd8e52d3b0fb7a0b6bf6ea8 @scottchen: Kindly help to reassign, if your changes are not related to this issue. Kindly review the attached screen-cast for reference.
,
Dec 1 2017
Assigning back to scottchen@ since regression is caused by making fields read only. Eye icon is focusable, but when pressing tab, focus first travels to the disabled elements which aren't visually focused. Thus, the eye icon can be focused after tabbing over the disabled fields. There's code that selects the text in the field when focused, but doesn't seem to work when tabbing the first time. Maybe fix is to select text also on tab to indicate focus?
,
Jan 2 2018
,
Jan 2 2018
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e17fd7199e57c383c2a1fdbf4b26826fb0de546b commit e17fd7199e57c383c2a1fdbf4b26826fb0de546b Author: Scott Chen <scottchen@chromium.org> Date: Thu Jan 11 20:55:01 2018 MD Settings: fix password dialog focus issue. Previously when moving the focus through the dialog, its not clear when the focus is on the inputs. This CL gives focusing the same behavior as tapping, which automatically select all of the text content. Bug: 785785 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie11fdc49950d99c22be616ef90521e9faca99975 Reviewed-on: https://chromium-review.googlesource.com/848026 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#528749} [modify] https://crrev.com/e17fd7199e57c383c2a1fdbf4b26826fb0de546b/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html [modify] https://crrev.com/e17fd7199e57c383c2a1fdbf4b26826fb0de546b/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js
,
Jan 12 2018
Update : Verified this issue on Windows(7,8,10), Mac(10.12.6,10.13.1), Linux(14.04 LTS) OS with latest Canary build #65.0.3319.0 and the issue is no longer reproducible. The fix is working as intended. Kindly review an attached screen-cast. Thank you!
,
Jan 12 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by scottchen@chromium.org
, Dec 1 2017Owner: hcarmona@chromium.org