New issue
Advanced search Search tips

Issue 785764 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Dec 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Password Generation] Presave non-empty username when possible

Project Member Reported by kolos@chromium.org, Nov 16 2017

Issue description

At this point, we presave a generated password with empty username. 

We should save with the captured on the form username if it doesn't override any credential. Otherwise, presave with empty username. It may cause override as well, but it is acceptable. 

Username clearing
https://cs.chromium.org/chromium/src/components/autofill/content/renderer/password_generation_agent.cc?rcl=761e67a03549d289401b4a98409d2d8391a66dbb&l=381

https://cs.chromium.org/chromium/src/components/password_manager/core/browser/form_saver_impl.cc?rcl=af4be98f805ccd698af7faaad1bd948c78dc3a14&l=115 there is a bug. The code doesn't consider the case when password was generated and it is not a new login. Please check/add tests for that. 
 

Comment 1 by kolos@chromium.org, Nov 30 2017

Please also add metrics to check whether overriding is a serious problem or not.

Comment 2 by kolos@chromium.org, Dec 5 2017

 Issue 777754  has been merged into this issue.
Owner: ----
Status: Available (was: Assigned)
Status: WontFix (was: Available)
It's already implemented on another bug.

Sign in to add a comment