Issue metadata
Sign in to add a comment
|
Heap-use-after-free in media::FrameBufferPool::OnVideoFrameDestroyed |
||||||||||||||||||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=6235769147752448 Fuzzer: libFuzzer_mediasource_WEBM_OPUS_VP9_pipeline_integration_fuzzer Job Type: mac_libfuzzer_chrome_asan Platform Id: mac Crash Type: Heap-use-after-free READ 4 Crash Address: 0x60600001e654 Crash State: media::FrameBufferPool::OnVideoFrameDestroyed void base::internal::FunctorTraits<void base::OnceCallback<void Sanitizer: address (ASAN) Recommended Security Severity: High Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=516325:516519 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6235769147752448 Issue filed automatically. See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
,
Nov 16 2017
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it. If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 16 2017
,
Nov 16 2017
https://chromium.googlesource.com/chromium/src/+/2ccebeef9a1660bbee810c3af6b19ec4f574e968 is the suspected CL
,
Nov 16 2017
Doh, will verify it's fixed by https://chromium-review.googlesource.com/c/chromium/src/+/773040 which moves everything to the offload thread.
,
Nov 16 2017
Verified it's fixed by that change. Will try to land that today.
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c8842633b9ea324ecd3951c2620a67fa998272db commit c8842633b9ea324ecd3951c2620a67fa998272db Author: Dale Curtis <dalecurtis@chromium.org> Date: Fri Nov 17 03:40:13 2017 Introduce OffloadingVideoDecoder wrapper. Used to run a OffloadableVideoDecoder on a different thread than the media thread. Offload conditions are configurable. OffloadableVideoDecoder implementations are just normal VideoDecoders with a new Detach() method that removes them from the thread they were running on. This replaces the offload task runner that was previously held within VpxVideoDecoder with a new class OffloadingVpxVideoDecoder and a helper variable on the constructor to VpxVideoDecoder. The helper variable ensures tasks are returned to the correct thread without unnecessary hops. BUG= 783519 , 785760 , 786059 TEST=new unittests, all existing tests pass Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib76dd9c2778fef3c39455ca3b4de6ecb12dea953 Reviewed-on: https://chromium-review.googlesource.com/773040 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#517284} [modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/base/test_helpers.cc [modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/base/test_helpers.h [modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/filters/BUILD.gn [add] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/filters/offloading_video_decoder.cc [add] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/filters/offloading_video_decoder.h [add] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/filters/offloading_video_decoder_unittest.cc [modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/filters/vpx_video_decoder.cc [modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/filters/vpx_video_decoder.h [modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/filters/vpx_video_decoder_unittest.cc [modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/renderers/default_renderer_factory.cc [modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/test/pipeline_integration_test_base.cc
,
Nov 17 2017
,
Nov 18 2017
,
Nov 27 2017
Automatically applying components based on crash stacktrace and information from OWNERS files. If this is incorrect, please apply the Test-Predator-Wrong-Components label.
,
Nov 27 2017
ClusterFuzz testcase 6235769147752448 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
Feb 24 2018
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 27 2018
,
Mar 31 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sheriffbot@chromium.org
, Nov 16 2017