New issue
Advanced search Search tips

Issue 785760 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in media::FrameBufferPool::OnVideoFrameDestroyed

Project Member Reported by ClusterFuzz, Nov 16 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6235769147752448

Fuzzer: libFuzzer_mediasource_WEBM_OPUS_VP9_pipeline_integration_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Heap-use-after-free READ 4
Crash Address: 0x60600001e654
Crash State:
  media::FrameBufferPool::OnVideoFrameDestroyed
  void base::internal::FunctorTraits<void
  base::OnceCallback<void
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=516325:516519

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6235769147752448

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Nov 16 2017

Labels: M-64
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 16 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 16 2017

Labels: Pri-1

Comment 4 by mmoroz@chromium.org, Nov 16 2017

Cc: dalecur...@chromium.org
Components: Blink>Media>Video
Owner: dalecur...@chromium.org
Status: Assigned (was: Untriaged)
https://chromium.googlesource.com/chromium/src/+/2ccebeef9a1660bbee810c3af6b19ec4f574e968 is the suspected CL
Cc: -dalecur...@chromium.org tguilbert@chromium.org
Doh, will verify it's fixed by https://chromium-review.googlesource.com/c/chromium/src/+/773040 which moves everything to the offload thread.
Verified it's fixed by that change. Will try to land that today.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8842633b9ea324ecd3951c2620a67fa998272db

commit c8842633b9ea324ecd3951c2620a67fa998272db
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Fri Nov 17 03:40:13 2017

Introduce OffloadingVideoDecoder wrapper.

Used to run a OffloadableVideoDecoder on a different thread
than the media thread. Offload conditions are configurable.

OffloadableVideoDecoder implementations are just normal
VideoDecoders with a new Detach() method that removes them
from the thread they were running on.

This replaces the offload task runner that was previously held
within VpxVideoDecoder with a new class OffloadingVpxVideoDecoder
and a helper variable on the constructor to VpxVideoDecoder. The
helper variable ensures tasks are returned to the correct thread
without unnecessary hops.

BUG= 783519 ,  785760 , 786059
TEST=new unittests, all existing tests pass

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib76dd9c2778fef3c39455ca3b4de6ecb12dea953
Reviewed-on: https://chromium-review.googlesource.com/773040
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517284}
[modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/base/test_helpers.cc
[modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/base/test_helpers.h
[modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/filters/BUILD.gn
[add] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/filters/offloading_video_decoder.cc
[add] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/filters/offloading_video_decoder.h
[add] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/filters/offloading_video_decoder_unittest.cc
[modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/filters/vpx_video_decoder.cc
[modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/filters/vpx_video_decoder.h
[modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/filters/vpx_video_decoder_unittest.cc
[modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/renderers/default_renderer_factory.cc
[modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/test/pipeline_integration_test_base.cc

Status: Fixed (was: Assigned)
Project Member

Comment 9 by sheriffbot@chromium.org, Nov 18 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 10 by ClusterFuzz, Nov 27 2017

Components: Internals>Core Internals>TaskScheduler
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 11 by ClusterFuzz, Nov 27 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6235769147752448 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 12 by sheriffbot@chromium.org, Feb 24 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head -M-64 M-65 Security_Impact-Stable
Labels: -ReleaseBlock-Stable

Sign in to add a comment