New issue
Advanced search Search tips

Issue 785754 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

vaapi_video_decode_accelerator: deprecation warning with libva 2.0

Project Member Reported by acourbot@chromium.org, Nov 16 2017

Issue description

The following warnings are emitted when compiling against libva 2.0:

[29989/40999] CXX obj/media/gpu/gpu/vaapi_video_decode_accelerator.o
../../media/gpu/vaapi_video_decode_accelerator.cc:1227:18: warning: 'num_slice_groups_minus1' is deprecated [-Wdeprecated-declarations]
  FROM_PPS_TO_PP(num_slice_groups_minus1);
                 ^
../../../../../../build/eve-kvm/usr/include/va/va.h:2168:5: note: 'num_slice_groups_minus1' has been explicitly marked deprecated here
    va_deprecated uint8_t num_slice_groups_minus1;
    ^
../../../../../../build/eve-kvm/usr/include/va/va.h:90:38: note: expanded from macro 'va_deprecated'
#define va_deprecated __attribute__((deprecated))
                                     ^
../../media/gpu/vaapi_video_decode_accelerator.cc:1228:13: warning: 'slice_group_map_type' is deprecated [-Wdeprecated-declarations]
  pic_param.slice_group_map_type = 0;
            ^
../../../../../../build/eve-kvm/usr/include/va/va.h:2169:5: note: 'slice_group_map_type' has been explicitly marked deprecated here
    va_deprecated uint8_t slice_group_map_type;
    ^
../../../../../../build/eve-kvm/usr/include/va/va.h:90:38: note: expanded from macro 'va_deprecated'
#define va_deprecated __attribute__((deprecated))
                                     ^
../../media/gpu/vaapi_video_decode_accelerator.cc:1229:13: warning: 'slice_group_change_rate_minus1' is deprecated [-Wdeprecated-declarations]
  pic_param.slice_group_change_rate_minus1 = 0;
            ^
../../../../../../build/eve-kvm/usr/include/va/va.h:2170:5: note: 'slice_group_change_rate_minus1' has been explicitly marked deprecated here
    va_deprecated uint16_t slice_group_change_rate_minus1;
    ^
../../../../../../build/eve-kvm/usr/include/va/va.h:90:38: note: expanded from macro 'va_deprecated'
#define va_deprecated __attribute__((deprecated))

Compilation completes and the resulting binaries are working fine, but we will want to fix these nonetheless.

Careful though, if these fields have been replaced by newer ones as we want to keep allowing compilation with 1.8.3 for testing reasons (compiled binaries would never run, we only need to maintain the ability to compile). New fields should be controlled using compile-time version check.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0da36bb28408a46e074c0178fae7a4a85e289d89

commit 0da36bb28408a46e074c0178fae7a4a85e289d89
Author: Alexandre Courbot <acourbot@chromium.org>
Date: Fri Nov 17 04:47:48 2017

vaapi_video_decode_accelerator: stop using deprecated fields

These 3 fields are needed for FMO, which libva did not and will never
implement. As a result libva 2.0.0 has deprecated these fields. Stop
using them to avoid compiler warnings are we upgrade to it.

BUG= chromium:785754 
TEST=made sure h264 HW decoding was still working after this CL.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I69310b37a50e7ceb74b347f0b727e01102d46df0
Reviewed-on: https://chromium-review.googlesource.com/774340
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517303}
[modify] https://crrev.com/0da36bb28408a46e074c0178fae7a4a85e289d89/media/gpu/vaapi_video_decode_accelerator.cc

Status: Fixed (was: Assigned)
Closing as fix got merged.

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 4 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment