Issue metadata
Sign in to add a comment
|
Regression : ‘Mute Tab’ option under Mac mainMenu >> Window does not work.
Reported by
avsha...@etouch.net,
Nov 16 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version : 64.0.3269.3 (Official Build) 1d74d56f7fb838be3c05549bc5e11cdf665f1990-refs/branch-heads/3269@{#3} 64-bit OS : Mac(10.12.6), (10.13.2) What steps will reproduce the problem? 1. Launch chrome and open NTP. 2. From Mac mainMenu, open ‘Window’ menu and click on ‘Mute Tab’ option. 3. Observe. Actual Result : ‘Mute Tab’ option under Mac mainMenu >> Window does not work. Expected Result : ‘Mute Tab’ option should work or it should be disabled since ‘Mute Site’ option is seen disabled in tab’s context menu. This is a regression issue broken in ‘M-64’ and using the per-revision bisect providing the bisect results, Good build : 64.0.3243.0 (Revision : 509637) Bad build : 64.0.3244.0 (Revision : 509944) You are probably looking for a change made after 509775 (known good), but no later than 509776 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/e7fa637d7ac2f35b26ffc6c1d0b5cf443d6c787c..4bee58d8cc08debda0ea2d40a9d41a09b6f165a9 Suspect : https://chromium.googlesource.com/chromium/src/+/4bee58d8cc08debda0ea2d40a9d41a09b6f165a9 @steimel : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Note : Issue is not reproducible on Windows(7,8,10) & Linux(14.04 LTS)
,
Nov 17 2017
,
Nov 17 2017
Probably not a RBS but it should be a quick fix anyway :)
,
Nov 27 2017
Friendly ping for an update on this.
,
Nov 27 2017
The way we were doing this in the tab dropdown was to disable the "Mute site" option, and we were going to update this to do the same, but now some issues have come up and we've decided to change it to be enabled and mute the tab, so once those changes come in (should happen today or tomorrow), this will be fixed.
,
Nov 29 2017
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37112950bc5ed3dbd06fdf42c0367ff246939287 commit 37112950bc5ed3dbd06fdf42c0367ff246939287 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Nov 29 19:41:45 2017 Add ability to mute chrome:// pages Bug: 787743 , 785711 , 782134 Change-Id: I77fe9a7192697ebe82734231ae709c2094b57b62 Reviewed-on: https://chromium-review.googlesource.com/791813 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#520203} [modify] https://crrev.com/37112950bc5ed3dbd06fdf42c0367ff246939287/chrome/browser/content_settings/sound_content_setting_observer.cc [modify] https://crrev.com/37112950bc5ed3dbd06fdf42c0367ff246939287/chrome/browser/content_settings/sound_content_setting_observer_unittest.cc [modify] https://crrev.com/37112950bc5ed3dbd06fdf42c0367ff246939287/chrome/browser/extensions/extension_tab_util.cc [modify] https://crrev.com/37112950bc5ed3dbd06fdf42c0367ff246939287/chrome/browser/ui/tabs/tab_utils.cc [modify] https://crrev.com/37112950bc5ed3dbd06fdf42c0367ff246939287/chrome/browser/ui/tabs/tab_utils.h
,
Nov 29 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Nov 16 2017