Issue metadata
Sign in to add a comment
|
virtual/.../shadowdom-for-button.html in webkit_layout_tests failing on multiple builders |
||||||||||||||||||
Issue descriptionvirtual/.../shadowdom-for-button.html in webkit_layout_tests failing on multiple builders Builders failed on: - Mac10.10 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests - WebKit Mac10.10: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10
,
Nov 16 2017
Ah, let me fix that. It looks the bot didn't catch this fail. :(
,
Nov 16 2017
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f01395ff3538341da0ea9eec0978a15afa26f3e2 commit f01395ff3538341da0ea9eec0978a15afa26f3e2 Author: Hayato Ito <hayato@chromium.org> Date: Thu Nov 16 07:41:48 2017 Add virtual/incremental-shadow-dom/fast/dom/shadow/shadowdom-for-button.html to TestExpectations TBR=horo,kochi Bug: 776656 , 785685 Change-Id: I64e6ff2448de65db4dbb10d81d8f3c8e39a70157 Reviewed-on: https://chromium-review.googlesource.com/773796 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#517017} [modify] https://crrev.com/f01395ff3538341da0ea9eec0978a15afa26f3e2/third_party/WebKit/LayoutTests/TestExpectations
,
Nov 16 2017
,
Nov 17 2017
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b22ea444bd85153593376836ddeba59827236477 commit b22ea444bd85153593376836ddeba59827236477 Author: Hayato Ito <hayato@chromium.org> Date: Tue Nov 21 10:05:03 2017 Remove a failing test, which is no longer necessary This test is testing a removed feature, multiple shadow roots for built-in elements. The entry in TestExpectation was removed in this CL, https://chromium-review.googlesource.com/c/chromium/src/+/778648, however, that was accidentally done. It would be better to remove the test itself, rather than marking it failure. TBR=kochi,tyoshino Bug: 785685 Change-Id: I638d37b9ebc62e43927c439656e53e082c8d73f2 Reviewed-on: https://chromium-review.googlesource.com/781341 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#518200} [modify] https://crrev.com/b22ea444bd85153593376836ddeba59827236477/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG [modify] https://crrev.com/b22ea444bd85153593376836ddeba59827236477/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/f4c312133cc23628484d67ce590320a5aab7ac3c/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-button-expected.html [delete] https://crrev.com/f4c312133cc23628484d67ce590320a5aab7ac3c/third_party/WebKit/LayoutTests/fast/dom/shadow/shadowdom-for-button.html
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ffcfa83b8d0d189043937003b8cd47a130dc9fd commit 6ffcfa83b8d0d189043937003b8cd47a130dc9fd Author: Hayato Ito <hayato@chromium.org> Date: Tue Nov 21 11:16:43 2017 Remove shadowdom-for-button.html entry from TestExpectations There were two attempts to fix bot failures at the same time: - https://chromium-review.googlesource.com/c/chromium/src/+/781341 - https://chromium-review.googlesource.com/c/chromium/src/+/781679 Because both of them were landed, we need to clean up the test expectation line for shadowdom-for-button.html. TBR=kochi,mkwst,tyoshino NOTRY=true Bug: 785685 Change-Id: Ibc3e145ea77d3e1b6ff53f0d82f59fb3ca5d1174 Reviewed-on: https://chromium-review.googlesource.com/781308 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#518211} [modify] https://crrev.com/6ffcfa83b8d0d189043937003b8cd47a130dc9fd/third_party/WebKit/LayoutTests/TestExpectations |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by horo@chromium.org
, Nov 16 2017