New issue
Advanced search Search tips

Issue 785679 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Remove permission persist toggle experiment code

Project Member Reported by timloh@chromium.org, Nov 16 2017

Issue description

We added a persist toggle in  bug 632269  to experiment with. We've finished our experimentation and decided not to proceed with a persist toggle for permission prompts. We should remove the code associated with it, mark histograms obsolete, and so on.
 

Comment 1 by timloh@chromium.org, Nov 17 2017

Owner: timloh@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4caae01a3a9c0e16f205c7f047d695a72f2607c

commit f4caae01a3a9c0e16f205c7f047d695a72f2607c
Author: Timothy Loh <timloh@chromium.org>
Date: Mon Nov 27 05:36:00 2017

Remove peristence toggle experiment for permission prompts

The persistence toggle experiment for permission prompts ran from M56
to M59 and has since concluded. As we don't intend to proceed with
persistence toggles, this CL removes the code for the experiment.

Bug:  785679 
Change-Id: Iac674bc76bc028c13fc60fb9987468b4df5591be
TBR: yusufo@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/776135
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519223}
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/android/java/res/layout/permission_dialog.xml
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogDelegate.java
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/GeolocationTest.java
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/MediaTest.java
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionTestRule.java
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/QuotaTest.java
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/about_flags.cc
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/geolocation/geolocation_browsertest.cc
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/permissions/grouped_permission_infobar_delegate_android.cc
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/permissions/grouped_permission_infobar_delegate_android.h
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/permissions/permission_context_base.cc
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/permissions/permission_context_base.h
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/permissions/permission_context_base_unittest.cc
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/permissions/permission_dialog_delegate.cc
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/permissions/permission_dialog_delegate.h
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/permissions/permission_prompt_android.cc
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/permissions/permission_prompt_android.h
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/permissions/permission_request.cc
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/permissions/permission_request.h
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/permissions/permission_request_impl.cc
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/permissions/permission_request_impl.h
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/permissions/permission_request_manager.cc
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/permissions/permission_request_manager.h
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/permissions/permission_request_manager_browsertest.cc
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/permissions/permission_request_manager_test_api.cc
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/permissions/permission_uma_util.h
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/permissions/permission_util.cc
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/permissions/permission_util.h
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/safe_browsing/permission_reporter.cc
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/safe_browsing/permission_reporter_unittest.cc
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/ui/android/infobars/grouped_permission_infobar.cc
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/ui/android/infobars/grouped_permission_infobar.h
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/ui/android/infobars/permission_infobar.cc
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/ui/android/infobars/permission_infobar.h
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/ui/cocoa/permission_bubble/permission_bubble_controller_unittest.mm
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/ui/permission_bubble/permission_bubble_browser_test_util.h
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/ui/permission_bubble/permission_prompt.h
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.h
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/common/chrome_features.cc
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/common/chrome_features.h
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/chrome/common/safe_browsing/permission_report.proto
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/f4caae01a3a9c0e16f205c7f047d695a72f2607c/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Sign in to add a comment