New issue
Advanced search Search tips

Issue 785675 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 1
Type: Bug-Security



Sign in to add a comment

pobfuzz: cc::DrawTextBlobOp::Deserialize -> use-of-uninitialized-value in int const& SkTMax<int>

Project Member Reported by ClusterFuzz, Nov 16 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6591416934596608

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  int const& SkTMax<int>
  int const& SkTPin<int>
  SkFontStyle::SkFontStyle
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=515053:515085

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6591416934596608

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 

Comment 1 by palmer@chromium.org, Nov 16 2017

Components: Internals>Skia
Labels: M-64 OS-Android OS-Chrome OS-Fuchsia OS-Mac OS-Windows Pri-1
Owner: hcm@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by ClusterFuzz, Nov 16 2017

Components: Internals>Compositing
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 16 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by hcm@chromium.org, Nov 17 2017

Cc: hcm@chromium.org
Components: -Internals>Skia
Owner: vmp...@chromium.org
This one doesn't appear to be Skia but something uninitialized upstack, starting with the suggested blame + component for a look...will stay on cc.

Comment 5 by vmp...@chromium.org, Nov 20 2017

Cc: enne@chromium.org
Labels: -ReleaseBlock-Stable
This code is behind a flag, so should not block release.

Comment 6 by enne@chromium.org, Nov 20 2017

Labels: -M-64
Summary: pobfuzz: cc::DrawTextBlobOp::Deserialize -> use-of-uninitialized-value in int const& SkTMax<int> (was: Use-of-uninitialized-value in int const& SkTMax<int>)

Comment 7 by mmoroz@chromium.org, Nov 20 2017

Labels: M-65
Adding M-65 as per c#5.
Project Member

Comment 8 by sheriffbot@chromium.org, Nov 21 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by hcm@google.com, Nov 21 2017

Labels: -ReleaseBlock-Stable
Project Member

Comment 10 by ClusterFuzz, Nov 22 2017

ClusterFuzz has detected this issue as fixed in range 518493:518517.

Detailed report: https://clusterfuzz.com/testcase?key=6591416934596608

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  int const& SkTMax<int>
  int const& SkTPin<int>
  SkFontStyle::SkFontStyle
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=515053:515085
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=518493:518517

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6591416934596608

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 11 by ClusterFuzz, Nov 22 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6591416934596608 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 12 by sheriffbot@chromium.org, Nov 22 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify

Comment 13 by enne@chromium.org, Nov 22 2017

Labels: -ClusterFuzz-Verified ClusterFuzz-Wrong
Status: Assigned (was: Verified)
This was closed due to changes from https://chromium-review.googlesource.com/770522.  I think this is still a real issue that needs to be fixed, so I'm reopening this.  Please repro from older Chrome versions.
Project Member

Comment 14 by sheriffbot@chromium.org, Nov 23 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 15 by sheriffbot@chromium.org, Dec 5 2017

vmpstr: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -ReleaseBlock-Stable
This is behind a flag, and should not block release.
Project Member

Comment 17 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57a9b3e34bfddc151f8848ccf9fec031f09f5f39

commit 57a9b3e34bfddc151f8848ccf9fec031f09f5f39
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Tue Dec 05 20:20:15 2017

oop: Initialize and validate font creation params.

This patch ensures that we initialize all font creation params before
reading them and abort creating a typeface if the reader is invalid.

R=enne@chromium.org, ericrk@chromium.org

Bug:  785675 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I7baabeb460c9cb06026c8a82989c7c6f7e970f8f
Reviewed-on: https://chromium-review.googlesource.com/808748
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521806}
[modify] https://crrev.com/57a9b3e34bfddc151f8848ccf9fec031f09f5f39/cc/paint/paint_op_reader.cc

Status: Fixed (was: Assigned)
Project Member

Comment 19 by sheriffbot@chromium.org, Mar 14 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 20 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head Security_Impact-Stable

Sign in to add a comment