New issue
Advanced search Search tips

Issue 785662 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

http/.../reveal-not-skipped.js in webkit_layout_tests failing on chromium.win/Win7 Tests (dbg)(1)

Project Member Reported by horo@chromium.org, Nov 16 2017

Issue description

http/.../reveal-not-skipped.js in webkit_layout_tests failing on chromium.win/Win7 Tests (dbg)(1)

Builders failed on: 
- Win7 Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29



 

Comment 1 by horo@chromium.org, Nov 16 2017

Cc: dgozman@chromium.org
Owner: kozyatinskiy@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fd1c198ccb4d9b2394f1ef3023e3d3cfabf868f

commit 4fd1c198ccb4d9b2394f1ef3023e3d3cfabf868f
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Thu Nov 16 04:33:30 2017

Add reveal-not-skipped.js to TestExpectations

BUG= 785662 
TBR=kozyatinskiy@chromium.org

Change-Id: I9b1e1f7c8216b09ee7c321ca255c1a32af7cfcb6
Reviewed-on: https://chromium-review.googlesource.com/773859
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516986}
[modify] https://crrev.com/4fd1c198ccb4d9b2394f1ef3023e3d3cfabf868f/third_party/WebKit/LayoutTests/TestExpectations

Comment 4 by guidou@chromium.org, Nov 17 2017

Labels: -Sheriff-Chromium

Comment 5 by kozy@chromium.org, Nov 30 2017

Owner: kozy@chromium.org

Comment 7 by kozy@chromium.org, Dec 7 2017

Status: Fixed (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14b857f982900cb6e61cb350342f35a46644f54a

commit 14b857f982900cb6e61cb350342f35a46644f54a
Author: Maxim Kolosovskiy <kolos@chromium.org>
Date: Fri Dec 08 11:34:10 2017

Revert "[DevTools] unflake reveal-not-skipped.js"

This reverts commit cb76cd2f2accdd3553d7fd13333c15400533209d.

Reason for revert: 
reveal-not-skipped.js can still fail.

https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/65069
https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/65067
https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/65065

Original change's description:
> [DevTools] unflake reveal-not-skipped.js
> 
> TBR=lushnikov@chromium.org
> 
> Bug:  chromium:785662 
> Change-Id: Ia82b166b3bd5e1f901d74157bcc596e8545b34a0
> Reviewed-on: https://chromium-review.googlesource.com/815374
> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#522563}

TBR=lushnikov@chromium.org,kozyatinskiy@chromium.org

Change-Id: I91d8a917b77191f99d0e0509fe220930620f33d8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:785662 
Reviewed-on: https://chromium-review.googlesource.com/816976
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522763}
[modify] https://crrev.com/14b857f982900cb6e61cb350342f35a46644f54a/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/14b857f982900cb6e61cb350342f35a46644f54a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/reveal-not-skipped-expected.txt
[modify] https://crrev.com/14b857f982900cb6e61cb350342f35a46644f54a/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/reveal-not-skipped.js

Sign in to add a comment