New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 785661 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Long OOO (go/where-is-mgiuca)
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task

Blocked on:
issue 729925
issue 793085



Sign in to add a comment

Add UMA for Desktop PWAs

Project Member Reported by mgiuca@chromium.org, Nov 16 2017

Issue description

In the following categories:
- Install prompts
- Linking and opening
- App window UI
- "Product usage" (what)

I've claimed this issue which was previously assigned to a different person in each category. Can you brainstorm ideas for what data to collect on this issue page? (Prompt: mcgreevy, Linking: ortuno, Window UI: calamity, Product: benwells)
 
Product usage == how much users are using installed PWAs.

More measurably:
- how much total time are users spending in PWAs
- how many PWA windows do users typically have open, and for how long
- how many installed PWAs do users typically have
- for each installed PWA, how much usage does it get?

Currently I think we just track simple metrics like how often bookmark apps are opened. I don't think that is very helpful, as users will probably leave some PWAs open for a long time (e.g. inbox - you open it infrequently but leave it open a lot, and use it heavily).

Maybe we could use engagement somehow.

Comment 3 by mgiuca@chromium.org, Nov 28 2017

Some more details collected in the meeting:

- Install prompts
  - Why dialog was shown (menu or banner) -- maybe this is already covered but AppBanners.DisplayEvent seems to only capture the site-triggered banner (not user triggered) so it doesn't look like we have a breakdown of what caused the banner to be shown.
- Linking and opening
  - Launch sources.
  - Navigation characteristics (if triggered by redirect, left-click, etc).
  - If app-scoped URL opened in browser tab, what caused it (why not open in app window).
- App window UI
  - Clicks on app menu
  - Usage of new app menu items (app info, open in chrome, copy url, etc).
  - Number of security indicators shown.
  - Security indicator buttons.
  - Info about page title (whether exact match, substring match).
- Product usage: as detailed in #2.

Comment 4 by mgiuca@chromium.org, Nov 28 2017

For the "why dialog was shown", we have WebApk.Install.InstallSource but that is specific to Android. That same metric would be sufficient on Desktop but can't re-use this name. We either need to introduce a new name or try to rename/unify the existing Android one.

For launch sources: Launch.HomeScreenSource is the Android equivalent. I don't think we want to re-use this since we're about to re-use the Extensions LaunchSource enum.

Comment 5 by mgiuca@chromium.org, Nov 28 2017

WIP CL for product usage: https://crrev.com/c/792315
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbf2395c6157cba65998f00abf67f772ac22c733

commit cbf2395c6157cba65998f00abf67f772ac22c733
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Tue Nov 28 08:37:26 2017

desktop-pwas: Add histogram for launching source for Bookmark Apps

Record the source for the launch of Bookmark Apps e.g. url handler,
shelf, etc.

Bug: 740783, 785661
Change-Id: Iede87c91d024bbcb9d797be522fbd2e45723d415
Reviewed-on: https://chromium-review.googlesource.com/595368
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519612}
[modify] https://crrev.com/cbf2395c6157cba65998f00abf67f772ac22c733/chrome/browser/ui/extensions/application_launch.cc
[modify] https://crrev.com/cbf2395c6157cba65998f00abf67f772ac22c733/tools/metrics/histograms/histograms.xml

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bfc2edbdf9ba3bb0fa343b31b01a79647a5de8a

commit 9bfc2edbdf9ba3bb0fa343b31b01a79647a5de8a
Author: Michael McGreevy <mcgreevy@chromium.org>
Date: Mon Dec 04 03:45:26 2017

Introduce Webapp.Install.InstallSource histogram.

This histogram has the same function as WebApk.Install.InstallSource
(which tracks the mechanism by which a web app is installed on Android),
but is intended for use on any platform.

The associated enum has an extra entry, which will be used to count
installs which are initiated via calls to BeforeInstallPrompt.prompt().

Once there is enough historical data for Android in
Webapp.Install.InstallSource, WebApk.Install.InstallSource will be
removed (tracking bug:  crbug.com/790788 )

Bug: 785661
Change-Id: Ie7d185a7e66e1caa2c25e850745171cb32165518
Reviewed-on: https://chromium-review.googlesource.com/802336
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521266}
[modify] https://crrev.com/9bfc2edbdf9ba3bb0fa343b31b01a79647a5de8a/chrome/browser/android/webapk/webapk_install_service.cc
[modify] https://crrev.com/9bfc2edbdf9ba3bb0fa343b31b01a79647a5de8a/chrome/browser/android/webapk/webapk_install_service.h
[modify] https://crrev.com/9bfc2edbdf9ba3bb0fa343b31b01a79647a5de8a/chrome/browser/android/webapk/webapk_metrics.cc
[modify] https://crrev.com/9bfc2edbdf9ba3bb0fa343b31b01a79647a5de8a/chrome/browser/android/webapk/webapk_metrics.h
[modify] https://crrev.com/9bfc2edbdf9ba3bb0fa343b31b01a79647a5de8a/chrome/browser/android/webapps/add_to_homescreen_manager.cc
[modify] https://crrev.com/9bfc2edbdf9ba3bb0fa343b31b01a79647a5de8a/chrome/browser/banners/app_banner_infobar_delegate_android.cc
[modify] https://crrev.com/9bfc2edbdf9ba3bb0fa343b31b01a79647a5de8a/chrome/browser/banners/app_banner_infobar_delegate_android.h
[modify] https://crrev.com/9bfc2edbdf9ba3bb0fa343b31b01a79647a5de8a/chrome/browser/banners/app_banner_manager.cc
[modify] https://crrev.com/9bfc2edbdf9ba3bb0fa343b31b01a79647a5de8a/chrome/browser/banners/app_banner_manager.h
[modify] https://crrev.com/9bfc2edbdf9ba3bb0fa343b31b01a79647a5de8a/chrome/browser/banners/app_banner_manager_android.cc
[modify] https://crrev.com/9bfc2edbdf9ba3bb0fa343b31b01a79647a5de8a/chrome/browser/banners/app_banner_manager_android.h
[modify] https://crrev.com/9bfc2edbdf9ba3bb0fa343b31b01a79647a5de8a/chrome/browser/banners/app_banner_manager_browsertest.cc
[modify] https://crrev.com/9bfc2edbdf9ba3bb0fa343b31b01a79647a5de8a/chrome/browser/banners/app_banner_manager_desktop.cc
[modify] https://crrev.com/9bfc2edbdf9ba3bb0fa343b31b01a79647a5de8a/chrome/browser/banners/app_banner_manager_desktop.h
[modify] https://crrev.com/9bfc2edbdf9ba3bb0fa343b31b01a79647a5de8a/chrome/browser/installable/installable_metrics.cc
[modify] https://crrev.com/9bfc2edbdf9ba3bb0fa343b31b01a79647a5de8a/chrome/browser/installable/installable_metrics.h
[modify] https://crrev.com/9bfc2edbdf9ba3bb0fa343b31b01a79647a5de8a/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/9bfc2edbdf9ba3bb0fa343b31b01a79647a5de8a/tools/metrics/histograms/histograms.xml

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/451206b63f93a9ab3f47e05ca350d18ca7b1f16f

commit 451206b63f93a9ab3f47e05ca350d18ca7b1f16f
Author: Christopher Lam <calamity@chromium.org>
Date: Mon Dec 04 04:00:22 2017

[desktop-pwas] Add UMA stats for Hosted App menu actions.

This CL adds standard wrench menu action stats for Copy URL, Open in
Chrome, Site Settings and App Info.

Bug: 785661
Change-Id: I1b94804076282ef9ecb97c581fb147670adaae70
Reviewed-on: https://chromium-review.googlesource.com/790172
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521267}
[modify] https://crrev.com/451206b63f93a9ab3f47e05ca350d18ca7b1f16f/chrome/browser/ui/toolbar/app_menu_model.cc
[modify] https://crrev.com/451206b63f93a9ab3f47e05ca350d18ca7b1f16f/chrome/browser/ui/toolbar/app_menu_model.h
[modify] https://crrev.com/451206b63f93a9ab3f47e05ca350d18ca7b1f16f/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/451206b63f93a9ab3f47e05ca350d18ca7b1f16f/tools/metrics/histograms/histograms.xml

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/654a8f0c7fa17ce04ee400f29b3104dc0dd18236

commit 654a8f0c7fa17ce04ee400f29b3104dc0dd18236
Author: Christopher Lam <calamity@chromium.org>
Date: Mon Dec 04 05:40:44 2017

[desktop-pwas] Add metrics for menu actions in the Hosted App Frame.

This CL adds the "HostedAppFrame.WrenchMenu.MenuAction" metric which
tracks which menu actions are being clicked from the hosted app browser
frame.

Bug: 785661
Change-Id: I4b6c349892615452ce8ed6ebc8b1c23e5f1a8a9e
Reviewed-on: https://chromium-review.googlesource.com/802838
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521273}
[modify] https://crrev.com/654a8f0c7fa17ce04ee400f29b3104dc0dd18236/chrome/browser/ui/extensions/hosted_app_menu_model.cc
[modify] https://crrev.com/654a8f0c7fa17ce04ee400f29b3104dc0dd18236/chrome/browser/ui/extensions/hosted_app_menu_model.h
[modify] https://crrev.com/654a8f0c7fa17ce04ee400f29b3104dc0dd18236/chrome/browser/ui/toolbar/app_menu_model.cc
[modify] https://crrev.com/654a8f0c7fa17ce04ee400f29b3104dc0dd18236/chrome/browser/ui/toolbar/app_menu_model.h
[modify] https://crrev.com/654a8f0c7fa17ce04ee400f29b3104dc0dd18236/tools/metrics/histograms/histograms.xml

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bf4cfee2b63a31a63e33ac3acb309092774ac47

commit 6bf4cfee2b63a31a63e33ac3acb309092774ac47
Author: Matt Giuca <mgiuca@chromium.org>
Date: Tue Dec 05 08:33:00 2017

SiteEngagementObserver now gets the engagement type (+ refactor).

This is to support https://crrev.com/c/792315, which adds a new observer
for logging engagement-type UMA in PWA app windows.

The major interface changes are:
- Renamed OnEngagementIncreased to OnEngagementEvent to indicate that it
  is now for all events that modify engagement, not just increases.
- OnEngagementEvent is now called on launch (so now every place where an
  engagement UMA is logged also corresponds to an OnEngagementEvent).
- OnEngagementEvent now takes an EngagementType enum, indicating what
  caused the engagement event.

Because the engagement type is now exposed through the observer (and can
therefore be used for non-metrics purposes), it has been moved out of
SiteEngagementMetrics into SiteEngagementService.

Also refactored SiteEngagementService to record UMA from the
OnEngagementEvent method, rather than in many places.

Bug: 785661
Change-Id: I352d0363c9ee3a40293e7b99d5b8f6e75c0e999b
Reviewed-on: https://chromium-review.googlesource.com/802661
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521639}
[modify] https://crrev.com/6bf4cfee2b63a31a63e33ac3acb309092774ac47/chrome/browser/android/metrics/launch_metrics.cc
[modify] https://crrev.com/6bf4cfee2b63a31a63e33ac3acb309092774ac47/chrome/browser/banners/app_banner_manager.cc
[modify] https://crrev.com/6bf4cfee2b63a31a63e33ac3acb309092774ac47/chrome/browser/banners/app_banner_manager.h
[modify] https://crrev.com/6bf4cfee2b63a31a63e33ac3acb309092774ac47/chrome/browser/banners/app_banner_manager_desktop.cc
[modify] https://crrev.com/6bf4cfee2b63a31a63e33ac3acb309092774ac47/chrome/browser/banners/app_banner_manager_desktop.h
[modify] https://crrev.com/6bf4cfee2b63a31a63e33ac3acb309092774ac47/chrome/browser/engagement/site_engagement_helper.cc
[modify] https://crrev.com/6bf4cfee2b63a31a63e33ac3acb309092774ac47/chrome/browser/engagement/site_engagement_helper.h
[modify] https://crrev.com/6bf4cfee2b63a31a63e33ac3acb309092774ac47/chrome/browser/engagement/site_engagement_helper_unittest.cc
[modify] https://crrev.com/6bf4cfee2b63a31a63e33ac3acb309092774ac47/chrome/browser/engagement/site_engagement_metrics.cc
[modify] https://crrev.com/6bf4cfee2b63a31a63e33ac3acb309092774ac47/chrome/browser/engagement/site_engagement_metrics.h
[modify] https://crrev.com/6bf4cfee2b63a31a63e33ac3acb309092774ac47/chrome/browser/engagement/site_engagement_observer.h
[modify] https://crrev.com/6bf4cfee2b63a31a63e33ac3acb309092774ac47/chrome/browser/engagement/site_engagement_score.cc
[modify] https://crrev.com/6bf4cfee2b63a31a63e33ac3acb309092774ac47/chrome/browser/engagement/site_engagement_service.cc
[modify] https://crrev.com/6bf4cfee2b63a31a63e33ac3acb309092774ac47/chrome/browser/engagement/site_engagement_service.h
[modify] https://crrev.com/6bf4cfee2b63a31a63e33ac3acb309092774ac47/chrome/browser/engagement/site_engagement_service_unittest.cc
[modify] https://crrev.com/6bf4cfee2b63a31a63e33ac3acb309092774ac47/chrome/browser/ui/extensions/application_launch.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1906d76e044893f7908ea8cefd08c8efce891db9

commit 1906d76e044893f7908ea8cefd08c8efce891db9
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Wed Dec 06 06:15:27 2017

desktop-pwas: Histogram results of processing navigations

This new histogram allows us to know why a navigation ended up being
intercept or why it didn't. It'll help us understand how often users get
into apps as well as how often users get into websites for which they
have an app installed.

Bug: 785661
Change-Id: I2668f34421958b88885f53113b82a391777d9f36
Reviewed-on: https://chromium-review.googlesource.com/798250
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522025}
[modify] https://crrev.com/1906d76e044893f7908ea8cefd08c8efce891db9/chrome/browser/extensions/bookmark_app_navigation_throttle.cc
[modify] https://crrev.com/1906d76e044893f7908ea8cefd08c8efce891db9/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/1906d76e044893f7908ea8cefd08c8efce891db9/tools/metrics/histograms/histograms.xml

Project Member

Comment 12 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aef5085dede0f90ef36e57442312b58accf83c2f

commit aef5085dede0f90ef36e57442312b58accf83c2f
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Thu Dec 07 02:14:08 2017

desktop-pwas: Record delta between opening an app window and last navigation

If the time difference is small, then we probably opened an app window
in response to a client side redirect and left the tab opened. This
will let us know how common this problem is.

Bug: 785661
Change-Id: Icc5a015cd5c0ae9fda5ad457ad564ead4b812332
Reviewed-on: https://chromium-review.googlesource.com/798951
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522307}
[modify] https://crrev.com/aef5085dede0f90ef36e57442312b58accf83c2f/chrome/browser/extensions/bookmark_app_navigation_throttle.cc
[modify] https://crrev.com/aef5085dede0f90ef36e57442312b58accf83c2f/tools/metrics/histograms/histograms.xml

Project Member

Comment 13 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb511e623f80d7717b627b8898443d3ea36b36c8

commit fb511e623f80d7717b627b8898443d3ea36b36c8
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Thu Dec 07 04:37:59 2017

desktop-pwas: Add timers to functions that retrieve apps

Help measure the overhead of retrieving apps during navigations.

Bug: 785661
Change-Id: I8e31ba9373744e6d68942e96f207d3eac1bb67f0
Reviewed-on: https://chromium-review.googlesource.com/809920
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522338}
[modify] https://crrev.com/fb511e623f80d7717b627b8898443d3ea36b36c8/chrome/browser/extensions/bookmark_app_navigation_throttle.cc
[modify] https://crrev.com/fb511e623f80d7717b627b8898443d3ea36b36c8/tools/metrics/histograms/histograms.xml

Blockedon: 793085
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b2dd90c78b874d86ba3ad48584b230bbea9a5e9

commit 4b2dd90c78b874d86ba3ad48584b230bbea9a5e9
Author: Christopher Lam <calamity@chromium.org>
Date: Fri Dec 08 03:21:06 2017

Add metrics for content setting buttons.

This CL adds metrics for content setting buttons in the omnibox and in
the hosted app browser frame under the names ContentSettings.ImagePressed
and HostedAppFrame.ContentSettings.ImagePressed respectively.

This CL also refactors content setting image models to be based on a
separate enum from content setting types so that the two are uncoupled.

Bug: 785661
Change-Id: Ia613b168b2dd101d5dad2cc7e22718d511569b3a
Reviewed-on: https://chromium-review.googlesource.com/802595
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522697}
[modify] https://crrev.com/4b2dd90c78b874d86ba3ad48584b230bbea9a5e9/chrome/browser/ui/cocoa/location_bar/content_setting_decoration_browsertest.mm
[modify] https://crrev.com/4b2dd90c78b874d86ba3ad48584b230bbea9a5e9/chrome/browser/ui/content_settings/content_setting_image_model.cc
[modify] https://crrev.com/4b2dd90c78b874d86ba3ad48584b230bbea9a5e9/chrome/browser/ui/content_settings/content_setting_image_model.h
[modify] https://crrev.com/4b2dd90c78b874d86ba3ad48584b230bbea9a5e9/chrome/browser/ui/content_settings/content_setting_image_model_browsertest.cc
[modify] https://crrev.com/4b2dd90c78b874d86ba3ad48584b230bbea9a5e9/chrome/browser/ui/content_settings/content_setting_image_model_unittest.cc
[modify] https://crrev.com/4b2dd90c78b874d86ba3ad48584b230bbea9a5e9/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/4b2dd90c78b874d86ba3ad48584b230bbea9a5e9/chrome/browser/ui/views/frame/hosted_app_button_container.cc
[modify] https://crrev.com/4b2dd90c78b874d86ba3ad48584b230bbea9a5e9/chrome/browser/ui/views/frame/hosted_app_button_container.h
[modify] https://crrev.com/4b2dd90c78b874d86ba3ad48584b230bbea9a5e9/chrome/browser/ui/views/location_bar/content_setting_bubble_dialog_browsertest.cc
[modify] https://crrev.com/4b2dd90c78b874d86ba3ad48584b230bbea9a5e9/chrome/browser/ui/views/location_bar/content_setting_image_view.cc
[modify] https://crrev.com/4b2dd90c78b874d86ba3ad48584b230bbea9a5e9/chrome/browser/ui/views/location_bar/content_setting_image_view.h
[modify] https://crrev.com/4b2dd90c78b874d86ba3ad48584b230bbea9a5e9/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/4b2dd90c78b874d86ba3ad48584b230bbea9a5e9/tools/metrics/histograms/histograms.xml

Project Member

Comment 16 by bugdroid1@chromium.org, Dec 8 2017

Labels: merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/760e07585ec9152d1808bc934570fbeff777b907

commit 760e07585ec9152d1808bc934570fbeff777b907
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Fri Dec 08 23:10:51 2017

desktop-pwas: Histogram results of processing navigations

This new histogram allows us to know why a navigation ended up being
intercept or why it didn't. It'll help us understand how often users get
into apps as well as how often users get into websites for which they
have an app installed.

Bug: 785661
Change-Id: I2668f34421958b88885f53113b82a391777d9f36
Reviewed-on: https://chromium-review.googlesource.com/798250
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#522025}(cherry picked from commit 1906d76e044893f7908ea8cefd08c8efce891db9)
Reviewed-on: https://chromium-review.googlesource.com/818360
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#107}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/760e07585ec9152d1808bc934570fbeff777b907/chrome/browser/extensions/bookmark_app_navigation_throttle.cc
[modify] https://crrev.com/760e07585ec9152d1808bc934570fbeff777b907/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/760e07585ec9152d1808bc934570fbeff777b907/tools/metrics/histograms/histograms.xml

Project Member

Comment 17 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/696ce2f4da2a0142e06ae76b4fe317af0446d5ac

commit 696ce2f4da2a0142e06ae76b4fe317af0446d5ac
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Tue Dec 12 06:10:31 2017

desktop-pwas: Test histograms in BookmarkAppNavigationThrottleBrowserTests

Add checks to current tests to make sure that
BookmarkAppNavigationThrottle records the correct values for each case.

Bug: 785661
Change-Id: Ic975722978309eb87acafa3b071693f0bc52f964
Reviewed-on: https://chromium-review.googlesource.com/813355
Commit-Queue: Ben Wells <benwells@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523353}
[modify] https://crrev.com/696ce2f4da2a0142e06ae76b4fe317af0446d5ac/chrome/browser/extensions/bookmark_app_navigation_throttle.cc
[modify] https://crrev.com/696ce2f4da2a0142e06ae76b4fe317af0446d5ac/chrome/browser/extensions/bookmark_app_navigation_throttle.h
[modify] https://crrev.com/696ce2f4da2a0142e06ae76b4fe317af0446d5ac/chrome/browser/extensions/bookmark_app_navigation_throttle_browsertest.cc

Project Member

Comment 18 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52dad56b5151b36abee65b87c9e83adab2a144e2

commit 52dad56b5151b36abee65b87c9e83adab2a144e2
Author: Michael McGreevy <mcgreevy@chromium.org>
Date: Wed Dec 20 04:55:50 2017

Log the source when installing a PWA on desktop.

Bug: 785661
Change-Id: Ibeef9470ce0224869e4d398115d211a123b82417
Reviewed-on: https://chromium-review.googlesource.com/804907
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525265}
[modify] https://crrev.com/52dad56b5151b36abee65b87c9e83adab2a144e2/chrome/browser/android/webapk/webapk_metrics.cc
[modify] https://crrev.com/52dad56b5151b36abee65b87c9e83adab2a144e2/chrome/browser/banners/app_banner_manager_desktop.cc
[modify] https://crrev.com/52dad56b5151b36abee65b87c9e83adab2a144e2/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc
[modify] https://crrev.com/52dad56b5151b36abee65b87c9e83adab2a144e2/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/52dad56b5151b36abee65b87c9e83adab2a144e2/chrome/browser/extensions/bookmark_app_helper.h
[modify] https://crrev.com/52dad56b5151b36abee65b87c9e83adab2a144e2/chrome/browser/extensions/bookmark_app_helper_browsertest.cc
[modify] https://crrev.com/52dad56b5151b36abee65b87c9e83adab2a144e2/chrome/browser/extensions/bookmark_app_helper_unittest.cc
[modify] https://crrev.com/52dad56b5151b36abee65b87c9e83adab2a144e2/chrome/browser/extensions/tab_helper.cc
[modify] https://crrev.com/52dad56b5151b36abee65b87c9e83adab2a144e2/chrome/browser/installable/installable_metrics.cc
[modify] https://crrev.com/52dad56b5151b36abee65b87c9e83adab2a144e2/chrome/browser/installable/installable_metrics.h
[modify] https://crrev.com/52dad56b5151b36abee65b87c9e83adab2a144e2/tools/metrics/histograms/enums.xml

Blockedon: 729925
Status: Started (was: Assigned)
List of metrics we'll be considering, and a few TODOs:
https://docs.google.com/spreadsheets/d/1OCwbkIEatF-gxAebx0pRv9NtlxpwGMM9ytSLnCWDs3U/edit (internal only)
Labels: -Type-Bug Type-Task
Labels: M-67

Sign in to add a comment