New issue
Advanced search Search tips

Issue 785608 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

LoginWebDialogTest failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1)

Project Member Reported by horo@chromium.org, Nov 16 2017

Issue description

browser_tests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1)

Builders failed on: 
- Linux Chromium OS ASan LSan Tests (1): 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29


LoginWebDialogTest.CannotMinimize
LoginWebDialogTest.CloseDialogByAccelerator
 
==23581==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7f2154274830 at pc 0x000004cf67a0 bp 0x7ffe5e5cc010 sp 0x7ffe5e5cc008
READ of size 4 at 0x7f2154274830 thread T0 (browser_tests)
    #0 0x4cf679f in width ui/gfx/geometry/size.h:44:40
    #1 0x4cf679f in width ui/gfx/geometry/rect.h:75
    #2 0x4cf679f in chromeos::LoginWebDialog::LoginWebDialog(content::BrowserContext*, chromeos::LoginWebDialog::Delegate*, aura::Window*, std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> > const&, GURL const&) chrome/browser/chromeos/login/ui/login_web_dialog.cc:68
    #3 0x3c60848 in chromeos::LoginWebDialogTest_CannotMinimize_Test::RunTestOnMainThread() chrome/browser/chromeos/login/ui/login_web_dialog_browsertest.cc:23:32
    #4 0xe80db8f in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() content/public/test/browser_test_base.cc:342:5
    #5 0xd55b689 in Run base/callback.h:94:12
    #6 0xd55b689 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1864
    #7 0xd558843 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:1195:18
    #8 0x48a5d33 in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() chrome/browser/chromeos/chrome_browser_main_chromeos.cc:739:32
    #9 0x79dec84 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:1189:13
    #10 0x8a43fc0 in Run base/callback.h:94:12
    #11 0x8a43fc0 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45
    #12 0x79d98ef in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:973:25
    #13 0x79eae88 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:119:17
    #14 0x79d256b in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:42:32
    #15 0xcea2a2a in content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) content/app/content_main_runner.cc:427:14
    #16 0xcea4c76 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:705:12
    #17 0x13ced494 in service_manager::Main(service_manager::MainParams const&) services/service_manager/embedder/main.cc:456:29
    #18 0xcea0dd3 in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:10
    #19 0xe80ca3e in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:298:3
    #20 0xd456a06 in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:263:20
    #21 0x542a70c in testing::Test::Run() third_party/googletest/src/googletest/src/gtest-internal-inl.h
    #22 0x542c6a4 in testing::TestInfo::Run() third_party/googletest/src/googletest/src/gtest.cc:2654:11
    #23 0x542da06 in testing::TestCase::Run() third_party/googletest/src/googletest/src/gtest.cc:2772:28
    #24 0x54434f6 in testing::internal::UnitTestImpl::RunAllTests() third_party/googletest/src/googletest/src/gtest.cc:4677:43
    #25 0x5442a78 in testing::UnitTest::Run() third_party/googletest/src/googletest/src/gtest.cc
    #26 0xd4a6b35 in RUN_ALL_TESTS third_party/googletest/src/googletest/include/gtest/gtest.h:2237:46
    #27 0xd4a6b35 in base::TestSuite::Run() base/test/test_suite.cc:270
    #28 0xd0c970c in ChromeTestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/chrome_test_launcher.cc:72:38
    #29 0xe916c9a in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) content/public/test/test_launcher.cc:639:31
    #30 0xd0ca3c3 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) chrome/test/base/chrome_test_launcher.cc:169:10
    #31 0xd0c8f4c in main chrome/test/base/browser_tests_main_chromeos.cc:26:10
    #32 0x7f2158411f44 in __libc_start_main /build/eglibc-SvCtMH/eglibc-2.19/csu/libc-start.c:287
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50a372b0c9c349c72d95e0bd7b9e17a0694b195b

commit 50a372b0c9c349c72d95e0bd7b9e17a0694b195b
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Thu Nov 16 02:02:37 2017

Revert "cros: Simplify LoginDisplayHostWebUi constructor."

This reverts commit 9907da6f88efaedf0c25c1398d2859952bafd61d.

Reason for revert: Caused ASan failure.
BUG:785608

Original change's description:
> cros: Simplify LoginDisplayHostWebUi constructor.
> 
> Bug:  784495 
> Change-Id: I5637b64624af37a28aa31005f9a21cb88f41098f
> Reviewed-on: https://chromium-review.googlesource.com/753126
> Commit-Queue: Jacob Dufault <jdufault@chromium.org>
> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516835}

TBR=achuith@chromium.org,jdufault@chromium.org

Change-Id: I24bdf4485ca2002d26a8fbf7e03b9d167d371ea9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  784495 
Reviewed-on: https://chromium-review.googlesource.com/773858
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516953}
[modify] https://crrev.com/50a372b0c9c349c72d95e0bd7b9e17a0694b195b/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc
[modify] https://crrev.com/50a372b0c9c349c72d95e0bd7b9e17a0694b195b/chrome/browser/chromeos/login/helper.cc
[modify] https://crrev.com/50a372b0c9c349c72d95e0bd7b9e17a0694b195b/chrome/browser/chromeos/login/helper.h
[modify] https://crrev.com/50a372b0c9c349c72d95e0bd7b9e17a0694b195b/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/50a372b0c9c349c72d95e0bd7b9e17a0694b195b/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/50a372b0c9c349c72d95e0bd7b9e17a0694b195b/chrome/browser/chromeos/login/ui/login_web_dialog.cc
[modify] https://crrev.com/50a372b0c9c349c72d95e0bd7b9e17a0694b195b/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc
[modify] https://crrev.com/50a372b0c9c349c72d95e0bd7b9e17a0694b195b/chrome/browser/chromeos/login/ui/user_adding_screen.cc

Comment 2 by guidou@chromium.org, Nov 17 2017

Labels: -Sheriff-Chromium
Labels: Pri-2
Setting defect without priority to Pri-2.

Sign in to add a comment