New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 785583 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Chrome OS UI: SMS messages with Unicode characters are not shown correctly in notification

Project Member Reported by benchan@chromium.org, Nov 16 2017

Issue description

SMS messages with Unicode characters are not shown correctly in notification. The current implementation incorrectly treats UTF-8 encoded SMS messages as ASCII.
 
Cc: steve...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b344530d6d9c7898e2cb626880a8e841e5922ce

commit 2b344530d6d9c7898e2cb626880a8e841e5922ce
Author: Ben Chan <benchan@chromium.org>
Date: Thu Nov 16 20:11:34 2017

chromeos: fix Unicode conversion of SMS messages

SMS messages, notified by chromeos::NetworkSmsHandler, are encoded in
UTF-8. ash::SmsObserver incorrectly treats the received SMS messages as
ASCII, which causes incorrect characters to be shown in the notification
window.

      correctly in the notification.

Bug:  785583 
Test: Verify that SMS messages with Unicode characters are shown
Change-Id: I6a4f90d4e3c01b537f8b103e8038f7ad423b7621
Reviewed-on: https://chromium-review.googlesource.com/773620
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ben Chan <benchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517164}
[modify] https://crrev.com/2b344530d6d9c7898e2cb626880a8e841e5922ce/ash/system/network/sms_observer.cc
[modify] https://crrev.com/2b344530d6d9c7898e2cb626880a8e841e5922ce/ash/system/network/sms_observer_unittest.cc

Status: Fixed (was: Started)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment