Issue metadata
Sign in to add a comment
|
10.2%-11.8% regression in blink_perf.parser at 515947:516063 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Nov 16 2017
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/1011d9a9f80000
,
Nov 16 2017
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/1011d9a9f80000
,
Nov 16 2017
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14965075f80000
,
Nov 16 2017
📍 Couldn't reproduce a difference. https://pinpoint-dot-chromeperf.appspot.com/job/14965075f80000
,
Nov 18 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8962624598075280496
,
Nov 18 2017
=== Auto-CCing suspected CL author lfg@chromium.org === Hi lfg@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Lucas Furukawa Gadani Commit : 6dd09a38aaae9c15adf5aad966f761f180bf1cef Date : Mon Nov 13 18:34:22 2017 Subject: Cleanup blink::SegmentedString. Bisect Details Configuration: android_nexus5_perf_bisect Benchmark : blink_perf.parser Metric : textarea-parsing/textarea-parsing Change : 12.31% | 156.779518439 -> 137.479019121 Revision Result N chromium@515900 156.78 +- 1.742 6 good chromium@515975 157.538 +- 3.65621 6 good chromium@515985 156.395 +- 2.74554 6 good chromium@515988 156.368 +- 0.615048 6 good chromium@515989 138.066 +- 3.69351 6 bad <-- chromium@515990 137.933 +- 1.37331 6 bad chromium@515994 139.114 +- 4.25734 6 bad chromium@516013 136.049 +- 5.94425 6 bad chromium@516050 140.27 +- 3.67437 6 bad chromium@516200 137.479 +- 2.79571 6 bad Please refer to the following doc on diagnosing blink_perf regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.parser More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8962624598075280496 For feedback, file a bug with component Speed>Bisection
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a3ee08dab4bac17fe3b74141ab20a8e94bff7c9 commit 9a3ee08dab4bac17fe3b74141ab20a8e94bff7c9 Author: Lucas Furukawa Gadani <lfg@chromium.org> Date: Tue Nov 21 15:31:54 2017 Force inline hot functions in SegmentedString. Bug: 785575 Change-Id: I95ecac20a839c47da436ea5440cc7589c9854b99 Reviewed-on: https://chromium-review.googlesource.com/780181 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#518261} [modify] https://crrev.com/9a3ee08dab4bac17fe3b74141ab20a8e94bff7c9/third_party/WebKit/Source/platform/text/SegmentedString.h
,
Nov 21 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Nov 16 2017