New issue
Advanced search Search tips

Issue 785571 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Dec 5
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools : console-context-selector.js test is flaky

Project Member Reported by einbinder@chromium.org, Nov 16 2017

Issue description

We should fix it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/380efbd7d3d3817a6a1339ca61c5aead7c8d81c5

commit 380efbd7d3d3817a6a1339ca61c5aead7c8d81c5
Author: Joel Einbinder <einbinder@chromium.org>
Date: Thu Nov 16 00:51:13 2017

DevTools: Disable console-context-selector.js test

Bug:  785571 
NOTRY=true

Change-Id: I6c51785136f4efaf8626accdd385c654abf6f3b2
Reviewed-on: https://chromium-review.googlesource.com/773578
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516925}
[modify] https://crrev.com/380efbd7d3d3817a6a1339ca61c5aead7c8d81c5/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10126b3ab2b3d9986dc1d3a6bae1d860eaf73034

commit 10126b3ab2b3d9986dc1d3a6bae1d860eaf73034
Author: Will Chen <chenwilliam@chromium.org>
Date: Fri Jan 05 00:01:57 2018

DevTools: deflake http/tests/devtools/console/console-context-selector.js

This test was flaky because it wasn't waiting for the execution context
flavor to change.

Drive-by: remove unused lines of code.

Bug:  785571 
Change-Id: I00c65fb18150d4289e70aaa1bb0a825b8ba2260f
Reviewed-on: https://chromium-review.googlesource.com/851076
Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527157}
[modify] https://crrev.com/10126b3ab2b3d9986dc1d3a6bae1d860eaf73034/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/10126b3ab2b3d9986dc1d3a6bae1d860eaf73034/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-context-selector.js

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4ffa0cd63108b917aaad530c8ebe824f3495885

commit c4ffa0cd63108b917aaad530c8ebe824f3495885
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Fri Jan 05 12:33:17 2018

Revert "DevTools: deflake http/tests/devtools/console/console-context-selector.js"

This reverts commit 10126b3ab2b3d9986dc1d3a6bae1d860eaf73034.

Reason for revert: console-context-selector.js still fails on some bulders. For example https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/11826

Original change's description:
> DevTools: deflake http/tests/devtools/console/console-context-selector.js
> 
> This test was flaky because it wasn't waiting for the execution context
> flavor to change.
> 
> Drive-by: remove unused lines of code.
> 
> Bug:  785571 
> Change-Id: I00c65fb18150d4289e70aaa1bb0a825b8ba2260f
> Reviewed-on: https://chromium-review.googlesource.com/851076
> Reviewed-by: Erik Luo <luoe@chromium.org>
> Commit-Queue: Will Chen <chenwilliam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#527157}

TBR=einbinder@chromium.org,chenwilliam@chromium.org,luoe@chromium.org

Change-Id: Ie2fe84faae91fd3856acd0aca3772a873aeaa9fb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  785571 
Reviewed-on: https://chromium-review.googlesource.com/852143
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527260}
[modify] https://crrev.com/c4ffa0cd63108b917aaad530c8ebe824f3495885/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c4ffa0cd63108b917aaad530c8ebe824f3495885/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-context-selector.js

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d82eb4c9c854f26572c67e262f63f253a57fa13

commit 7d82eb4c9c854f26572c67e262f63f253a57fa13
Author: Will Chen <chenwilliam@chromium.org>
Date: Fri Jan 05 22:03:46 2018

Reland "DevTools: deflake http/tests/devtools/console/console-context-selector.js"

Leaving it marked as a flaky test so we can see which platforms
this test is flaky for.

This is a reland of 10126b3ab2b3d9986dc1d3a6bae1d860eaf73034
Original change's description:
> DevTools: deflake http/tests/devtools/console/console-context-selector.js
>
> This test was flaky because it wasn't waiting for the execution context
> flavor to change.
>
> Drive-by: remove unused lines of code.
>
> Bug:  785571 
> Change-Id: I00c65fb18150d4289e70aaa1bb0a825b8ba2260f
> Reviewed-on: https://chromium-review.googlesource.com/851076
> Reviewed-by: Erik Luo <luoe@chromium.org>
> Commit-Queue: Will Chen <chenwilliam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#527157}

TBR=luoe@chromium.org

Bug:  785571 
Change-Id: I22454ab91e4e58cfe7db72f01a5c4b7115248164
Reviewed-on: https://chromium-review.googlesource.com/852892
Reviewed-by: Will Chen <chenwilliam@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527404}
[modify] https://crrev.com/7d82eb4c9c854f26572c67e262f63f253a57fa13/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-context-selector.js

Status: Archived (was: Assigned)
Test failures are processed as a part of a dedicated triage, bulk-closing the bugs.

Sign in to add a comment