New issue
Advanced search Search tips

Issue 785556 link

Starred by 1 user
Status: Fixed
Owner:
zhangtiff@chromium.org
Closed: Nov 2017
Cc:
seanmccullough@chromium.org
dpranke@chromium.org
zhangtiff@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

grouping from alert and bulk actions work differently

Project Member Reported by seanmccullough@chromium.org, Nov 16 2017 
This is confusing to users.

Click on "Group" in a single alert, you get a dialog box with all the alerts/groups listed and checkboxes next to each.

Click on checkboxes next to alerts and you get a "Group All" bulk action.

dpranke, via chat: 

"if I check several boxes, and then click on "group", I get a dialog that pops up showing *all* of the failures (including ones I didn't check) and asking me which ones I want?"

"I would expect that, if boxes were checked and you clicked on any "group" button, that button would just group the checked items and not ask for more."

Comment 1 by zhangtiff@chromium.org, Nov 16 2017 

Good feedback! Though it's not completely clear to me that the correct solution to this is to make any group button act the same as "Group All". 

Personally, I would prefer to either remove the per-alert group button entirely or to keep the group selection modal but automatically check any already selected alerts. 

Though I really do think bulk actions should be encouraged as the default manner for grouping, so I'm sort of leaning towards just removing per-alert group buttons. My only concern if we do that, though, is that then grouping becomes less discoverable.

Comment 2 by dpranke@chromium.org, Nov 16 2017 

Removing per-alert grouping works for me. I think that per-alert is needed for "ungroup" (since it's really per-group in that case), but probably not "group".
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/06810efc4fb28dd1cc2182a8db8e64ace2bef9d3

commit 06810efc4fb28dd1cc2182a8db8e64ace2bef9d3
Author: Tiff Zhang <zhangtiff@google.com>
Date: Fri Nov 17 19:10:55 2017

SoM: Remove per-alert group button.

Bug:785556
Change-Id: Iccb9e6949acff50634ca8728a02300e956b7ce03
Reviewed-on: https://chromium-review.googlesource.com/776396
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/06810efc4fb28dd1cc2182a8db8e64ace2bef9d3/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.js
[modify] https://crrev.com/06810efc4fb28dd1cc2182a8db8e64ace2bef9d3/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-annotations.js
[modify] https://crrev.com/06810efc4fb28dd1cc2182a8db8e64ace2bef9d3/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-annotations.html
[modify] https://crrev.com/06810efc4fb28dd1cc2182a8db8e64ace2bef9d3/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.html
[modify] https://crrev.com/06810efc4fb28dd1cc2182a8db8e64ace2bef9d3/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-item/som-alert-item.js
[modify] https://crrev.com/06810efc4fb28dd1cc2182a8db8e64ace2bef9d3/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-item/som-alert-item.html

Comment 4 by zhangtiff@chromium.org, Nov 22 2017

Owner: zhangtiff@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment