New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 785540 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task

Blocked on:
issue 784588
issue 784654



Sign in to add a comment

Delete property-animations-toolbar flag and related code.

Project Member Reported by sczs@chromium.org, Nov 15 2017

Issue description

Tracking bug for "property-animations-toolbar" flag. 
When enabled, Toolbar animations will be done using UIViewPropertyAnimators.
 

Comment 1 by sczs@chromium.org, Nov 15 2017

Blockedon: 784654

Comment 2 by sczs@chromium.org, Nov 15 2017

Blockedon: 784588

Comment 3 by sczs@chromium.org, Dec 6 2017

Summary: Delete property-animations-toolbar flag and related code. (was: Animations Architecture: property-animations-toolbar flag flip bug)
This flag and its related code will now be deleted. This bug will now track that

Comment 4 by sczs@chromium.org, Dec 6 2017

Cc: sczs@chromium.org linds...@chromium.org
 Issue 785263  has been merged into this issue.

Comment 5 by sczs@chromium.org, Dec 7 2017

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/075c6b08515a930980da1e9c5eecbe6105c08daf

commit 075c6b08515a930980da1e9c5eecbe6105c08daf
Author: sczs <sczs@chromium.org>
Date: Fri Dec 08 01:07:41 2017

[ios] Deletes property-animations-toolbar flag and related code.

Bug:  785540 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib2ccaf9fddb4389997d2c8787dac0704e7cb95a0
Reviewed-on: https://chromium-review.googlesource.com/813238
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522664}
[modify] https://crrev.com/075c6b08515a930980da1e9c5eecbe6105c08daf/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/075c6b08515a930980da1e9c5eecbe6105c08daf/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/075c6b08515a930980da1e9c5eecbe6105c08daf/ios/chrome/browser/ios_chrome_flag_descriptions.h
[modify] https://crrev.com/075c6b08515a930980da1e9c5eecbe6105c08daf/ios/chrome/browser/ui/toolbar/public/toolbar_controller_base_feature.h
[modify] https://crrev.com/075c6b08515a930980da1e9c5eecbe6105c08daf/ios/chrome/browser/ui/toolbar/public/toolbar_controller_base_feature.mm
[modify] https://crrev.com/075c6b08515a930980da1e9c5eecbe6105c08daf/ios/chrome/browser/ui/toolbar/toolbar_controller+protected.h
[modify] https://crrev.com/075c6b08515a930980da1e9c5eecbe6105c08daf/ios/chrome/browser/ui/toolbar/toolbar_controller.mm
[modify] https://crrev.com/075c6b08515a930980da1e9c5eecbe6105c08daf/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm

Comment 7 by sczs@chromium.org, Dec 8 2017

Status: Fixed (was: Started)
Verified on chrome canary version 65.0.3292.0, property-animations-toolbar flag is not available in chrome://flags.  Marking the status to verified.
Status: Verified (was: Fixed)

Sign in to add a comment