New issue
Advanced search Search tips

Issue 785536 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 731255



Sign in to add a comment

Reevaluate content_browsertests and browser_tests once mus no longer implies viz

Project Member Reported by sky@chromium.org, Nov 15 2017

Issue description

The hope is many of the tests just work once --mus no longer includes --viz.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97152ee5e7093c0e1b9cea15209dc5985a36c2a3

commit 97152ee5e7093c0e1b9cea15209dc5985a36c2a3
Author: Sadrul Habib Chowdhury <sadrul@chromium.org>
Date: Thu Dec 07 04:55:27 2017

mus: Run browser_tests in the now-default mode for --mus.

mus should no longer host viz for browser_tests --mus. So it should not have
--mus=viz flag set. With this change, the browser_tests no longer need the
filter file. So remove it (from main and fyi waterfalls).

BUG= 786453 ,  785536 

Change-Id: Ia9ecfdc8f667bb07cf53debbc98f960938f6d452
Reviewed-on: https://chromium-review.googlesource.com/812169
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522341}
[modify] https://crrev.com/97152ee5e7093c0e1b9cea15209dc5985a36c2a3/chrome/test/base/mash_browser_tests_main.cc
[modify] https://crrev.com/97152ee5e7093c0e1b9cea15209dc5985a36c2a3/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/97152ee5e7093c0e1b9cea15209dc5985a36c2a3/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/97152ee5e7093c0e1b9cea15209dc5985a36c2a3/testing/buildbot/filters/BUILD.gn
[delete] https://crrev.com/43225a397b57f9df2b5fbfa2a7917d89bbf6f09a/testing/buildbot/filters/mojo.fyi.mus.browser_tests.filter
[delete] https://crrev.com/43225a397b57f9df2b5fbfa2a7917d89bbf6f09a/testing/buildbot/filters/mus.browser_tests.filter

Comment 2 by sky@chromium.org, Dec 12 2017

Cc: sadrul@chromium.org
browser_tests --mus no longer has a filter file. content_browsertests is still failing a single test: 
GLAndSoftwareCompositing/CompositingRenderWidgetHostViewBrowserTestHiDPI.ScrollOffset/0 . Sadrul is looking into it.

Comment 3 by sky@chromium.org, Dec 14 2017

Owner: sadrul@chromium.org
Status: Started (was: Assigned)
Sadrul, I'm passing your way as you are looking at the last blocker.

Comment 4 by sky@chromium.org, Jan 4 2018

I'm going to make the test early out for --mus. I filed 798904 to track reenabling.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac9200c08be2bfba29ff4d09147a0acd4c5c2c59

commit ac9200c08be2bfba29ff4d09147a0acd4c5c2c59
Author: Scott Violet <sky@chromium.org>
Date: Thu Jan 04 01:30:40 2018

chromeos: disable CompositingRenderWidgetHostViewBrowserTestHiDPI for mus

This makes it possible to turn on content_browsertests with --mus

BUG= 785536 
TEST=test only change
TBR=sadrul@chromium.org

Change-Id: I92ac83e6ff596f270947a75956f760bef79017d8
Reviewed-on: https://chromium-review.googlesource.com/849656
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526889}
[modify] https://crrev.com/ac9200c08be2bfba29ff4d09147a0acd4c5c2c59/content/browser/renderer_host/render_widget_host_view_browsertest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a687ee24d5aadf39cdee3842b023ba9aa64ff72f

commit a687ee24d5aadf39cdee3842b023ba9aa64ff72f
Author: Scott Violet <sky@chromium.org>
Date: Fri Jan 05 19:46:10 2018

chromeos: adds content_unittest and unit_tests --mus to main waterfall

As well as removing the filter file for 'content_browser_tests
--mus'. All of these have been running on the mojo fyi bot without
failure.

BUG= 785536 , 776514 
TEST=test only changes

Change-Id: I387398f87b5726c736634588477d85ab737e1c42
Reviewed-on: https://chromium-review.googlesource.com/850721
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527349}
[modify] https://crrev.com/a687ee24d5aadf39cdee3842b023ba9aa64ff72f/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/a687ee24d5aadf39cdee3842b023ba9aa64ff72f/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/a687ee24d5aadf39cdee3842b023ba9aa64ff72f/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/a687ee24d5aadf39cdee3842b023ba9aa64ff72f/testing/buildbot/filters/BUILD.gn
[delete] https://crrev.com/15d7d35c2470c8e276046790fc41d8969419f11e/testing/buildbot/filters/mus.content_browsertests.filter
[modify] https://crrev.com/a687ee24d5aadf39cdee3842b023ba9aa64ff72f/testing/buildbot/test_suites.pyl

Comment 7 by sky@chromium.org, Jan 5 2018

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24c4b23994a4d653353dad5818dd626908140e8f

commit 24c4b23994a4d653353dad5818dd626908140e8f
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Mon Jan 08 04:39:43 2018

Revert "chromeos: adds content_unittest and unit_tests --mus to main waterfall"

This reverts commit a687ee24d5aadf39cdee3842b023ba9aa64ff72f.

Reason for revert: This caused test shards to start timing out: https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/25560

Original change's description:
> chromeos: adds content_unittest and unit_tests --mus to main waterfall
> 
> As well as removing the filter file for 'content_browser_tests
> --mus'. All of these have been running on the mojo fyi bot without
> failure.
> 
> BUG= 785536 , 776514 
> TEST=test only changes
> 
> Change-Id: I387398f87b5726c736634588477d85ab737e1c42
> Reviewed-on: https://chromium-review.googlesource.com/850721
> Commit-Queue: Scott Violet <sky@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#527349}

TBR=sky@chromium.org,kbr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  785536 ,  776514 
Change-Id: I4bc5da6ebcf1dee8bbc98c2a028e06e50e303c53
Reviewed-on: https://chromium-review.googlesource.com/852601
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527568}
[modify] https://crrev.com/24c4b23994a4d653353dad5818dd626908140e8f/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/24c4b23994a4d653353dad5818dd626908140e8f/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/24c4b23994a4d653353dad5818dd626908140e8f/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/24c4b23994a4d653353dad5818dd626908140e8f/testing/buildbot/filters/BUILD.gn
[add] https://crrev.com/24c4b23994a4d653353dad5818dd626908140e8f/testing/buildbot/filters/mus.content_browsertests.filter
[modify] https://crrev.com/24c4b23994a4d653353dad5818dd626908140e8f/testing/buildbot/test_suites.pyl

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d268d267d4cde92013a5189033ec61ff47d2625

commit 8d268d267d4cde92013a5189033ec61ff47d2625
Author: Scott Violet <sky@chromium.org>
Date: Tue Jan 09 16:16:39 2018

reland: chromeos: adds content_unittest and unit_tests --mus to main waterfall

As well as removing the filter file for 'content_browser_tests
--mus'. All of these have been running on the mojo fyi bot without
failure.

BUG= 785536 , 776514 
TEST=test only changes

Change-Id: I10a7f7e6d257ec2fbb42793e4b607248ec91ae68
Reviewed-on: https://chromium-review.googlesource.com/854724
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528012}
[modify] https://crrev.com/8d268d267d4cde92013a5189033ec61ff47d2625/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/8d268d267d4cde92013a5189033ec61ff47d2625/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/8d268d267d4cde92013a5189033ec61ff47d2625/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/8d268d267d4cde92013a5189033ec61ff47d2625/testing/buildbot/filters/BUILD.gn
[delete] https://crrev.com/fd8e1c8da7222a1ac2391d2e7504bca3e3df0453/testing/buildbot/filters/mus.content_browsertests.filter
[modify] https://crrev.com/8d268d267d4cde92013a5189033ec61ff47d2625/testing/buildbot/test_suites.pyl

Sign in to add a comment