New issue
Advanced search Search tips

Issue 785535 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Move WebFormElementObserver out of PasswordManager

Project Member Reported by michaelbai@chromium.org, Nov 15 2017

Issue description

Currently it is in third_party/WebKit/public/web/modules/password_manager/, since WebFormElementObserver is shared between PasswordManager and autofill, we should change the directory to third_party/WebKit/public/web/modules/autofill. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e70c27817a18bf99c31ef3d1dae29f605e601c1

commit 5e70c27817a18bf99c31ef3d1dae29f605e601c1
Author: Tao Bai <michaelbai@chromium.org>
Date: Thu Feb 22 05:54:53 2018

Move WebFormElementObserver to autofill component

Also accept WebFormControlElement as element to be observed,
because we will start to observe select control.

Bug: 785535,785531
Change-Id: I725f907ffc88ab106fdaa8cfdd4c00f0dfa662cf
Reviewed-on: https://chromium-review.googlesource.com/923002
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538361}
[modify] https://crrev.com/5e70c27817a18bf99c31ef3d1dae29f605e601c1/components/autofill/content/renderer/form_tracker.cc
[modify] https://crrev.com/5e70c27817a18bf99c31ef3d1dae29f605e601c1/third_party/WebKit/Source/core/exported/WebFormElementObserverImpl.cpp
[modify] https://crrev.com/5e70c27817a18bf99c31ef3d1dae29f605e601c1/third_party/WebKit/Source/core/exported/WebFormElementObserverImpl.h
[add] https://crrev.com/5e70c27817a18bf99c31ef3d1dae29f605e601c1/third_party/WebKit/public/web/modules/autofill/OWNERS
[rename] https://crrev.com/5e70c27817a18bf99c31ef3d1dae29f605e601c1/third_party/WebKit/public/web/modules/autofill/WebFormElementObserver.h
[rename] https://crrev.com/5e70c27817a18bf99c31ef3d1dae29f605e601c1/third_party/WebKit/public/web/modules/autofill/WebFormElementObserverCallback.h
[delete] https://crrev.com/5411c8716cd8cc35880a5d9c54d95f18502a60da/third_party/WebKit/public/web/modules/password_manager/OWNERS

Sign in to add a comment