New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 785532 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 716609



Sign in to add a comment

Task manager does not reflect renderers kept alive by service workers.

Project Member Reported by erikc...@chromium.org, Nov 15 2017

Issue description

macOS, ToT [d1054682ea0b2d1ff303f10a06a5eea374a2b532]

Repro steps: 
1) Launch chrome with a clean profile. [ntp is loaded]
2) Close the window [thus, theoretically, destroying the renderer]

Observe: The renderer is no longer present in the task manager list, but the process is still present. This is because the process is kept alive by a service worker.
 
Screen Shot 2017-11-15 at 3.02.12 PM.png
29.0 KB View Download
Screen Shot 2017-11-15 at 3.02.16 PM.png
26.0 KB View Download
Screen Shot 2017-11-15 at 3.02.21 PM.png
193 KB View Download
Furthermore, the content::NOTIFICATION_RENDERER_PROCESS_TERMINATED notification is sent, but content::NOTIFICATION_RENDERER_PROCESS_CLOSED is never sent. This seems like another bug.

+ avi, content owner, to confirm that "NOTIFICATION_RENDERER_PROCESS_CLOSED" should be called.
Cc: a...@chromium.org
+ avi, actually this time.

Hm, it looks like if we cannot fast kill the renderer process, then the RPH is destroyed [causing a NOTIFICATION_RENDERER_PROCESS_TERMINATED notification.], and nothing is around to listen for the process death and send the NOTIFICATION_RENDERER_PROCESS_CLOSED notification.

Comment 3 by falken@chromium.org, Nov 16 2017

Blockedon: 716609
Components: UI>TaskManager
There is also ongoing work to show service workers themselves in the task manager: issue 716609.

Would fixing issue 716609 solve this automatically, or do we have an additional bug with the notification type?
The fact that NOTIFICATION_RENDERER_PROCESS_CLOSED isn't sent all the time seems more like a bug of the implementation of RPH itself [or at least the documentation could use some revising]. I don't believe there's any problem specific to service workers. 

Comment 5 by horo@chromium.org, Nov 16 2017

Owner: nick@chromium.org
Status: Assigned (was: Untriaged)
nick@
Please feel free to merge this issue to the issue 716609.
Owner: ----

Sign in to add a comment