New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 785502 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Browser crashes if response interception when body is not fully received yet and continued without change

Project Member Reported by allada@chromium.org, Nov 15 2017

Issue description

If a resource is still being downloaded and response interception is enabled and we continue the request without change it will crash browser.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1948b8ca8a3737fb72c8721af0cce63f6fd2cd7b

commit 1948b8ca8a3737fb72c8721af0cce63f6fd2cd7b
Author: Nathan Bruer <allada@chromium.org>
Date: Fri Nov 17 08:51:42 2017

[Devtools] Fixed crashes in response interception

Fixes some crashes in response interception when stop intercepting, data
urls get intercepted, and response body ready and notify headers gets
called.

R=caseq
BUG= 785502 

Change-Id: I3eb66f1eec23a630bb60f719cda6c59068d717ba
Reviewed-on: https://chromium-review.googlesource.com/774358
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517345}
[modify] https://crrev.com/1948b8ca8a3737fb72c8721af0cce63f6fd2cd7b/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/1948b8ca8a3737fb72c8721af0cce63f6fd2cd7b/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/1948b8ca8a3737fb72c8721af0cce63f6fd2cd7b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-response-no-change-expected.txt
[add] https://crrev.com/1948b8ca8a3737fb72c8721af0cce63f6fd2cd7b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-response-interception-disable-between-expected.txt
[add] https://crrev.com/1948b8ca8a3737fb72c8721af0cce63f6fd2cd7b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-response-interception-disable-between.js
[add] https://crrev.com/1948b8ca8a3737fb72c8721af0cce63f6fd2cd7b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/response-interception-cancel-xhr-while-responding-error-expected.txt
[add] https://crrev.com/1948b8ca8a3737fb72c8721af0cce63f6fd2cd7b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/response-interception-cancel-xhr-while-responding-error.js
[add] https://crrev.com/1948b8ca8a3737fb72c8721af0cce63f6fd2cd7b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/response-interception-no-change-content-not-ready-expected.txt
[add] https://crrev.com/1948b8ca8a3737fb72c8721af0cce63f6fd2cd7b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/response-interception-no-change-content-not-ready.js
[add] https://crrev.com/1948b8ca8a3737fb72c8721af0cce63f6fd2cd7b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/response-interception-request-completes-network-closes-expected.txt
[add] https://crrev.com/1948b8ca8a3737fb72c8721af0cce63f6fd2cd7b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/response-interception-request-completes-network-closes.js
[add] https://crrev.com/1948b8ca8a3737fb72c8721af0cce63f6fd2cd7b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/response-interception-with-data-url-expected.txt
[add] https://crrev.com/1948b8ca8a3737fb72c8721af0cce63f6fd2cd7b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/response-interception-with-data-url.js

Comment 2 by allada@chromium.org, Nov 17 2017

Status: Fixed (was: Assigned)

Sign in to add a comment