New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 785494 link

Starred by 1 user
Status: Fixed
Owner:
█ lgar...@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Bug
Team-Security-UX

Blocked on:
issue 752376


Sign in to add a comment

Rename to ChromeControllerClient to SSLErrorControllerClient and move to //c/b/ssl

Project Member Reported by lgar...@chromium.org, Nov 15 2017 
From: chrome/browser/interstitials/chrome_controller_client.{cc, h}
To: chrome/browser/ssl/ssl_error_controller_client.{cc, h}
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b717e1753ce5376a10a0610d23b3285f4b410ac

commit 7b717e1753ce5376a10a0610d23b3285f4b410ac
Author: Lucas Garron <lgarron@chromium.org>
Date: Thu Nov 16 11:39:59 2017

Rename ChromeControllerClient to SSLErrorControllerClient and move to //chrome/browser/ssl

TBR=nparker@chromium.org

Bug:  785494 
Change-Id: I4962501edae4815c60c4d00107053ee6f577639a
Reviewed-on: https://chromium-review.googlesource.com/773281
Commit-Queue: Lucas Garron <lgarron@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517059}
[modify] https://crrev.com/7b717e1753ce5376a10a0610d23b3285f4b410ac/chrome/browser/BUILD.gn
[modify] https://crrev.com/7b717e1753ce5376a10a0610d23b3285f4b410ac/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
[modify] https://crrev.com/7b717e1753ce5376a10a0610d23b3285f4b410ac/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
[modify] https://crrev.com/7b717e1753ce5376a10a0610d23b3285f4b410ac/chrome/browser/ssl/bad_clock_blocking_page.cc
[modify] https://crrev.com/7b717e1753ce5376a10a0610d23b3285f4b410ac/chrome/browser/ssl/captive_portal_blocking_page.cc
[modify] https://crrev.com/7b717e1753ce5376a10a0610d23b3285f4b410ac/chrome/browser/ssl/mitm_software_blocking_page.cc
[modify] https://crrev.com/7b717e1753ce5376a10a0610d23b3285f4b410ac/chrome/browser/ssl/ssl_blocking_page.cc
[rename] https://crrev.com/7b717e1753ce5376a10a0610d23b3285f4b410ac/chrome/browser/ssl/ssl_error_controller_client.cc
[rename] https://crrev.com/7b717e1753ce5376a10a0610d23b3285f4b410ac/chrome/browser/ssl/ssl_error_controller_client.h

Comment 2 by est...@chromium.org, Dec 1 2017

Status: Fixed (was: Started)
►

Sign in to add a comment