New issue
Advanced search Search tips

Issue 785493 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Accessibility


Show other hotlists

Hotlists containing this issue:
Hotlist-2


Sign in to add a comment

Make it easier to debug native Chrome UI accessibility

Project Member Reported by dmazz...@chromium.org, Nov 15 2017

Issue description

We need more tools to help us debug native Chrome UI accessibility just like we can debug web accessibility.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35753f614a9fe0623c2cd778c8084156d153b0a4

commit 35753f614a9fe0623c2cd778c8084156d153b0a4
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Mon Nov 20 18:43:31 2017

Make the Accessibility WebUI page use a WebUIMessageHandler.

No user-visible change, just modernizing the code behind the
chrome://accessibility Accessibility Internals page.
We were calling CallJavascriptFunctionUnsafe, which was unsafe because
the page might not have been ready. Switch to using a WebUIMessageHandler
so we can call AllowJavascript() when we get a message from the page,
indicating we're sure it's ready, then future calls to CallJavascriptFunction
will succeed. See https://goo.gl/qivavq for details.

Bug: 785493
Change-Id: I1623aae2be16b968ae8d7b17058348980637f02c
Reviewed-on: https://chromium-review.googlesource.com/772876
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517869}
[modify] https://crrev.com/35753f614a9fe0623c2cd778c8084156d153b0a4/content/browser/accessibility/accessibility_ui.cc
[modify] https://crrev.com/35753f614a9fe0623c2cd778c8084156d153b0a4/content/browser/accessibility/accessibility_ui.h

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc964cce409c21ceb8dba99c94ee9256b0a16c8b

commit bc964cce409c21ceb8dba99c94ee9256b0a16c8b
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Tue Nov 21 03:22:06 2017

Allow Accessibility Internals to show native UI

On platforms that use Views for native UI, enable chrome://accessibility
to also display a text dump of the native accessibility tree, which we can
use to aid in debugging native accessibility.

Bug: 785493
Change-Id: If7baa9bf28c4d0c8a5c2be3d9cc185627bbbb475
Reviewed-on: https://chromium-review.googlesource.com/772786
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518071}
[modify] https://crrev.com/bc964cce409c21ceb8dba99c94ee9256b0a16c8b/content/browser/accessibility/accessibility_ui.cc
[modify] https://crrev.com/bc964cce409c21ceb8dba99c94ee9256b0a16c8b/content/browser/accessibility/accessibility_ui.h
[modify] https://crrev.com/bc964cce409c21ceb8dba99c94ee9256b0a16c8b/content/browser/resources/accessibility/accessibility.html
[modify] https://crrev.com/bc964cce409c21ceb8dba99c94ee9256b0a16c8b/content/browser/resources/accessibility/accessibility.js
[modify] https://crrev.com/bc964cce409c21ceb8dba99c94ee9256b0a16c8b/ui/accessibility/platform/ax_platform_node.cc
[modify] https://crrev.com/bc964cce409c21ceb8dba99c94ee9256b0a16c8b/ui/accessibility/platform/ax_platform_node.h
[modify] https://crrev.com/bc964cce409c21ceb8dba99c94ee9256b0a16c8b/ui/views/accessibility/native_view_accessibility_base.cc

 Issue 645130  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9df875a4967dc3cf499dfa879ac8b28148fb8174

commit 9df875a4967dc3cf499dfa879ac8b28148fb8174
Author: James Wallace-Lee <jamwalla@chromium.org>
Date: Fri Jul 27 18:13:32 2018

chrome://accessibility: Show native UI AX tree for all windows

Show the native UI's accessibility tree for all open chrome windows
in chrome://accessibility

Change-Id: I119ac76f406010b9b2711de845aa3ace7ef69f5f
Bug: 785493
Reviewed-on: https://chromium-review.googlesource.com/1147511
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578709}
[modify] https://crrev.com/9df875a4967dc3cf499dfa879ac8b28148fb8174/chrome/browser/accessibility/accessibility_ui.cc
[modify] https://crrev.com/9df875a4967dc3cf499dfa879ac8b28148fb8174/chrome/browser/resources/accessibility/accessibility.js

Sign in to add a comment