Moblab M63 and M64 builder are failing in Hwtest - wget missing |
|||||||
Issue descriptionWHen running the HWTest for M63 / M64 guado_moblab the device fails to provision. From https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/156172597-chromeos-test/chromeos2-row2-rack8-host11/debug/ 11/14 23:04:57.279 DEBUG| ssh_host:0296| Running (ssh) '/tmp/stateful_update http://100.115.245.198:8082/static/guado_moblab-release/R63-10032.39.0 --stateful_change=clean 2>&1' from 'machine_install|run_update|update_stateful|_run|run|run_very_slowly' 11/14 23:04:57.502 DEBUG| utils:0280| [stdout] Downloading stateful payload from http://100.115.245.198:8082/static/guado_moblab-release/R63-10032.39.0/stateful.tgz 11/14 23:04:57.504 DEBUG| utils:0280| [stdout] /tmp/stateful_update: 1: eval: wget: not found 11/14 23:04:57.520 DEBUG| utils:0280| [stdout] 11/14 23:04:57.521 DEBUG| utils:0280| [stdout] gzip: stdin: unexpected end of file 11/14 23:04:57.521 DEBUG| utils:0280| [stdout] tar: Child returned status 1 11/14 23:04:57.521 DEBUG| utils:0280| [stdout] tar: Error is not recoverable: exiting now 11/14 23:04:57.521 DEBUG| utils:0280| [stdout] Downloading command returns code 2. 11/14 23:04:57.521 DEBUG| utils:0280| [stdout] Downloading failed, retrying. 11/14 23:04:57.522 DEBUG| utils:0280| [stdout] /tmp/stateful_update: 1: eval: wget: not found 11/14 23:04:57.523 DEBUG| utils:0280| [stdout] 11/14 23:04:57.524 DEBUG| utils:0280| [stdout] gzip: stdin: unexpected end of file 11/14 23:04:57.524 DEBUG| utils:0280| [stdout] tar: Child returned status 1 11/14 23:04:57.524 DEBUG| utils:0280| [stdout] tar: Error is not recoverable: exiting now 11/14 23:04:57.526 DEBUG| utils:0280| [stdout] Downloading command returns code 2.
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/dev-util/+/431d3aca8bccc38d2affebc1d8c975b2c2db16d5 commit 431d3aca8bccc38d2affebc1d8c975b2c2db16d5 Author: Keith Haddow <haddowk@chromium.org> Date: Thu Nov 16 06:37:47 2017 [platform] Move the stateful update from wget to curl wget is removed from the rootfs crbug.com/781538 change the stateful update to use curl rather than wget BUG= chromium:785487 TEST=ran unittests, will run trybot job before submit. Change-Id: I0afc1b3e3f9520cc20f8ff65d38712b4957e010b Reviewed-on: https://chromium-review.googlesource.com/773114 Commit-Ready: Keith Haddow <haddowk@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: David Riley <davidriley@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/431d3aca8bccc38d2affebc1d8c975b2c2db16d5/stateful_update
,
Nov 27 2017
Hooray! This change also fixes bug 622129 .
,
Nov 27 2017
This fix did not completely fix the builders - we had to change some infra configuration as well https://chrome-internal-review.googlesource.com/#/c/chromeos/chromeos-admin/+/509975/
,
Jan 22 2018
,
Jan 23 2018
,
Feb 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/dev-util/+/06b343621d7249ab20e7f88fae453e6ec04bdd81 commit 06b343621d7249ab20e7f88fae453e6ec04bdd81 Author: Keith Haddow <haddowk@chromium.org> Date: Sat Feb 03 00:24:42 2018 [platform] Move the stateful update from wget to curl wget is removed from the rootfs crbug.com/781538 change the stateful update to use curl rather than wget BUG= chromium:785487 TEST=ran unittests, will run trybot job before submit. Change-Id: I0afc1b3e3f9520cc20f8ff65d38712b4957e010b Reviewed-on: https://chromium-review.googlesource.com/773114 Commit-Ready: Keith Haddow <haddowk@chromium.org> Tested-by: Keith Haddow <haddowk@chromium.org> Reviewed-by: David Riley <davidriley@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit 431d3aca8bccc38d2affebc1d8c975b2c2db16d5) Reviewed-on: https://chromium-review.googlesource.com/900265 Reviewed-by: Keith Haddow <haddowk@chromium.org> Commit-Queue: Keith Haddow <haddowk@chromium.org> Trybot-Ready: Keith Haddow <haddowk@chromium.org> [modify] https://crrev.com/06b343621d7249ab20e7f88fae453e6ec04bdd81/stateful_update
,
Feb 28 2018
Keith, You didn't actually fix the root cause with this change. I'm seeing the same issue on whirlwind-test-ap updates (and it's been an issue for a long time but no one looked.) See crbug.com/808288. wget is available on the offending machine (in /usr/local/bin) BUT I don't understand why the "eval" use of wget is failing to find /usr/local/bin $PATH. By modifying the script to use /usr/local/bin/wget, it seems to work fine. Using "curl" doesn't change the underlying issue. Maybe someone else knows why $PATH isn't getting set when stateful_update is run. However, I'm also re-opening this bug since the gmerge ebuild RDEPENDS on wget, not on curl. Since "no good deed goes unpunished", can you please: 1) update the gmerge ebuild to RDEPEND on curl? 2) determine if nothing else in gmerge package is using wget? (ie consider removing RDEPEND on wget) $ equery-whirlwind b stateful_update * Searching for stateful_update ... chromeos-base/gmerge-0.0.1-r1085 (/usr/local/bin/stateful_update) $ equery-whirlwind w chromeos-base/gmerge /mnt/host/source/src/third_party/chromiumos-overlay/chromeos-base/gmerge/gmerge-0.0.1-r1088.ebuild RDEPEND="app-shells/bash dev-lang/python dev-util/shflags net-misc/wget sys-apps/portage" DEPEND="${RDEPEND}" $ equery-whirlwind b curl * Searching for curl ... net-misc/curl-7.57.0 (/usr/include/curl) net-misc/curl-7.57.0 (/usr/bin/curl)
,
Feb 28 2018
wget used to be installed in the rootfs. we changed it to only be in the dev/test images. curl on the other hand is in the rootfs. so changing things to use curl instead of wget is fine.
,
Feb 28 2018
Ok. Then just need to fix the RDEPENDS. I'll upload a CL for that if Keith doesn't object. My goal was primarily to make Keith aware the ebuilds specify runtime dependencies. Trying to use features/embedded has made me much more sensitive to that.
,
Feb 28 2018
No objection, I will keep a look out for RDEPENDS in the future.
,
Feb 28 2018
Excellent! I've uploaded: https://chromium-review.googlesource.com/#/c/chromiumos/overlays/chromiumos-overlay/+/941731 gmerge: replace wget with curl in REDEPENDS
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/2337c433716aaa05a8141f5589a1c545965d50f7 commit 2337c433716aaa05a8141f5589a1c545965d50f7 Author: Grant Grundler <grundler@chromium.org> Date: Fri Mar 02 08:11:54 2018 gmerge: replace wget with curl in REDEPENDS https://chromium-review.googlesource.com/773114 switch from wget to curl. Just updating the RDEPENDS to match. BUG= chromium:785487 TEST=no change to runtime since /usr/bin/curl is already present Change-Id: Ie61e0f49e4acd061d4bc0829d0e2daf80f8cc3a8 Reviewed-on: https://chromium-review.googlesource.com/941731 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Grant Grundler <grundler@chromium.org> Reviewed-by: Grant Grundler <grundler@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/2337c433716aaa05a8141f5589a1c545965d50f7/chromeos-base/gmerge/gmerge-9999.ebuild
,
Mar 2 2018
Looks like Grant's CL has landed marking as fixed. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by haddowk@chromium.org
, Nov 15 2017