crashpad_tests/MachOImageAnnotationsReader.CrashModuleInitialization fails on Mac ASan |
||
Issue descriptionSee https://build.chromium.org/p/chromium.clang/builders/ToTMacASan%20tester/builds/76 It seems we don't run crashpad_tests on the regular Mac ASan bot: https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/36052 Should they be added there? I'll disable the test in the meantime to green our bot.
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29e24b286d494a314dd067f303cc9212d0cadfe9 commit 29e24b286d494a314dd067f303cc9212d0cadfe9 Author: Hans Wennborg <hans@chromium.org> Date: Thu Nov 16 04:44:47 2017 Don't run crashpad_tests on MacASan tester The tests are currently failing, and since they don't seem to run on any non-ToT Mac ASan bots we probably shouldn't be running them either. Bug: 785479 Change-Id: I9f5e23ea545d3937fd2a6db0c25b5517ac05e5ef Reviewed-on: https://chromium-review.googlesource.com/772867 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#516989} [modify] https://crrev.com/29e24b286d494a314dd067f303cc9212d0cadfe9/testing/buildbot/chromium.clang.json
,
Nov 16 2017
Thanks. This test doesn’t need to be enabled there. We should (soon) get the tests running and passing under ASan, but it doesn’t have to be now. |
||
►
Sign in to add a comment |
||
Comment 1 by h...@chromium.org
, Nov 15 2017