New issue
Advanced search Search tips

Issue 785462 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 767344



Sign in to add a comment

buildset's revision of a CI build is ignored in builder view

Project Member Reported by tandrii@chromium.org, Nov 15 2017

Issue description

When I load today 
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20SANDBOX
I see
https://screenshot.googleplex.com/c0SJSsReUdj
which misses revisions of two green builds.
Here is one of them:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20SANDBOX/19
It does have 'got_revision' and buildset tag, but it doesn't have 'revision'. I guess that's the reason.

 

Comment 1 by no...@chromium.org, Nov 15 2017

Components: -Infra>Platform>Milo Infra>Platform>Milo>LUCI
Labels: -Pri-2 Pri-1

Comment 2 by no...@chromium.org, Nov 16 2017

Cc: efoo@chromium.org
Components: Infra>Platform>Buildbucket
Labels: LUCI-Blocker-M4
Andrii, this is a bug in the buildbucket module, not Milo. It should have copied buildsets over to the triggered build. Builder builds have buildset, Tester builds do not. If they did, Milo would render them (unless there is another bug).

I am actually not sure why this is happening. Buildbucket seems to copy buildset tag
https://cs.chromium.org/chromium/infra/recipes-py/recipe_modules/buildbucket/api.py?l=35
but I am not sure what is self.properties there... this needs investigation.

not removing milo component in case there is a bug in milo too

Comment 3 by no...@chromium.org, Nov 16 2017

Blocking: 767344
It's a MILO bug. From the tester build I linked to above, here is a copy of buildbucket property which contains buildset as expected:

{"build": {"bucket": "luci.chromium.ci", "created_by": "user:chromium-ci-builder@chops-service-accounts.iam.gserviceaccount.com", "created_ts": 1510716972704100, "id": "8962892155587783088", "tags": ["builder:Linux Tests SANDBOX",

"buildset:commit/gitiles/chromium.googlesource.com/chromium/src/+/33bf8a94dcd5e0abbdf83e4afaed24b5180e3eb2",

"parent_buildername:Linux Builder SANDBOX", "parent_buildnumber:871", "user_agent:recipe"]}, "hostname": "cr-buildbucket.appspot.com"}


I temporarily resolved it by setting 'revision' property, such that latest builds are processed by MILO.

Comment 5 by efoo@chromium.org, Nov 16 2017

Components: -Infra>Platform>Buildbucket
Is anyone taking a look at the Milo bug? 

Comment 6 by efoo@chromium.org, Nov 16 2017

Labels: LUCI-Blocker-UI

Comment 7 by efoo@chromium.org, Nov 16 2017

Labels: -LUCI-Blocker-UI

Comment 8 by efoo@chromium.org, Nov 21 2017

Labels: LUCI-KnownIssues-UI

Comment 9 by efoo@chromium.org, Nov 22 2017

Labels: LUCI-Blocker-UI
Labels: -LUCI-Blocker-UI -LUCI-KnownIssues-UI
Not buildbot related so removing UI blocker labels. (still needed for M4 though)

Comment 11 by efoo@chromium.org, Dec 5 2017

Labels: REQBY-LUCI-M4a-MacWinPOC LUCI-M0-Backlog

Comment 12 by efoo@chromium.org, Dec 20 2017

Labels: -REQBY-LUCI-M4a-MacWinPOC REQBY-LUCI-M4-Migrations

Comment 13 by efoo@chromium.org, Dec 20 2017

Labels: -REQBY-LUCI-M4-Migrations REQBY-LUCI-M4-Migration

Comment 14 by efoo@chromium.org, Jan 25 2018

Labels: luci-blocker-migration

Comment 15 by efoo@chromium.org, Jan 30 2018

Labels: -LUCI-Blocker-M4

Comment 16 by efoo@chromium.org, Jan 30 2018

Labels: LUCI-Backlog

Comment 17 by efoo@chromium.org, Jan 30 2018

Labels: -LUCI-M0-Backlog

Comment 18 by efoo@chromium.org, Jan 30 2018

Labels: LUCI-Migration

Comment 19 by efoo@chromium.org, Jan 30 2018

Labels: -REQBY-LUCI-M4-Migration

Comment 20 by efoo@chromium.org, Feb 13 2018

Labels: -LUCI-blocker-migration LUCI-Chromium LUCI-Blocker-Chromium

Comment 21 by efoo@chromium.org, Feb 13 2018

Labels: -LUCI-Migration

Comment 22 by efoo@chromium.org, Feb 13 2018

Labels: LUCI-Chromium-CQSets

Comment 23 by efoo@chromium.org, Feb 13 2018

Labels: -LUCI-Chromium-CQSets
Labels: -LUCI-Backlog -LUCI-Chromium -LUCI-Blocker-Chromium LUCI-Afterglow
Moved to afterglow
Cc: -iannucci@chromium.org iannu...@google.com

Sign in to add a comment