New issue
Advanced search Search tips

Issue 785436 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

Friendly announcements for omnibox suggestions

Project Member Reported by aleventhal@chromium.org, Nov 15 2017

Issue description

When arrowing through suggestions, users should hear the friendliest possible text for each suggestion.
- For urls, read the title first, then a friendly version of the URL (shortened a bit), then the type of match (from history, bookmarks, etc.)
- For searches, first read the search suggestion, and then whether it's from history or from a previous search
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8de2c83754afdab83ea81c7ff7aa95958a8832c8

commit 8de2c83754afdab83ea81c7ff7aa95958a8832c8
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Mon Nov 20 17:40:16 2017

Improvements to autocomplete suggestion announcements

Provide friendlier-sounding suggestions that are more efficient for screen reader use.

Bug:  785436 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ifbf93609bc274f445e8ae81cccb5cb60a705da2e
Reviewed-on: https://chromium-review.googlesource.com/772316
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517851}
[modify] https://crrev.com/8de2c83754afdab83ea81c7ff7aa95958a8832c8/chrome/app/generated_resources.grd
[modify] https://crrev.com/8de2c83754afdab83ea81c7ff7aa95958a8832c8/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
[modify] https://crrev.com/8de2c83754afdab83ea81c7ff7aa95958a8832c8/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
[modify] https://crrev.com/8de2c83754afdab83ea81c7ff7aa95958a8832c8/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/8de2c83754afdab83ea81c7ff7aa95958a8832c8/chrome/browser/ui/views/omnibox/omnibox_view_views.h
[modify] https://crrev.com/8de2c83754afdab83ea81c7ff7aa95958a8832c8/components/omnibox/browser/autocomplete_match_type.cc
[modify] https://crrev.com/8de2c83754afdab83ea81c7ff7aa95958a8832c8/components/omnibox/browser/autocomplete_match_type.h
[modify] https://crrev.com/8de2c83754afdab83ea81c7ff7aa95958a8832c8/components/omnibox/browser/autocomplete_match_type_unittest.cc
[modify] https://crrev.com/8de2c83754afdab83ea81c7ff7aa95958a8832c8/components/omnibox/browser/omnibox_edit_model.cc
[modify] https://crrev.com/8de2c83754afdab83ea81c7ff7aa95958a8832c8/components/omnibox/browser/omnibox_edit_unittest.cc
[modify] https://crrev.com/8de2c83754afdab83ea81c7ff7aa95958a8832c8/components/omnibox/browser/omnibox_view.h
[modify] https://crrev.com/8de2c83754afdab83ea81c7ff7aa95958a8832c8/components/omnibox_strings.grdp
[modify] https://crrev.com/8de2c83754afdab83ea81c7ff7aa95958a8832c8/ios/chrome/browser/ui/omnibox/omnibox_view_ios.h
[modify] https://crrev.com/8de2c83754afdab83ea81c7ff7aa95958a8832c8/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm
[modify] https://crrev.com/8de2c83754afdab83ea81c7ff7aa95958a8832c8/tools/gritsettings/startup_resources_mac.txt

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c1be31aca687c00e21ad7d3f8522e06a8d10875

commit 2c1be31aca687c00e21ad7d3f8522e06a8d10875
Author: Carlos Knippschild <carlosk@chromium.org>
Date: Mon Nov 20 19:25:24 2017

Revert "Improvements to autocomplete suggestion announcements"

This reverts commit 8de2c83754afdab83ea81c7ff7aa95958a8832c8.

Reason for revert:
Likely causing consistent failures in "Mac10.9 Tests (dbg)".
See: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/47340

Original change's description:
> Improvements to autocomplete suggestion announcements
> 
> Provide friendlier-sounding suggestions that are more efficient for screen reader use.
> 
> Bug:  785436 
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: Ifbf93609bc274f445e8ae81cccb5cb60a705da2e
> Reviewed-on: https://chromium-review.googlesource.com/772316
> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Reviewed-by: Bret Sepulveda <bsep@chromium.org>
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517851}

TBR=ellyjones@chromium.org,flackr@chromium.org,jdonnelly@chromium.org,justincohen@chromium.org,rsesek@chromium.org,bsep@chromium.org,aleventhal@chromium.org

Change-Id: I31d7e24d7d7e9c2874763c27e4ecd53f349cdaaa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  785436 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/779920
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517887}
[modify] https://crrev.com/2c1be31aca687c00e21ad7d3f8522e06a8d10875/chrome/app/generated_resources.grd
[modify] https://crrev.com/2c1be31aca687c00e21ad7d3f8522e06a8d10875/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
[modify] https://crrev.com/2c1be31aca687c00e21ad7d3f8522e06a8d10875/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
[modify] https://crrev.com/2c1be31aca687c00e21ad7d3f8522e06a8d10875/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/2c1be31aca687c00e21ad7d3f8522e06a8d10875/chrome/browser/ui/views/omnibox/omnibox_view_views.h
[modify] https://crrev.com/2c1be31aca687c00e21ad7d3f8522e06a8d10875/components/omnibox/browser/autocomplete_match_type.cc
[modify] https://crrev.com/2c1be31aca687c00e21ad7d3f8522e06a8d10875/components/omnibox/browser/autocomplete_match_type.h
[modify] https://crrev.com/2c1be31aca687c00e21ad7d3f8522e06a8d10875/components/omnibox/browser/autocomplete_match_type_unittest.cc
[modify] https://crrev.com/2c1be31aca687c00e21ad7d3f8522e06a8d10875/components/omnibox/browser/omnibox_edit_model.cc
[modify] https://crrev.com/2c1be31aca687c00e21ad7d3f8522e06a8d10875/components/omnibox/browser/omnibox_edit_unittest.cc
[modify] https://crrev.com/2c1be31aca687c00e21ad7d3f8522e06a8d10875/components/omnibox/browser/omnibox_view.h
[modify] https://crrev.com/2c1be31aca687c00e21ad7d3f8522e06a8d10875/components/omnibox_strings.grdp
[modify] https://crrev.com/2c1be31aca687c00e21ad7d3f8522e06a8d10875/ios/chrome/browser/ui/omnibox/omnibox_view_ios.h
[modify] https://crrev.com/2c1be31aca687c00e21ad7d3f8522e06a8d10875/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm
[modify] https://crrev.com/2c1be31aca687c00e21ad7d3f8522e06a8d10875/tools/gritsettings/startup_resources_mac.txt

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe5e4e13bb8f9bbdcf7e0a645fbede1623b91d33

commit fe5e4e13bb8f9bbdcf7e0a645fbede1623b91d33
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Mon Nov 20 23:26:44 2017

Improvements to autocomplete suggestion announcements (reland)

Provide friendlier-sounding suggestions that are more efficient for screen reader use.

TBR=Robert Sesek <rsesek@chromium.org>, Robert Flack <flackr@chromium.org>, Justin Cohen <justincohen@chromium.org>, Bret Sepulveda <bsep@chromium.org>, Elly Fong-Jones <ellyjones@chromium.org>, Justin Donnelly <jdonnelly@chromium.org>

Bug:  785436 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id8e7ed1b04cb8e526af99f7d7b946f5d73583304
Reviewed-on: https://chromium-review.googlesource.com/780239
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517984}
[modify] https://crrev.com/fe5e4e13bb8f9bbdcf7e0a645fbede1623b91d33/chrome/app/generated_resources.grd
[modify] https://crrev.com/fe5e4e13bb8f9bbdcf7e0a645fbede1623b91d33/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
[modify] https://crrev.com/fe5e4e13bb8f9bbdcf7e0a645fbede1623b91d33/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
[modify] https://crrev.com/fe5e4e13bb8f9bbdcf7e0a645fbede1623b91d33/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/fe5e4e13bb8f9bbdcf7e0a645fbede1623b91d33/chrome/browser/ui/views/omnibox/omnibox_view_views.h
[modify] https://crrev.com/fe5e4e13bb8f9bbdcf7e0a645fbede1623b91d33/components/omnibox/browser/autocomplete_match_type.cc
[modify] https://crrev.com/fe5e4e13bb8f9bbdcf7e0a645fbede1623b91d33/components/omnibox/browser/autocomplete_match_type.h
[modify] https://crrev.com/fe5e4e13bb8f9bbdcf7e0a645fbede1623b91d33/components/omnibox/browser/autocomplete_match_type_unittest.cc
[modify] https://crrev.com/fe5e4e13bb8f9bbdcf7e0a645fbede1623b91d33/components/omnibox/browser/omnibox_edit_model.cc
[modify] https://crrev.com/fe5e4e13bb8f9bbdcf7e0a645fbede1623b91d33/components/omnibox/browser/omnibox_edit_unittest.cc
[modify] https://crrev.com/fe5e4e13bb8f9bbdcf7e0a645fbede1623b91d33/components/omnibox/browser/omnibox_view.h
[modify] https://crrev.com/fe5e4e13bb8f9bbdcf7e0a645fbede1623b91d33/components/omnibox_strings.grdp
[modify] https://crrev.com/fe5e4e13bb8f9bbdcf7e0a645fbede1623b91d33/ios/chrome/browser/ui/omnibox/omnibox_view_ios.h
[modify] https://crrev.com/fe5e4e13bb8f9bbdcf7e0a645fbede1623b91d33/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm
[modify] https://crrev.com/fe5e4e13bb8f9bbdcf7e0a645fbede1623b91d33/tools/gritsettings/startup_resources_mac.txt

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9de1bfb85bd46a941c9d2c8e276511063202119

commit c9de1bfb85bd46a941c9d2c8e276511063202119
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Tue Dec 05 19:00:01 2017

Omnibox suggestions that are friendly to non-Mac screen readers

Provide friendly-sounding suggestions that are more efficient for screen reader use.
For example, read the title of a document before the URL. An example of a friendly
suggestion would be "Gmail https://mail.google.com location from history".

In order to get the friendly suggestions to be announce or shown on a Braille display,
the textfield's accessible text value is replaced with the friendly text, rather than
containing the URL only. If the user begins to edit the text or arrow through it, the
accessible text/value is returned to the plain URL or search text.

In addition, incoming and outgoing cursor/selection offsets are corrected so that
assistive technologies can set the location of the cursor (for cursor routing),
or retrieve the actual text at the current caret position. The caret/selection
indices are offset by the amount of friendly text inserted before the actual
text being shown in the text box.

Bug:  785436 
Change-Id: I7fb9071c2df1a4ab188bc8e7b7001396578b1950
Reviewed-on: https://chromium-review.googlesource.com/784591
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521769}
[modify] https://crrev.com/c9de1bfb85bd46a941c9d2c8e276511063202119/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/c9de1bfb85bd46a941c9d2c8e276511063202119/chrome/browser/ui/views/omnibox/omnibox_view_views.h
[modify] https://crrev.com/c9de1bfb85bd46a941c9d2c8e276511063202119/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc
[modify] https://crrev.com/c9de1bfb85bd46a941c9d2c8e276511063202119/components/omnibox/browser/autocomplete_match_type.cc
[modify] https://crrev.com/c9de1bfb85bd46a941c9d2c8e276511063202119/components/omnibox/browser/autocomplete_match_type.h

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment