Review AppCompatResources usage |
|||
Issue descriptionA few components pull dependencies on the v7_appcompat support library only to use AppCompatResources#getDrawable. //base has as similar utility with ApiCompatibilityUtils#getDrawable, and does not pull in a dependency on a big external library. If possible (no vector drawables involved, theme attributes unnecessary), we should use the utility from //base instead Context: - g/support-lib-discuss/Dux2VDpwoCI - issue 780175 Usage that got flagged in the above context: - //ui/android/../DropdownAdapter.java - //components/autofill/../AutofillKeyboardAccessory.java
,
Nov 16 2017
Longer term, I'd like to actually delete our ApiCompatibilityUtils version and rely solely on AppCompatResources. Our mismatched usage of AppCompat I think is very error prone. I understand the need for a short term fix, but I think we should push hard (as you have started) for the appcompat team to allow this dependency to not be so huge.
,
Nov 17 2017
Logging status: The pending CL was crrev.com/c/774864, but we need another API that would allow to load vectors to be able to remove the big dependency.
,
Dec 18 2017
We currently can't get rid of AppCompatResources, so if we want to do something it will be still waiting on v7_appcompat to be split in smaller chunks. Not much to be done on our end. Closing. |
|||
►
Sign in to add a comment |
|||
Comment 1 by dgn@chromium.org
, Nov 16 2017