New issue
Advanced search Search tips

Issue 785430 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 805566
Owner:
Closed: Oct 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Test the use counter for kPerformanceMeasurePassedInObject

Project Member Reported by maxlg@google.com, Nov 15 2017

Issue description

While adding the histogram of Performance.PerformanceMeasurePassedInParameter.StartMark, Performance.PerformanceMeasurePassedInParameter.EndMark, and user counter of kPerformanceMeasurePassedInObject (crbug/783960), we didn't test the user counter of kPerformanceMeasurePassedInObject since it needs to simulate the page-load somehow to create the use-counter histogram.

But, we still need a test for it.
 

Comment 1 by maxlg@google.com, Nov 15 2017

Description: Show this description
Alternatively, we could just deprecate the use counter - we've gotten the value out of it that we need.

Comment 3 by maxlg@google.com, Mar 2 2018

Sounds good to me.
Ping re deprecating this (eventually).
Hey Max - CSM triage here. Any update on this? Looks like there's consensus on deprecation?
Mergedinto: 805566
Status: Duplicate (was: Assigned)
I've fixed it in https://chromium-review.googlesource.com/c/chromium/src/+/1059581

Sign in to add a comment