New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 785420 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 753658
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 598073



Sign in to add a comment

Migrate network service code from //content to //services/network

Project Member Reported by rdsmith@chromium.org, Nov 15 2017

Issue description

Much network service code is currently in content (specifically in content/public/{common,network}, content/network).  Most of it is not dependent on other efforts and can be migrated to //services/network.  "Wrapper" code that needs to be called directly can be placed in //services/network/public/cpp.  All interfaces can be placed in //services/network/public/interfaces--that does not interfere with either their use or generation from content code.

The major blockers for this effort are data types that the Mojo interfaces in content depend on.  A very incomplete list includes:
* SSLInfo (uses IPC serialization/de-serializatino)
* resource_request_body, which has a dependence on storage/common/data_element.h and tentatively relies on some blog code.
* ResourceResponseHead uses previews and dev tools.


 

Comment 1 by jam@chromium.org, Nov 15 2017

Blocking: 598073
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4641052a9c883401ae376853069bce0588df6fa

commit e4641052a9c883401ae376853069bce0588df6fa
Author: Randy Smith <rdsmith@chromium.org>
Date: Tue Nov 21 17:38:59 2017

Moved NetworkChangeManager service definition to //services/network

Bug:  785420 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I84bf1a42081c4890f8641a56a9cdb87404e25f67
Reviewed-on: https://chromium-review.googlesource.com/772938
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518291}
[modify] https://crrev.com/e4641052a9c883401ae376853069bce0588df6fa/chrome/browser/BUILD.gn
[modify] https://crrev.com/e4641052a9c883401ae376853069bce0588df6fa/chrome/browser/net/network_connection_tracker_browsertest.cc
[modify] https://crrev.com/e4641052a9c883401ae376853069bce0588df6fa/chrome/browser/signin/chrome_signin_client.cc
[modify] https://crrev.com/e4641052a9c883401ae376853069bce0588df6fa/chrome/browser/signin/chrome_signin_client.h
[modify] https://crrev.com/e4641052a9c883401ae376853069bce0588df6fa/chrome/browser/signin/chrome_signin_client_unittest.cc
[modify] https://crrev.com/e4641052a9c883401ae376853069bce0588df6fa/chrome/test/base/testing_browser_process.cc
[modify] https://crrev.com/e4641052a9c883401ae376853069bce0588df6fa/content/network/DEPS
[modify] https://crrev.com/e4641052a9c883401ae376853069bce0588df6fa/content/network/network_change_manager.cc
[modify] https://crrev.com/e4641052a9c883401ae376853069bce0588df6fa/content/network/network_change_manager.h
[modify] https://crrev.com/e4641052a9c883401ae376853069bce0588df6fa/content/network/network_change_manager_unittest.cc
[modify] https://crrev.com/e4641052a9c883401ae376853069bce0588df6fa/content/network/network_service_impl.cc
[modify] https://crrev.com/e4641052a9c883401ae376853069bce0588df6fa/content/network/network_service_impl.h
[modify] https://crrev.com/e4641052a9c883401ae376853069bce0588df6fa/content/network/network_service_unittest.cc
[modify] https://crrev.com/e4641052a9c883401ae376853069bce0588df6fa/content/public/common/BUILD.gn
[modify] https://crrev.com/e4641052a9c883401ae376853069bce0588df6fa/content/public/common/network_connection_tracker.cc
[modify] https://crrev.com/e4641052a9c883401ae376853069bce0588df6fa/content/public/common/network_connection_tracker.h
[modify] https://crrev.com/e4641052a9c883401ae376853069bce0588df6fa/content/public/common/network_connection_tracker_unittest.cc
[modify] https://crrev.com/e4641052a9c883401ae376853069bce0588df6fa/content/public/common/network_service.mojom
[modify] https://crrev.com/e4641052a9c883401ae376853069bce0588df6fa/content/public/common/network_service_test.mojom
[modify] https://crrev.com/e4641052a9c883401ae376853069bce0588df6fa/content/public/test/network_service_test_helper.cc
[modify] https://crrev.com/e4641052a9c883401ae376853069bce0588df6fa/services/network/public/interfaces/BUILD.gn
[rename] https://crrev.com/e4641052a9c883401ae376853069bce0588df6fa/services/network/public/interfaces/network_change_manager.mojom

Comment 3 by falken@chromium.org, Nov 30 2017

Description: Show this description
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c57342548c713379572cad67d74cd02daa9679bc

commit c57342548c713379572cad67d74cd02daa9679bc
Author: Randy Smith <rdsmith@chromium.org>
Date: Wed Dec 06 02:37:55 2017

Moved SSLInfo type mapping traits over to //services/network

Bug:  785420 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I67ddf477232a12d3a1848b9982695abce3ec397c
Reviewed-on: https://chromium-review.googlesource.com/773635
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521966}
[modify] https://crrev.com/c57342548c713379572cad67d74cd02daa9679bc/content/common/BUILD.gn
[modify] https://crrev.com/c57342548c713379572cad67d74cd02daa9679bc/content/common/resource_messages.cc
[modify] https://crrev.com/c57342548c713379572cad67d74cd02daa9679bc/content/common/resource_messages.h
[modify] https://crrev.com/c57342548c713379572cad67d74cd02daa9679bc/content/public/common/ssl_info.typemap
[modify] https://crrev.com/c57342548c713379572cad67d74cd02daa9679bc/content/public/common/url_loader_completion_status.typemap
[modify] https://crrev.com/c57342548c713379572cad67d74cd02daa9679bc/services/network/DEPS
[modify] https://crrev.com/c57342548c713379572cad67d74cd02daa9679bc/services/network/public/cpp/BUILD.gn
[modify] https://crrev.com/c57342548c713379572cad67d74cd02daa9679bc/services/network/public/cpp/OWNERS
[add] https://crrev.com/c57342548c713379572cad67d74cd02daa9679bc/services/network/public/cpp/ssl_info_ipc_traits.cc
[add] https://crrev.com/c57342548c713379572cad67d74cd02daa9679bc/services/network/public/cpp/ssl_info_ipc_traits.h

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00cae7118d91e596b9f10be3d7e60fa9ae8b830b

commit 00cae7118d91e596b9f10be3d7e60fa9ae8b830b
Author: Jun Cai <juncai@chromium.org>
Date: Mon Dec 18 20:05:13 2017

NetworkService: Move HostPortPair and HttpRequestHeaders traits to //services/network

This CL moves HostPortPair and HttpRequestHeaders type mapping traits
from //content/public/common/ to //services/network/public/cpp/.

Bug:  785420 ,  783996 
Change-Id: I9b8c299e26c2e33164165e12d08da69c2f965619
Reviewed-on: https://chromium-review.googlesource.com/828159
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524775}
[modify] https://crrev.com/00cae7118d91e596b9f10be3d7e60fa9ae8b830b/content/common/resource_messages.h
[modify] https://crrev.com/00cae7118d91e596b9f10be3d7e60fa9ae8b830b/content/public/common/common_param_traits.cc
[modify] https://crrev.com/00cae7118d91e596b9f10be3d7e60fa9ae8b830b/content/public/common/common_param_traits.h
[modify] https://crrev.com/00cae7118d91e596b9f10be3d7e60fa9ae8b830b/content/public/common/common_param_traits_macros.h
[add] https://crrev.com/00cae7118d91e596b9f10be3d7e60fa9ae8b830b/content/public/common/network_param.typemap
[delete] https://crrev.com/afc57f37df7c22acdf96966c033d1635ce9af054/content/public/common/ssl_info.typemap
[modify] https://crrev.com/00cae7118d91e596b9f10be3d7e60fa9ae8b830b/content/public/common/typemaps.gni
[modify] https://crrev.com/00cae7118d91e596b9f10be3d7e60fa9ae8b830b/services/network/public/cpp/BUILD.gn
[rename] https://crrev.com/00cae7118d91e596b9f10be3d7e60fa9ae8b830b/services/network/public/cpp/network_param_ipc_traits.cc
[rename] https://crrev.com/00cae7118d91e596b9f10be3d7e60fa9ae8b830b/services/network/public/cpp/network_param_ipc_traits.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 3 2018

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb08cbdef8574d0fa2218d90f08cf8237e481656

commit eb08cbdef8574d0fa2218d90f08cf8237e481656
Author: Randy Smith <rdsmith@chromium.org>
Date: Sat Jan 13 02:09:16 2018

Move EffectiveConnectionType and NetworkConnectionType to //services/network.

Bug:  785420 
Change-Id: Icc6bf5a17290e714d6f3ed49f3bda0dd4cf22efb
Reviewed-on: https://chromium-review.googlesource.com/852385
Commit-Queue: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529145}
[modify] https://crrev.com/eb08cbdef8574d0fa2218d90f08cf8237e481656/content/common/native_types.mojom
[modify] https://crrev.com/eb08cbdef8574d0fa2218d90f08cf8237e481656/content/common/native_types.typemap
[modify] https://crrev.com/eb08cbdef8574d0fa2218d90f08cf8237e481656/content/common/renderer.mojom
[modify] https://crrev.com/eb08cbdef8574d0fa2218d90f08cf8237e481656/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/eb08cbdef8574d0fa2218d90f08cf8237e481656/services/network/public/cpp/BUILD.gn
[modify] https://crrev.com/eb08cbdef8574d0fa2218d90f08cf8237e481656/services/network/public/cpp/network_param_ipc_traits.h
[add] https://crrev.com/eb08cbdef8574d0fa2218d90f08cf8237e481656/services/network/public/cpp/network_types.typemap
[modify] https://crrev.com/eb08cbdef8574d0fa2218d90f08cf8237e481656/services/network/public/cpp/typemaps.gni
[modify] https://crrev.com/eb08cbdef8574d0fa2218d90f08cf8237e481656/services/network/public/interfaces/BUILD.gn
[add] https://crrev.com/eb08cbdef8574d0fa2218d90f08cf8237e481656/services/network/public/interfaces/network_types.mojom

Mergedinto: 753658
Status: Duplicate (was: Untriaged)
John's generalized his bug, so I'll merge this one in.

Sign in to add a comment