Muted sites should not always show a mute icon in the tab |
|||||||
Issue descriptionWhen we added tab icons for sites playing sound, we decided to only show the icon when audio was actually playing. Then when we added the ability to mute, we decided that if a user took manual action to mute, we should leave the "muted" icon around even when the site was no longer trying to play audio, since there was no other easy way to see anything had been changed from the default setting for that page. Since then, we've changed "mute tab" to "mute site" and added a global default mute setting. These settings provide the ability to default some or all sites to being muted all the time. When this is the case, the tabs in question always have a "muted" icon on them (so, if you default to muting all sites, all tabs will have a "muted" icon). I think this is largely an oversight. It's inconsistent with how we deal with other content settings, where we show indicators only when the setting has kicked in (e.g. when a popup is blocked). It's inconsistent with the idea of showing you a "remember, you changed something from the default setting for this page" icon that the mute icon preservation originally had. It's redundant with the information/toggle for this available in the page info dropdown. And it's distracting. I think given how we've changed the functionality of muting (to make it persistent), the best course of action at this point is to reverse our earlier decision, and only show the "muted" icon when a tab is actually trying to play sound. miu, do you know who owns this?
,
Nov 15 2017
I agree: That the muted icon should only show when the page is playing sound (just like the normal, non-muted icon shows only when the page is playing sound). Note 1: Tabs can still be muted via extension APIs. However, I don't feel that's a compelling reason to do anything different. So, IMHO, it'd be good always to only show the indicator while sound is playing (whether muted or not). Note 2: We need to make sure the tooltip/accessibility parts of this are maintained. Should the tooltip always indicate the muted state, regardless of whether sound is playing; or (easier) should the tooltip only be synchronized with the icon, like it is now? steimel@'s probably the right person to own this.
,
Nov 15 2017
The tooltip should be synchronized with the icon; it is basically a written form of the icon's information, and the reasons for saying (or not) that the site is muted at any given time are the same for the tooltip as for the icon.
,
Jan 25 2018
,
Jan 26 2018
Issue 806127 has been merged into this issue.
,
Jan 26 2018
,
Jan 26 2018
Before landing a fix for this, I would like to get feedback from UX as this was on purpose. IMO, the best argument to apply this change is that we can mute *all* websites (which was a last minute change) and indeed having a mute icon on all tabs is pretty much visual pollution. However, having the mute icon helps figuring out that if I go to noisywebsite.com, it will not produce sound. Without it, I'm afraid users could be confused. FWIW, there is an omnibox indicator that reflects if the tab attempted to make sound during the session.
,
Jan 26 2018
It's true that knowing in advance that the tab wouldn't be able to produce sound may be useful. But that argument could also apply to all other content settings where we allow the user to disable/deny permissions, yet we don't show any of those indicators until the site tries to make use of the capability. In practice, most of the sites I visit on this profile don't try to play sound anyway, so this information is not helpful. I imagine that for the few users who flip their global setting to mute, the story is similar.
,
Jan 26 2018
When muting all websites by default and using a lot of tabs, this makes it quite time-consuming to tell which (unmuted) tab is producing sound, as just about every tab will have a speaker-like icon on it, so that it's impossible to tell at a glance where the sound is coming from. I'd like to be able to once again quickly determine the source of a sound so that it can be quickly dealt with if it suddenly gets annoying.
,
Jan 29 2018
Issue 806531 has been merged into this issue.
,
Jan 29 2018
(Talked to Tommy offline for more context) I'm aligned with Mounir's proposed approach, where the mute icon only appears if audio is actively playing on a muted tab.
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d8c81c88ed66d6311932f00414ac0e48d5b701d commit 6d8c81c88ed66d6311932f00414ac0e48d5b701d Author: Tommy Steimel <steimel@chromium.org> Date: Mon Jan 29 23:22:08 2018 Only show mute icon on tab when sound is playing This CL adds a check to WasRecentlyAudible before adding a mute icon to a tab to avoid always showing a mute icon when a tab is muted. This also adds the fade animation to the (mute icon)->(no icon) transition. Since adding the fade animation breaks a TabTest unit test (which worked under the assumption that each of its transitions was instantaneous), this CL also manually stops fade animations in that test. Bug: 785406 Change-Id: I0d7fd732b605f634f9df59b736dd7f19c382a09e Reviewed-on: https://chromium-review.googlesource.com/889178 Reviewed-by: Yuri Wiitala <miu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#532652} [modify] https://crrev.com/6d8c81c88ed66d6311932f00414ac0e48d5b701d/chrome/browser/ui/tabs/tab_utils.cc [modify] https://crrev.com/6d8c81c88ed66d6311932f00414ac0e48d5b701d/chrome/browser/ui/views/tabs/alert_indicator_button.cc [modify] https://crrev.com/6d8c81c88ed66d6311932f00414ac0e48d5b701d/chrome/browser/ui/views/tabs/alert_indicator_button.h [modify] https://crrev.com/6d8c81c88ed66d6311932f00414ac0e48d5b701d/chrome/browser/ui/views/tabs/tab_unittest.cc
,
Jan 29 2018
,
Jan 30 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 30 2018
Pls merge your change to M65 branch 3325 ASAP so we can pick it up for next M65 dev release. Thank you.
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d450fa7807b4ed6b7fd01b0c0edf4dfc59a8f5f7 commit d450fa7807b4ed6b7fd01b0c0edf4dfc59a8f5f7 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Jan 31 00:18:51 2018 Only show mute icon on tab when sound is playing This CL adds a check to WasRecentlyAudible before adding a mute icon to a tab to avoid always showing a mute icon when a tab is muted. This also adds the fade animation to the (mute icon)->(no icon) transition. Since adding the fade animation breaks a TabTest unit test (which worked under the assumption that each of its transitions was instantaneous), this CL also manually stops fade animations in that test. Bug: 785406 Change-Id: I0d7fd732b605f634f9df59b736dd7f19c382a09e Reviewed-on: https://chromium-review.googlesource.com/889178 Reviewed-by: Yuri Wiitala <miu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#532652}(cherry picked from commit 6d8c81c88ed66d6311932f00414ac0e48d5b701d) Reviewed-on: https://chromium-review.googlesource.com/894706 Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#188} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/d450fa7807b4ed6b7fd01b0c0edf4dfc59a8f5f7/chrome/browser/ui/tabs/tab_utils.cc [modify] https://crrev.com/d450fa7807b4ed6b7fd01b0c0edf4dfc59a8f5f7/chrome/browser/ui/views/tabs/alert_indicator_button.cc [modify] https://crrev.com/d450fa7807b4ed6b7fd01b0c0edf4dfc59a8f5f7/chrome/browser/ui/views/tabs/alert_indicator_button.h [modify] https://crrev.com/d450fa7807b4ed6b7fd01b0c0edf4dfc59a8f5f7/chrome/browser/ui/views/tabs/tab_unittest.cc
,
Feb 26 2018
,
Aug 14
similar/related issue, please see comment #6 https://bugs.chromium.org/p/chromium/issues/detail?id=866217 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by raymes@chromium.org
, Nov 15 2017Owner: steimel@chromium.org
Status: Assigned (was: Untriaged)