New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 785402 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OoO until Feb 4th
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

wpt import: Blocked on _CheckIpcOwners presubmit hook

Project Member Reported by raphael....@intel.com, Nov 15 2017

Issue description

e.g. https://luci-milo.appspot.com/buildbot/chromium.infra.cron/wpt-importer/5297, whose complete git-cl upload failure looks like this:

Running presubmit upload checks ...
Traceback (most recent call last):
  File "/data/src/depot_tools/git_cl.py", line 6126, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/data/src/depot_tools/git_cl.py", line 6108, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/data/src/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/data/src/depot_tools/git_cl.py", line 4764, in CMDpresubmit
    change=cl.GetChange(base_branch, None))
  File "/data/src/depot_tools/git_cl.py", line 1576, in RunHook
    gerrit_obj=self._codereview_impl.GetGerritObjForPresubmit())
  File "/data/src/depot_tools/presubmit_support.py", line 1403, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/data/src/depot_tools/presubmit_support.py", line 1311, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 2716, in CheckChangeOnUpload
  File "<string>", line 2474, in _CommonChecks
  File "<string>", line 1592, in _CheckIpcOwners
  File "/usr/lib64/python2.7/json/__init__.py", line 339, in loads
    return _default_decoder.decode(s)
  File "/usr/lib64/python2.7/json/decoder.py", line 364, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib64/python2.7/json/decoder.py", line 382, in raw_decode
    raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded

The faulty file in question is third_party/WebKit/LayoutTests/external/wpt/XMLHttpRequest/resources/utf16-bom.json, from https://github.com/w3c/web-platform-tests/commit/678d58cbcc7491105b316d4d87b5675b3887bfe3
 
https://chromium-review.googlesource.com/c/chromium/src/+/772235 is a possible fix for the problem.

None of the two //PRESUBMIT.py owners are not US-based so wpt-importer may stay red for several hours though.
Owner: raphael....@intel.com
Status: Started (was: Available)
Thanks for the quick fix!

This infra work is never short of surprise ;)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/211f3b4785096f876f2d96c7ca931ede27919c9f

commit 211f3b4785096f876f2d96c7ca931ede27919c9f
Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Date: Thu Nov 16 00:27:16 2017

PRESUBMIT: Add web-platform-tests dir to JSON whitelist

Add third_party/WebKit/LayoutTests/external/wpt to the list of files
containing test JSON data that may be broken and cause parsing failures.

This should unblock imports from the web-platform-tests repository, which
were broken since
https://github.com/w3c/web-platform-tests/commit/678d58cbcc7491105b316d4d87b5675b3887bfe3
introduced a JSON file that broke _CheckIpcOwners().

Bug:  785402 
Change-Id: If4a83b51f60c5d94faad0496802adf4145231e5e
Reviewed-on: https://chromium-review.googlesource.com/772235
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516917}
[modify] https://crrev.com/211f3b4785096f876f2d96c7ca931ede27919c9f/PRESUBMIT.py

Status: Fixed (was: Started)

Sign in to add a comment