Issue metadata
Sign in to add a comment
|
Pixel_OffscreenCanvas* failing on Nexus 5X |
||||||||||||||||||||||
Issue descriptionMultiple tests started failing in https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%205X%29/builds/13229 Also affects android_optional_gpu_tests_rel and ANGLE CQ. Probably needs a rebaseline. Have several suspects in regression range, trying to bisect.
,
Nov 15 2017
OK, I've confirmed this is indeed caused by https://chromium-review.googlesource.com/720019. Fady, can you please verify that the new images are good and rebaseline pixel_tests following the instructions in https://www.chromium.org/developers/how-tos/gpu-wrangling#TOC-Wrangling? Thanks!
,
Nov 15 2017
Ken, maybe we need to add optional GPU bots for changes to some of the directories in https://chromium-review.googlesource.com/720019?
,
Nov 16 2017
Agreed. https://chromium-review.googlesource.com/773560 up for review.
,
Nov 16 2017
Fady doesn't have time to fix this, and the test results look similar here http://chromium-browser-gpu-tests.commondatastorage.googleapis.com/view_test_results.html?6ddbf96264d611b883d034ed674e61031ab4151a_Android_Release_Nexus_5X__telemetry so I will take care of rebaselining.
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbedc5d3615883063141f7347f87962b45d5546e commit fbedc5d3615883063141f7347f87962b45d5546e Author: Kenneth Russell <kbr@chromium.org> Date: Thu Nov 16 20:53:21 2017 Run GPU tests on Android against cc and viz changes. These can easily affect pixel test results so it's essential that this trybot be triggered for such changes. BUG= 785392 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I5ba69ac4cf46b843fd507b85234985915ed47c8d Reviewed-on: https://chromium-review.googlesource.com/773560 Reviewed-by: enne <enne@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#517178} [modify] https://crrev.com/fbedc5d3615883063141f7347f87962b45d5546e/cc/PRESUBMIT.py [modify] https://crrev.com/fbedc5d3615883063141f7347f87962b45d5546e/components/viz/PRESUBMIT.py [modify] https://crrev.com/fbedc5d3615883063141f7347f87962b45d5546e/services/viz/PRESUBMIT.py
,
Nov 16 2017
Sorry about that. I was in a meeting when Yuly asked me about this. He asked me if I will fix this or whether he can take it. I responded that I am in a meeting and if he had cycles, then sure, he can take it. I did not intend for this to sound like I don't have time to rebase tests, I just didn't at the moment I was messaged.
,
Nov 16 2017
Sorry, that nuance wasn't clear from the comment above. I deliberately didn't post my criticism on this bug.
,
Nov 16 2017
Sorry that I wasn't clear about that in comment #5.
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b66075f65f862b9cf153df9afb3a7278333f4244 commit b66075f65f862b9cf153df9afb3a7278333f4244 Author: Yuly Novikov <ynovikov@chromium.org> Date: Fri Nov 17 15:52:24 2017 Rebaseline pixel_tests After https://chromium-review.googlesource.com/720019 changed scaling. BUG= 785392 TBR=kbr@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If9b38cd6e915a547743ff21f6267847ef48adcbf Reviewed-on: https://chromium-review.googlesource.com/775156 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#517406} [modify] https://crrev.com/b66075f65f862b9cf153df9afb3a7278333f4244/content/test/gpu/gpu_tests/pixel_expectations.py [modify] https://crrev.com/b66075f65f862b9cf153df9afb3a7278333f4244/content/test/gpu/gpu_tests/pixel_test_pages.py
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a13c9d521e1d75446f1b377a75f318863875ff1d commit a13c9d521e1d75446f1b377a75f318863875ff1d Author: Yuly Novikov <ynovikov@chromium.org> Date: Fri Nov 17 21:49:34 2017 Rebaseline pixel_tests followup Restore the expectations to pre-rebaseline state BUG= 785392 TBR=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iad39cd20872f7640e666c66b44a59aef1d1b1c36 Reviewed-on: https://chromium-review.googlesource.com/777684 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#517572} [modify] https://crrev.com/a13c9d521e1d75446f1b377a75f318863875ff1d/content/test/gpu/gpu_tests/pixel_expectations.py
,
Nov 17 2017
,
Nov 17 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kainino@chromium.org
, Nov 15 2017Summary: Pixel_OffscreenCanvas* failing on Nexus 5X (was: pixel_test fails on Nexus 5X)