New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 785391 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

"Always show" is confusing text on pop-up blocker UI

Project Member Reported by rsch...@chromium.org, Nov 15 2017

Issue description

When a pop-up is blocked, we show an infobar with a string (being discussed in  issue 731328 ) and a button that reads "Always show". This is confusing because:

1) It's not clear if it means always show pop-ups, or always show the infobar that a pop-up has been blocked
2) It's not clear if "always" means for this domain, or truly always (global setting)

One suggested option is "Show pop-up", though this may not indicate that the setting is sticky for the domain.

Shimi, assiging to you but feel free to re-assign :)
 
4439169932661359396.png
77.5 KB View Download

Comment 1 by srahim@chromium.org, Nov 15 2017

I agree the string is confusing. 
1) If it's domain-specific, we could use a string like "Show pop-ups on this site"
2) "for this site" would be clearer than "always"

"Show pop-ups on this site" won't fit in a button. Per discussion with hannahs@, we could use the mini infobar style to accommodate this CTA and since the body string is so short. Quickie examples attached.
popup blocked-mini info bar.png
13.9 KB View Download
Thanks! I like them both, with a preference for the slightly longer one ("Show popups on this site"). I think that does a good job of indicating that "show" refers to the popup, and not the infobar.

Nit: do we use "popup" or "pop-up"? I actually don't remember.

Comment 3 by srahim@chromium.org, Nov 15 2017

I see my own string reflects our general inconsistency in the UI:

~6 instances of "pop-up"
~10 of "popup"
~2 instances of "pop up" [noun], which I wouldn't recommend

Typically, hyphen usage in compound words drops off after a word becomes commonplace. For now, based on a quick Google Trends search, I'm inclined to keep the hyphen. 
 

Comment 4 by srahim@chromium.org, Nov 15 2017

Cleaned up the mock w/the preferred string. The longer string is my preference, too. 

Assigning to Hannah to review & for next steps.
Pop-up blocked-mini-infobar-2lines.png
7.3 KB View Download

Comment 5 by srahim@chromium.org, Nov 15 2017

Owner: hannahs@chromium.org
Looks like other browsers tend to use pop-up, though MDN uses popup: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/PopupGuide

I'm fine either way.
I think we should be as consistent as possible with permission prompts. They currently don't emphasize that the decision is permanent for the site (especially on desktop), and if we do something like that here we should update those prompts too.
qq: Most infobars on Android use a linear layout with wrapped text. Which existing infobar has "title + subtitle" layout that the proposed design in #4 shows?

Sign in to add a comment