New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 785389 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 787039
issue 813079

Blocking:
issue 634542



Sign in to add a comment

Add color management to DrawingBuffer

Project Member Reported by zakerinasab@chromium.org, Nov 15 2017

Issue description

Now that half float storage is supported in DrawingBuffer, we can move forward with adding color management to DrawingBuffer functions.


 
Labels: -Pri-3 Pri-2
Blockedon: 787039
Blocking: 634542
Update: this has been addressed partially in different CLs, specially when adding color management to toBlob and toDataURL.
Blockedon: 813079
Project Member

Comment 6 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3de68da5fcc2b3594795b6afb7699a42e931999e

commit 3de68da5fcc2b3594795b6afb7699a42e931999e
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Thu May 10 19:19:12 2018

Add color management to ImageBitmapRenderingContext

This change adds color management to ImageBitmapRenderingContext.

Bug:  782383 ,  785389 ,  796226 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I653bc2e5d3a32f5211bd09c80ee35b6f4df6ad92
Reviewed-on: https://chromium-review.googlesource.com/973801
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557619}
[add] https://crrev.com/3de68da5fcc2b3594795b6afb7699a42e931999e/third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/transferFromImageBitmap.html
[modify] https://crrev.com/3de68da5fcc2b3594795b6afb7699a42e931999e/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/3de68da5fcc2b3594795b6afb7699a42e931999e/third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc
[modify] https://crrev.com/3de68da5fcc2b3594795b6afb7699a42e931999e/third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.cc
[modify] https://crrev.com/3de68da5fcc2b3594795b6afb7699a42e931999e/third_party/blink/renderer/platform/graphics/gpu/image_layer_bridge.h
[modify] https://crrev.com/3de68da5fcc2b3594795b6afb7699a42e931999e/third_party/blink/renderer/platform/graphics/offscreen_canvas_resource_provider.cc
[modify] https://crrev.com/3de68da5fcc2b3594795b6afb7699a42e931999e/third_party/blink/renderer/platform/graphics/skia/skia_utils.cc
[modify] https://crrev.com/3de68da5fcc2b3594795b6afb7699a42e931999e/third_party/blink/renderer/platform/graphics/skia/skia_utils.h
[add] https://crrev.com/3de68da5fcc2b3594795b6afb7699a42e931999e/third_party/blink/renderer/platform/graphics/skia/skia_utils_test.cc
[modify] https://crrev.com/3de68da5fcc2b3594795b6afb7699a42e931999e/third_party/blink/renderer/platform/graphics/unaccelerated_static_bitmap_image.cc

Status: Fixed (was: Assigned)
This should be fixed now.

Sign in to add a comment