New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 785383 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 775677



Sign in to add a comment

The SafeDialDeviceDescriptionParser should not use UtilityProcessMojoClient anymore.

Project Member Reported by jcivelli@chromium.org, Nov 15 2017

Issue description

As part of the effort to deprecate UtilityProcessMojoClient, the SafeDialDeviceDescriptionParser should be changed to use the SafeXmlParser so it does not need to use UtilityProcessMojoClient anymore.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aee0e34550775be730930ad8e0be733819d22617

commit aee0e34550775be730930ad8e0be733819d22617
Author: Jay Civelli <jcivelli@google.com>
Date: Thu Nov 30 00:10:43 2017

Changing SafeDialDeviceDescriptionParser to use the SafeXmlParser.

Changing SafeDialDeviceDescriptionParser so it does not use its own
utility process to perform parsing of the DIAL XML. Instead, it now uses
the generic SafeXmlParser which parses the XML in a utility process and
returns a base::Value tree representing the XML content.

The parsing logic has been moved from
chrome/utility/media_router/dial_device_description_parser_impl.cc to
chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.cc
and dial_device_description_parser_impl_unittest.cc as been moved to
safe_dial_device_description_parser_unittest.cc.

Client of this code have also been changed to pass along a
service_manager::Connector which is needed by the SafeXmlParser.

Bug:  785383 ,  789295 
Change-Id: I2ff445ae8bc3633c9ba4ddc09a06c9fa724821af
Reviewed-on: https://chromium-review.googlesource.com/770920
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520318}
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/app/generated_resources.grd
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/browser/media/DEPS
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/browser/media/router/discovery/BUILD.gn
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/browser/media/router/discovery/dial/device_description_service.cc
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/browser/media/router/discovery/dial/device_description_service.h
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/browser/media/router/discovery/dial/device_description_service_unittest.cc
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.cc
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.h
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl_unittest.cc
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/browser/media/router/discovery/dial/dial_media_sink_service_proxy.cc
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/browser/media/router/discovery/dial/dial_media_sink_service_proxy.h
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/browser/media/router/discovery/dial/dial_media_sink_service_proxy_unittest.cc
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/browser/media/router/discovery/dial/parsed_dial_device_description.cc
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/browser/media/router/discovery/dial/parsed_dial_device_description.h
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.cc
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser.h
[add] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/browser/media/router/discovery/dial/safe_dial_device_description_parser_unittest.cc
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/browser/media/router/media_router_metrics.cc
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/browser/media/router/media_router_metrics.h
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/browser/media/router/media_router_metrics_unittest.cc
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/common/BUILD.gn
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/common/media_router/mojo/BUILD.gn
[delete] https://crrev.com/c02528e6e9ec0f8fb30740b5c123bbe6e60dc2ac/chrome/common/media_router/mojo/dial_device_description_parser.mojom
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/test/BUILD.gn
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/utility/BUILD.gn
[modify] https://crrev.com/aee0e34550775be730930ad8e0be733819d22617/chrome/utility/chrome_content_utility_client.cc
[delete] https://crrev.com/c02528e6e9ec0f8fb30740b5c123bbe6e60dc2ac/chrome/utility/media_router/dial_device_description_parser_impl.cc
[delete] https://crrev.com/c02528e6e9ec0f8fb30740b5c123bbe6e60dc2ac/chrome/utility/media_router/dial_device_description_parser_impl.h
[delete] https://crrev.com/c02528e6e9ec0f8fb30740b5c123bbe6e60dc2ac/chrome/utility/media_router/dial_device_description_parser_impl_unittest.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment