Correct SKU map for fizz |
|||
Issue descriptionAt present fizz has workarounds in mosys for the SKU mapping. We should tidy this up.
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/8a5f8d849dc6d1ad829f23be7245a6b7c53ff73a commit 8a5f8d849dc6d1ad829f23be7245a6b7c53ff73a Author: Simon Glass <sjg@chromium.org> Date: Tue Nov 21 23:58:39 2017 chromeos-config: Allow a SKU ID of -1 The absense of a SKU ID is actually a useful thing to match on in at least one case. Fizz has models with SKU IDs but the original device did not have one. We still want to match it. Update the validator to permit a SKU ID of -1. This can be done in the config by putting the value in brackets: simple-sku-map = < (-1) &fizz >; BUG= chromium:785366 TEST=emerge-fizz -q --nodeps chromeos-config-bsp See that it allows this Change-Id: Ie47c8202c8bec0faf570af58f547503dbc290b3f Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/772391 Tested-by: YH Lin <yueherngl@chromium.org> Reviewed-by: YH Lin <yueherngl@chromium.org> [modify] https://crrev.com/8a5f8d849dc6d1ad829f23be7245a6b7c53ff73a/chromeos-config/cros_config_host/validate_config_unittest.py [modify] https://crrev.com/8a5f8d849dc6d1ad829f23be7245a6b7c53ff73a/chromeos-config/cros_config_host/validate_config.py
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/mosys/+/2da4d03a7fcfa398a5278d2f5260ebbfbd1223a1 commit 2da4d03a7fcfa398a5278d2f5260ebbfbd1223a1 Author: YH Lin <yueherngl@chromium.org> Date: Wed Nov 22 05:36:18 2017 Revert "mosys: fix erroneous fizz detection" Creating revert for experiment. This reverts commit 0cadaa95434c27e1e869522ae58eaa91e13040fa. BUG= chromium:785366 BRANCH=none CQ-DEPEND=CL:*488315 TEST=emerge-fizz -q --nodeps chromeos-config-bsp chromeos-config mosys Manual test on Fizz: $ /tmp/mosys platform model fizz Change-Id: I02cf3bac146d147ef12b4ce8187d533342ca5b5b Reviewed-on: https://chromium-review.googlesource.com/736629 Commit-Ready: YH Lin <yueherngl@chromium.org> Tested-by: YH Lin <yueherngl@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> [modify] https://crrev.com/2da4d03a7fcfa398a5278d2f5260ebbfbd1223a1/platform/fizz/fizz.c
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/51a09faa49f08a650ae073cc8f27edee73174b72 commit 51a09faa49f08a650ae073cc8f27edee73174b72 Author: Simon Glass <sjg@chromium.org> Date: Thu Nov 30 21:06:49 2017 chromeos-config: Allow a SKU ID of -1 The absense of a SKU ID is actually a useful thing to match on in at least one case. Fizz has models with SKU IDs but the original device did not have one. We still want to match it. Update the validator to permit a SKU ID of -1. This can be done in the config by putting the value in brackets: simple-sku-map = < (-1) &fizz >; BUG= chromium:785366 TEST=emerge-fizz -q --nodeps chromeos-config-bsp See that it allows this Change-Id: Ie47c8202c8bec0faf570af58f547503dbc290b3f Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/772391 Tested-by: YH Lin <yueherngl@chromium.org> Reviewed-by: YH Lin <yueherngl@chromium.org> (cherry picked from commit 8a5f8d849dc6d1ad829f23be7245a6b7c53ff73a) Reviewed-on: https://chromium-review.googlesource.com/801194 Commit-Queue: YH Lin <yueherngl@chromium.org> [modify] https://crrev.com/51a09faa49f08a650ae073cc8f27edee73174b72/chromeos-config/cros_config_host/validate_config_unittest.py [modify] https://crrev.com/51a09faa49f08a650ae073cc8f27edee73174b72/chromeos-config/cros_config_host/validate_config.py
,
Jan 3 2018
There is still a problem with the cros_config support but I'm tracking that in crbug.com/798566 |
|||
►
Sign in to add a comment |
|||
Comment 1 by sjg@chromium.org
, Nov 17 2017Owner: yueherngl@chromium.org