Invalid test decode-audio-data-neuter |
|||||
Issue description
In decode-audio-data-neuter.html, we have a test:
should(
context.decodeAudioData(buffer),
'decodeAudioData on neutered buffer')
.beRejected('TypeError')
.then(() => task.done());
The method beRejected doesn't actually take any arguments. This
should actually call beRejectedWith, which checks that the promise is
rejected with the given reason.
But see also issue 701812.
,
Nov 15 2017
,
Nov 15 2017
,
Nov 15 2017
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9219b4b9fd8d88113e525975dd6418cbbd132a04 commit 9219b4b9fd8d88113e525975dd6418cbbd132a04 Author: Raymond Toy <rtoy@chromium.org> Date: Thu Nov 16 19:14:14 2017 decodeAudioData should reject with DataCloneError Test incorrectly called beRejected with an argument. It should have used beRejectedWith. But the error was also incorrectly set to TypeError when it should have been DataCloneError according to the spec. Bug: 785359 Test: decodeAudioData/decode-audio-data-neuter.html Change-Id: I31be85867c2e792d1b79ec63105aadcf8f98dea7 Reviewed-on: https://chromium-review.googlesource.com/772353 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#517145} [modify] https://crrev.com/9219b4b9fd8d88113e525975dd6418cbbd132a04/third_party/WebKit/LayoutTests/webaudio/decodeAudioData/decode-audio-data-neuter.html
,
Nov 27 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by rtoy@chromium.org
, Nov 15 2017